Multipath for HOST p2p routes

2014-11-04 Thread Martin Pieuchot
How are we suppose to support configuration with multiple p2p interfaces pointing to the same destination address? Right now only one route to host is added. Diff below replaces a hack that move a host route from one p2p interface to another by always installing MPATH routes. It assumes that

Kill in_iawithaddr()

2014-11-04 Thread Martin Pieuchot
This function is just a wrapper around ifa_ifwithaddr() and I'd prefer to have less function iterating over the global list of interfaces. ok? Index: netinet/ip_input.c === RCS file: /home/ncvs/src/sys/netinet/ip_input.c,v

Re: Multipath for HOST p2p routes

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 12:51, Martin Pieuchot mpieuc...@nolizard.org wrote: How are we suppose to support configuration with multiple p2p interfaces pointing to the same destination address? Right now only one route to host is added. Diff below replaces a hack that move a host route from one p2p

Re: Kill in_iawithaddr()

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 12:52, Martin Pieuchot mpieuc...@nolizard.org wrote: This function is just a wrapper around ifa_ifwithaddr() and I'd prefer to have less function iterating over the global list of interfaces. ok? what's not immediately apparent is that it also makes sure that the address

network pool names

2014-11-04 Thread Martin Pieuchot
Remove pl suffix, ok? Index: net/pipex.c === RCS file: /home/ncvs/src/sys/net/pipex.c,v retrieving revision 1.61 diff -u -p -r1.61 pipex.c --- net/pipex.c 28 Oct 2014 09:45:37 - 1.61 +++ net/pipex.c 4 Nov 2014 12:16:06

Re: Kill in_iawithaddr()

2014-11-04 Thread Martin Pieuchot
On 04/11/14(Tue) 13:20, Mike Belopuhov wrote: On 4 November 2014 12:52, Martin Pieuchot mpieuc...@nolizard.org wrote: This function is just a wrapper around ifa_ifwithaddr() and I'd prefer to have less function iterating over the global list of interfaces. ok? what's not immediately

Re: network pool names

2014-11-04 Thread David Gwynne
On 4 Nov 2014, at 10:23 pm, Martin Pieuchot mpieuc...@nolizard.org wrote: Remove pl suffix, ok? ok Index: net/pipex.c === RCS file: /home/ncvs/src/sys/net/pipex.c,v retrieving revision 1.61 diff -u -p -r1.61 pipex.c ---

Re: network pool names

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 13:23, Martin Pieuchot mpieuc...@nolizard.org wrote: Remove pl suffix, ok? ok with a syncache instead of syn

Fix use-after-free in yppush(8)

2014-11-04 Thread Dimitris Papastamos
Hi, It seems to me that we should not free `pfd' at this point. The saved max poll fd is not reset to 0 and I do not see any guarantees that `pfd' will point to valid memory after calling free() here. Other code that follows the same style, like mountd(8) and rpc.rstatd(8) do not do this. OK?

Fix for CVE-2014-3710 in file(1)

2014-11-04 Thread Matthias Pitzl
Hello! This patch fixes the CVE-2014-3710 for the file(1) tool. Almost same patch has been applied upstream to devel/libmagic too: https://github.com/file/file/commit/39c7ac1106be844a5296d3eb5971946cc09ffda0 Greetings, Matthias --- usr.bin/file/readelf.c Wed Oct 28 00:59:38 2009 +++

Re: Fix use-after-free in yppush(8)

2014-11-04 Thread Todd C. Miller
On Tue, 04 Nov 2014 14:27:39 +, Dimitris Papastamos wrote: It seems to me that we should not free `pfd' at this point. The saved max poll fd is not reset to 0 and I do not see any guarantees that `pfd' will point to valid memory after calling free() here. Other code that follows the

5.6 ... small detail

2014-11-04 Thread David Carlier
Hi all, Just updated to 5.6 and was happy to see that gets(3) was removed for good ... althought it seems to be still available only in the man page. Kind regards.

Re: 5.6 ... small detail

2014-11-04 Thread David Carlier
Thanks ! On 4 November 2014 19:00, Otto Moerbeek o...@drijf.net wrote: On Tue, Nov 04, 2014 at 01:49:32PM -0500, Ted Unangst wrote: On Tue, Nov 04, 2014 at 16:38, David Carlier wrote: Hi all, Just updated to 5.6 and was happy to see that gets(3) was removed for good ...

Re: LibreSSL: GOST ciphers implementation

2014-11-04 Thread Dmitry Eremin-Solenikov
Hello, 2014-10-20 13:57 GMT+04:00 Dmitry Eremin-Solenikov dbarysh...@gmail.com: Hello, It took a while longer than I expected, but I think that the GOST ciphers implementation is complete now at https://github.com/libressl-portable/openbsd/pull/6 I still expect issues when Windows GOST CSP

Re: LibreSSL: GOST ciphers implementation

2014-11-04 Thread Miod Vallat
Two weeks has passed. Is there anything that I can do to push GOST ciphers towards LibreSSL? Sorry about that. Joel and/or I need to review the diff again and push it. I'll try to find time for this next week-end (famous last words). Miod

Re: pool page colouring

2014-11-04 Thread David Gwynne
On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring altogether or setting it from something else completely. i just want a decision to be made cos right now ph_color isnt

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 01:12, Mike Belopuhov m...@belopuhov.com wrote: well, first of all, right now this is a rather theoretical gain. we need to test it to understand if it makes things easier. err. i meant to say go faster not easier.

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 00:38, David Gwynne da...@gwynne.id.au wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring altogether or setting it from something else completely. i

Re: pool page colouring

2014-11-04 Thread David Gwynne
On 5 Nov 2014, at 10:12, Mike Belopuhov m...@belopuhov.com wrote: On 5 November 2014 00:38, David Gwynne da...@gwynne.id.au wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either

Re: pool page colouring

2014-11-04 Thread David Gwynne
On 5 Nov 2014, at 10:27, David Gwynne da...@gwynne.id.au wrote: On 5 Nov 2014, at 10:12, Mike Belopuhov m...@belopuhov.com wrote: On 5 November 2014 00:38, David Gwynne da...@gwynne.id.au wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014

Re: pool page colouring

2014-11-04 Thread Ted Unangst
On Wed, Nov 05, 2014 at 09:38, David Gwynne wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring altogether or setting it from something else completely. i just want a

Re: pool page colouring

2014-11-04 Thread David Gwynne
On 5 Nov 2014, at 10:58, Ted Unangst t...@tedunangst.com wrote: On Wed, Nov 05, 2014 at 09:38, David Gwynne wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring

xenocara make release clobbers SHA256

2014-11-04 Thread thevoid
i don't know if this is expected behaviour or not, but doing a 'make release' for xenocara using the same directory as for base overwrites SHA256. the line in /usr/xenocara/Makefile is: cksum -a sha256 x*tgz SHA256 looking back its been there for a while, one change in on 10Jan:

Re: pool page colouring

2014-11-04 Thread Ted Unangst
On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: when i shuffled the locking in pools around, page colouring was left behind. page colouring is where you offset items within a page if you have enough slack space. the previous implementation simply incremented the colour so each new page