Re: removing sys/hash.h

2014-12-03 Thread Janne Johansson
random tip from the side, openbsd gcc doesn't put timestamps on object files, so if you compile it once before your change, md5 the .o file and once more after your change, you can verify that it doesn't have an impact on the generated code. 2014-12-04 2:17 GMT+01:00 Max Fillinger : > I had a lo

Re: removing sys/hash.h

2014-12-03 Thread Ted Unangst
On Thu, Dec 04, 2014 at 02:17, Max Fillinger wrote: > I had a look at httpd, and it appears that it doesn't actually use > any functions defined in sys/hash.h. Same for md5.h and sha1.h in > httpd.c. After removing those includes, it compiles and runs, but I > didn't do any serious testing. indeed

Re: Fix mfi to set drive state (offline, rebuild..) properly

2014-12-03 Thread David Gwynne
> On 29 Nov 2014, at 12:20, YASUOKA Masahiko wrote: > > I'm using NEC Express5800 with its optional RAID contoller, but I > could not set the drive state into rebuild or offline by bioctl(8). > > Tsubai found mfi(4) needs to be fixed to operate the firmware > interface properly. > > I'd like t

Re: removing sys/hash.h

2014-12-03 Thread Max Fillinger
I had a look at httpd, and it appears that it doesn't actually use any functions defined in sys/hash.h. Same for md5.h and sha1.h in httpd.c. After removing those includes, it compiles and runs, but I didn't do any serious testing. Index: usr.sbin/httpd/httpd.c

Re: syslogd: properly validate config

2014-12-03 Thread Alexander Bluhm
On Thu, Nov 27, 2014 at 10:04:59PM +0100, Tobias Stoeckmann wrote: > On Thu, Nov 27, 2014 at 09:52:29PM +0100, Tobias Stoeckmann wrote: > > On Thu, Nov 27, 2014 at 01:29:48PM -0700, Todd C. Miller wrote: > > > I think it would be better for decode() to just return -1 in this > > > case. > > > > I

Re: pf(4) and "struct route"

2014-12-03 Thread Alexander Bluhm
On Wed, Nov 26, 2014 at 03:21:43PM +0100, Martin Pieuchot wrote: > @@ -5459,7 +5448,6 @@ pf_routable(struct pf_addr *addr, sa_fam > > /* Perform uRPF check if passed input interface */ > ret = 0; > - rt = ro.ro_rt; > do { >

Re: rdomain & IPv6 local addresses

2014-12-03 Thread Alexander Bluhm
On Wed, Nov 26, 2014 at 03:09:08PM +0100, Martin Pieuchot wrote: > While debugging the recent "route change" regression I found various > bugs in the code handling IPv6 addresses. The most ugly one, because > it leaves you with a null ifp pointer in your routing table, is fixed > by the diff below

Re: siphash in dirhash

2014-12-03 Thread David Gwynne
cool. reads and tests well for me. ok dlg@ > On 3 Dec 2014, at 13:49, Ted Unangst wrote: > > Use now preferred SipHash24 functions. This also means we shouldn't > need to hash in the value of the dirhash pointer itself, which confuses > me every time I look at it. > > Index: ufs/ufs_dirhash.c

Re: struct route

2014-12-03 Thread Alexander Bluhm
On Tue, Nov 25, 2014 at 04:39:38PM +0100, Martin Pieuchot wrote: > 3 places where we don't need any "struct route". ok? OK bluhm@ > > Index: netinet/ip_icmp.c > === > RCS file: /home/ncvs/src/sys/netinet/ip_icmp.c,v > retrieving re

Re: Behavior of changing routes on OpenBSD 5.6

2014-12-03 Thread Alexander Bluhm
On Wed, Nov 26, 2014 at 12:58:35PM +0100, Martin Pieuchot wrote: > @@ -761,7 +754,17 @@ report: > error = EDQUOT; > goto flush; > } > - ifa = info.rti_ifa; > + /* > +

Re: ip_input() refactoring

2014-12-03 Thread Alexander Bluhm
On Thu, Nov 13, 2014 at 03:42:07PM +0100, Martin Pieuchot wrote: > It also increments rt_use counters for the local routes, (say yeah!). We have in net/route.h u_int64_t rmx_pksent; /* packets sent using this route */ #define rt_use rt_rmx.rmx_pksent So the comment implies that

md5 ot sha512 in in6

2014-12-03 Thread Ted Unangst
Convert another md5 to sha512. Index: in6_ifattach.c === RCS file: /cvs/src/sys/netinet6/in6_ifattach.c,v retrieving revision 1.77 diff -u -p -r1.77 in6_ifattach.c --- in6_ifattach.c 20 Nov 2014 09:55:57 - 1.77 +++ in6_i

Re: patch: Intel CPU sensor readout correction

2014-12-03 Thread Simon Mages
Hi, i would like to ask if everything's ok with my patch. If somethings wrong, tell me, i'll fix it. I think this patch is a nice correction of the temperature readout of Intel CPU's. I tested this patch on some CPU's and everything looks fine so far. BR Simon 2014-11-27 12:44 GMT+01:00, Mag

Re: syslogd: log socket path truncation

2014-12-03 Thread Todd C. Miller
On Tue, 02 Dec 2014 23:04:39 +0100, Nicolas Bedos wrote: > syslogd fails strangely when the path of a log socket exceeds > sizeof(sun_path) (defined in sys/un.h as 104) by one byte. Thanks, committed. - todd

Re: current smtpd: auth failed when username <= 31 chars, Syntax error when username > 31

2014-12-03 Thread Abel Abraham Camarillo Ojeda
On Wed, Dec 3, 2014 at 9:10 AM, Abel Abraham Camarillo Ojeda wrote: > Hi Gilles, > > On Wed, Dec 3, 2014 at 8:27 AM, Gilles Chehade wrote: >> Nope it shouldn't because: >> >>> > listen on egress tls pki test.verlet.org auth >> >> This will authenticate users against the system and will use the us

Re: current smtpd: auth failed when username <= 31 chars, Syntax error when username > 31

2014-12-03 Thread Abel Abraham Camarillo Ojeda
Hi Gilles, On Wed, Dec 3, 2014 at 8:27 AM, Gilles Chehade wrote: > Nope it shouldn't because: > >> > listen on egress tls pki test.verlet.org auth > > This will authenticate users against the system and will use the username > you provide in the SMTP session as the login to search credentials for

Re: current smtpd: auth failed when username <= 31 chars, Syntax error when username > 31

2014-12-03 Thread Gilles Chehade
Nope it shouldn't because: > > listen on egress tls pki test.verlet.org auth This will authenticate users against the system and will use the username you provide in the SMTP session as the login to search credentials for. Therefore, when you configure your MUA to send an email address as the us

tcpdump follows incorrect alignment requirement rules

2014-12-03 Thread Mike Belopuhov
bpf aligns data following the datalink header (e.g. ethernet) on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's uint32_t instead of a long. And also since then almost all packets become "unaligned" from the tcpdump perspective and require costly copies into the internal buffer. Neither