[patch] nm: some code cleanup

2015-06-18 Thread Sébastien Marie
Some code cleanup: - disable elf_load_phdrs() and elf_fix_phdrs() functions as there aren't in used. I also add a comment for elf_load_phdrs(): the code seems as buggy as elf_load_shdrs() against crafted input. Some other code could be dead too: I have not investigated a lot in this d

[patch] nm: on error, set globals to NULL

2015-06-18 Thread Sébastien Marie
Hi, This patch ensure that when an error is detected, the freed variables in elf_symloadx() are reinitialised. Else show_file() in nm.c will used these variables, even if they has just been freed. (nm.c +689). Problem found by afl. -- Sébastien Marie Index: elf.c =

[patch] nm: minimal section header size

2015-06-18 Thread Sébastien Marie
Hi, This patch ensure that e_shentsize (sections header's size in bytes) is big enough to fill at least one Elf_Shdr. Please note, I am not completely sure to have understand this part: calloc() is called with a dynamic element size (e_shentsize: readed for file), but the variable is declared as

Re: samba4 slow startup, shared libs?

2015-06-18 Thread Ian Mcwilliam
Sweet. I'll knockup a patch and send it upstream shortly. Ian McWilliam From: Jérémie Courrèges-Anglas [j...@wxcvbn.org] Sent: Thursday, 18 June 2015 8:11 PM To: Ian Mcwilliam Cc: Stuart Henderson; Mark Kettenis; tech@openbsd.org Subject: Re: samba4 slow

Re: [patch]rcs: merge typo

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 10:59:37PM +0200, Fritjof Bornebusch wrote: > What about this comma. > I saw a few manpages, having it at this location. > > Regards, > --F. > > > Index: merge.1 > === > RCS file: /cvs/src/usr.bin/rcs/merge.1

Re: [patch]rcs: rlog manpage typo

2015-06-18 Thread Fritjof Bornebusch
On Thu, Jun 18, 2015 at 09:57:13PM +0100, Jason McIntyre wrote: > On Thu, Jun 18, 2015 at 10:44:07PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > *logins is omitted* sounds a little strange, doesn't it? > > > > it does, because in your head you're thinking of logins as being the > plur

Re: [patch]rcs: ci manpage typo

2015-06-18 Thread Fritjof Bornebusch
On Thu, Jun 18, 2015 at 09:48:23PM +0100, Jason McIntyre wrote: > On Thu, Jun 18, 2015 at 10:33:53PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > isn't there a comma missing? > > > > depends how you like your commas. if i were writing it, i'd have the > comma. but many wouldn;t, and it

[patch]rcs: merge typo

2015-06-18 Thread Fritjof Bornebusch
What about this comma. I saw a few manpages, having it at this location. Regards, --F. Index: merge.1 === RCS file: /cvs/src/usr.bin/rcs/merge.1,v retrieving revision 1.3 diff -u -p -r1.3 merge.1 --- merge.1 28 Oct 2010 15:08:50

Re: [patch]rcs: rlog manpage typo

2015-06-18 Thread Fritjof Bornebusch
On Thu, Jun 18, 2015 at 10:49:32PM +0200, Pablo Méndez Hernández wrote: >Hi, > >El 18/6/2015 22:46, "Fritjof Bornebusch" escribiA^3: >> >> Hi tech@, >> >> *logins is omitted* sounds a little strange, doesn't it? > >"logins" as a keyword? > Yes, but if you read it, it

Re: [patch]rcs: rlog manpage typo

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 10:44:07PM +0200, Fritjof Bornebusch wrote: > Hi tech@, > > *logins is omitted* sounds a little strange, doesn't it? > it does, because in your head you're thinking of logins as being the plural of login (i.e. more than one login). but you can also - correctly - think of

Re: [patch]rcs: rlog manpage typo

2015-06-18 Thread Pablo Méndez Hernández
Hi, El 18/6/2015 22:46, "Fritjof Bornebusch" escribió: > > Hi tech@, > > *logins is omitted* sounds a little strange, doesn't it? "logins" as a keyword? Regards. Pablo > Regards, > --F. > > > Index: rlog.1 > === > RCS file: /cvs/s

Re: softraid checksumming discipline.

2015-06-18 Thread Karel Gardas
Joel, yes, I will work on your recommended RAID1 with checksumming of course. Just forgotten to add that. Thanks, Karel On Thu, Jun 18, 2015 at 10:40 PM, Karel Gardas wrote: > On Thu, Jun 18, 2015 at 6:32 PM, Joel Sing wrote: >> >> Re adding some form of checksumming, it only seems to make sense

Re: [patch]rcs: ci manpage typo

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 10:33:53PM +0200, Fritjof Bornebusch wrote: > Hi tech@, > > isn't there a comma missing? > depends how you like your commas. if i were writing it, i'd have the comma. but many wouldn;t, and it's certainly not wrong. the reason i like that last comma is demonstrated with

Re: softraid checksumming discipline.

2015-06-18 Thread Karel Gardas
On Thu, Jun 18, 2015 at 6:32 PM, Joel Sing wrote: > > Re adding some form of checksumming, it only seems to make sense in the case > of RAID 1 where you can decide that the data on a disk is invalid, then fail > the read and pull the data from another drive. That coupled with block > level "healin

[patch]rcs: rlog manpage typo

2015-06-18 Thread Fritjof Bornebusch
Hi tech@, *logins is omitted* sounds a little strange, doesn't it? Regards, --F. Index: rlog.1 === RCS file: /cvs/src/usr.bin/rcs/rlog.1,v retrieving revision 1.24 diff -u -p -r1.24 rlog.1 --- rlog.1 3 Sep 2010 11:09:29 -

[patch]rcs: ci manpage typo

2015-06-18 Thread Fritjof Bornebusch
Hi tech@, isn't there a comma missing? Regards, --F. Index: ci.1 === RCS file: /cvs/src/usr.bin/rcs/ci.1,v retrieving revision 1.38 diff -u -p -r1.38 ci.1 --- ci.112 Aug 2013 14:19:53 - 1.38 +++ ci.118 Jun

Re: [patch] dig(1), host(1), nslookup(1) manpages

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 02:50:48PM -0500, Dutch Ingraham wrote: > If an application (say, named) is removed from base, but still included > in ports, it it the policy to remove references to that application from > base applications' manpages? > generally, yes. but in this case i'm less sure...th

[patch] dig(1), host(1), nslookup(1) manpages

2015-06-18 Thread Dutch Ingraham
If an application (say, named) is removed from base, but still included in ports, it it the policy to remove references to that application from base applications' manpages? If yes, diff below. Index: dig.1 === RCS file: /cvs/src/usr.

Re: important audio simplifications to test and review

2015-06-18 Thread Christian Weisgerber
On 2015-06-13, Alexandre Ratchov wrote: > Many thanks to all who tested, below is an updated diff with the > missing i386 bits and "working" uaudio. I have run into a serious problem on sparc64 (but I haven't tested elsewhere). I've added -L- to the sndiod flags and I'm streaming audio from a r

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 01:22:31PM -0400, Daniel Dickman wrote: > > I think Theo's proposed change is correct. > > ok daniel@ > just to be clear, i'm not looking for oks for theo's patch. i am waiting to see what happens, and then i'll decide if we need to do anything to the docs. as i said, i

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Daniel Dickman
On Thu, Jun 18, 2015 at 10:18 AM, Jason McIntyre wrote: > On Thu, Jun 18, 2015 at 03:56:15PM +0200, Theo Buehler wrote: >> >> >From looking at the source code, I'm quite sure that the other BSD's >> behavior is the same as the current behavior in OpenBSD. >> >> I agree that the formulations in the

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Fred
On 06/18/15 15:18, Jason McIntyre wrote: On Thu, Jun 18, 2015 at 03:56:15PM +0200, Theo Buehler wrote: >From looking at the source code, I'm quite sure that the other BSD's behavior is the same as the current behavior in OpenBSD. I agree that the formulations in the manpages and POSIX aren't e

Re: [patch]diff: uninitialized values

2015-06-18 Thread Todd C. Miller
On Wed, 17 Jun 2015 20:53:57 +0200, Fritjof Bornebusch wrote: > *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. I don't think so. If dirp1 is non-NULL, so must edp1 be. Likewise for dirp2 and edp2. The compiler just doesn't know that scandir() does not modify its ou

Re: softraid checksumming discipline.

2015-06-18 Thread Joel Sing
On Wednesday 17 June 2015, Karel Gardas wrote: > Hello, > > I'm curious if anybody is working on implementing block-level > checksumming on softraid? Not that I'm aware of. > Backgroud: I'm comming from Solaris 11/ZFS world and I like ZFS's > focus on data integrity from drive level up to the RAM

iwm(4): make iwm_newstate() interrupt safe

2015-06-18 Thread Stefan Sperling
The net80211 stack assumes drivers will switch IEEE80211_S_* states in interrupt context. iwm(4) does not follow this rule. Since it insists on responses from firmware commands to look for success or failure and it uses tsleep() to wait for responses it cannot switch state in interrupt context. So

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 03:56:15PM +0200, Theo Buehler wrote: > > >From looking at the source code, I'm quite sure that the other BSD's > behavior is the same as the current behavior in OpenBSD. > > I agree that the formulations in the manpages and POSIX aren't explicit, > let alone unambiguous,

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Theo Buehler
On Thu, Jun 18, 2015 at 02:16:08PM +0100, Jason McIntyre wrote: > On Thu, Jun 18, 2015 at 12:33:58PM +0200, Theo Buehler wrote: > > Here's a silly ed(1) session: > > > > $ ed -p ":> " > > :> P > > P > > *q > > $ > > > > Notice how the prompt string changed from the custom prompt ":> " to > > the

using httpd to distribute signify keys

2015-06-18 Thread David Gwynne
this adds the current signify pub key for base to the httpd Server version header. as you say, the keys are small. this could help distribute it widely. here's an example of what it looks like: dlg@mild ~$ curl -I http://es45/ HTTP/1.1 200 OK Connection: keep-alive Content-Length: 2259 Content-

Re: ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 12:33:58PM +0200, Theo Buehler wrote: > Here's a silly ed(1) session: > > $ ed -p ":> " > :> P > P > *q > $ > > Notice how the prompt string changed from the custom prompt ":> " to > the default prompt "*". > > This behavior seems to contradict both the man page and POSIX

Re: openssl.1: two misspellings

2015-06-18 Thread Jason McIntyre
On Thu, Jun 18, 2015 at 12:25:13PM +0200, Theo Buehler wrote: > Index: usr.bin/openssl/openssl.1 > === > RCS file: /cvs/src/usr.bin/openssl/openssl.1,v > retrieving revision 1.13 > diff -u -p -r1.13 openssl.1 > --- usr.bin/openssl/open

ed(1): keep custom prompt string that was specified by -p

2015-06-18 Thread Theo Buehler
Here's a silly ed(1) session: $ ed -p ":> " :> P P *q $ Notice how the prompt string changed from the custom prompt ":> " to the default prompt "*". This behavior seems to contradict both the man page and POSIX: >From ed(1): -p string Specifies a command prompt. This may be toggled on an

openssl.1: two misspellings

2015-06-18 Thread Theo Buehler
Index: usr.bin/openssl/openssl.1 === RCS file: /cvs/src/usr.bin/openssl/openssl.1,v retrieving revision 1.13 diff -u -p -r1.13 openssl.1 --- usr.bin/openssl/openssl.1 28 Feb 2015 21:51:56 - 1.13 +++ usr.bin/openssl/openssl.1

Re: samba4 slow startup, shared libs?

2015-06-18 Thread Jérémie Courrèges-Anglas
Ian Mcwilliam writes: > Curiously from > > --- samba-4.0.3/wscript Tue Dec 4 21:07:44 2012 > +++ samba-4.0.26/wscript Mon Dec 8 18:46:38 2014 > > > -if sys.platform != "openbsd4": > +if not sys.platform.startswith("openbsd"): > conf.env.asneeded_ldflags = conf.ADD_LD