typo in OPENBSD-RELAYD-MIB.txt

2015-10-13 Thread Rob Pierce
Regards, Index: OPENBSD-RELAYD-MIB.txt === RCS file: /cvs/src/share/snmp/OPENBSD-RELAYD-MIB.txt,v retrieving revision 1.1 diff -u -p -r1.1 OPENBSD-RELAYD-MIB.txt --- OPENBSD-RELAYD-MIB.txt 19 Nov 2014 10:24:39 - 1.1 +++

a tale of software maintenance: OpenSSL and EVP_CHECK_DES_KEY

2015-10-13 Thread Philip Guenther
In case you need an OpenSSL anecdote to scare your co-workers with... Many of you may remember from your crypto class in college that DES has 16 'weak' keys that have group-like properties; check wikipedia for a longer explanation. These are not generally considered a problem: in any sane

Re: preparing pfi_kif to MP world

2015-10-13 Thread David Gwynne
> On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > wrote: > > Hello, > > patch below introduces struct refcnt to pfi_kif structure. Patch also changes > pfi_kif_get() function to always return a reference to pfi_kif instance. > > Furthermore existing

Re: patch for two nits around pf_insert_src_node() et. al.

2015-10-13 Thread Martin Pieuchot
On 12/10/15(Mon) 22:29, Alexandr Nedvedicky wrote: > Hello, > > Richard Procter came back to me in private email with one more nit to fix: > > we can get rid of > > if (sn->rule.ptr != NULL) > test condition in pfioctl() function as well. > > The relevant snippet looks as

Re: vattr_null() doesn't initialize va_filerev

2015-10-13 Thread Philip Guenther
On Thu, 8 Oct 2015, Martin Natano wrote: > Filesystem implementations depend on vattr_null() to initialize the > fields in struct vattr, which is true for all the fields except > va_filerev. It therefore is not set to VNOVAL as expected by the file > system, but contains whatever was there on

Re: patch for two nits around pf_insert_src_node() et. al.

2015-10-13 Thread Mike Belopuhov
On Mon, Oct 12, 2015 at 22:29 +0200, Alexandr Nedvedicky wrote: > Hello, > > Richard Procter came back to me in private email with one more nit to fix: > > we can get rid of > > if (sn->rule.ptr != NULL) > test condition in pfioctl() function as well. > > The relevant

Re: ifdef DIAGNOSTIC in azalia.c

2015-10-13 Thread Alexey Suslikov
Alexey Suslikov gmail.com> writes: > > Alexey Suslikov gmail.com> writes: > > > If there is a need to debug something in azalia.c, defining DIAGNOSTIC > > is overkill so replace two instances of DIAGNOSTIC with AZALIA_DEBUG > > (DPRINTF->printf suggested by ratchov ). > > > > Also, entirely

Re: preparing pfi_kif to MP world

2015-10-13 Thread Mike Belopuhov
On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: > > > On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > > wrote: > > > > Hello, > > > > patch below introduces struct refcnt to pfi_kif structure. Patch also > > changes > > pfi_kif_get() function to

Re: preparing pfi_kif to MP world

2015-10-13 Thread Alexandr Nedvedicky
Hello, > > > Furthermore existing functions pfi_kif_ref()/pfi_kif_unref() are thrown > > > away > > > in favor of pfi_kif_take()/pfi_kif_rele(), which follow naming convention > > > set by refcnt_init(9). Patch also removes kif reference types (enum > > > pfi_kif_refs). > > > > [snip] > > > @@

Re: preparing pfi_kif to MP world

2015-10-13 Thread Mike Belopuhov
On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: > > > On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky > > wrote: > > > > Hello, > > > > patch below introduces struct refcnt to pfi_kif structure. Patch also > > changes > > pfi_kif_get() function to

Re: FreeType-2.6.1 !!header files layout changed again!!

2015-10-13 Thread Christian Weisgerber
David Coppa: > New freetype version, new header file layout :( :( > [...] > Obviously, I'm expecting some fallouts from a bulk build with this... The only initial fallout from this is devel/xulrunner/24. However, without xulrunner ~750 further packages aren't built, so we need a fix for

Re: Char cleanup in lex(1)

2015-10-13 Thread Michael McConville
Theo de Raadt wrote: > > When scanning for is*() function uses with signed chars, I found that > > lex(1) uses an unecessary #define for unsigned char. The below diff > > removes it and fixes an undefined is*() usage or two as well. > > Our tree uses lex pretty much as-is from upstream, so this

Re: Char cleanup in lex(1)

2015-10-13 Thread Michael McConville
Michael McConville wrote: > Theo de Raadt wrote: > > > When scanning for is*() function uses with signed chars, I found that > > > lex(1) uses an unecessary #define for unsigned char. The below diff > > > removes it and fixes an undefined is*() usage or two as well. > > > > Our tree uses lex

lmw/stmw and corrupted frame on G5

2015-10-13 Thread Martin Pieuchot
On my G5s it is impossible to "c[ontinue]" execution after breaking into ddb(4). Doing so always result in a: panic: trap 9300 at 101000 (ddb_trap+0x40) lr 0x1b Note that 0x9300 == 0x8000 | 0x1300, so it seems that EXC_BPT that is set to enter ddb(8) has not been cleared (or better say the

Re: patch: native ed support

2015-10-13 Thread Tobias Stoeckmann
On Mon, Oct 12, 2015 at 12:01:49PM -0600, Todd C. Miller wrote: > I think this is the correct approach. I've only taken a brief look > so far but I think you should make write_lines() static in its > declaration to match the prototype. Thanks for pointing this out. Updated diff below: - Make

mg(1) dired sort

2015-10-13 Thread Mark Lumsden
This diff allows dired mode to sort directory contents alphabetically or by date order. It uses the same key as emacs: 's', though the extended command name is 'dired-sort'. Comments/ok? -lum Index: dired.c === RCS file:

Re: patch: native ed support

2015-10-13 Thread Tobias Stoeckmann
On Tue, Oct 13, 2015 at 06:43:31PM +0200, Tobias Stoeckmann wrote: > - Check for our new /.// substitution expression > - Be more restrictive about command parsing, so we do not > allow commands like "10insert" instead of "10i". And now, fix regression which I introduced with that diff, of

[patch] tcpdump segfault on malformed BGP AS_PATH update

2015-10-13 Thread Kevin Reay
Fix a segfault when printing a malformed BGP AS_PATH update due to ASN extraction. Better AS size extraction from AS paths: better heuristics (see bgp_attr_get_as_size). Also fixes output support for 4-byte ASNs. For example; (AS_PATH[T] {500.500 513.65211}) becomes: (AS_PATH[T] {500

Re: preparing pfi_kif to MP world

2015-10-13 Thread David Gwynne
> On 13 Oct 2015, at 21:12, Mike Belopuhov wrote: > > On Tue, Oct 13, 2015 at 20:36 +1000, David Gwynne wrote: >> >>> On 12 Oct 2015, at 12:00 AM, Alexandr Nedvedicky >>> wrote: >>> >>> Hello, >>> >>> patch below introduces struct refcnt

Add APM_IOC_HIBERNATE to apm.4

2015-10-13 Thread Martin Natano
The following patch adds documentation for the APM_IOC_HIBERNATE ioctl to the manual pages. cheers, natano Index: share/man/man4/man4.amd64/apm.4 === RCS file: /cvs/src/share/man/man4/man4.amd64/apm.4,v retrieving revision 1.5 diff