Re: pf_route pf_pdesc

2016-10-27 Thread Alexandr Nedvedicky
Hello, On Wed, Oct 26, 2016 at 11:48:34PM +0200, Alexander Bluhm wrote: > On Wed, Oct 19, 2016 at 11:49:56PM +0200, Alexander Bluhm wrote: > > I would like to pass a struct pf_pdesc to pf_route() like it is > > done in the other pf functions. That means less parameters, more > > consistency and

config(8): remove some disabled code

2016-10-27 Thread Theo Buehler
This code has been disabled since it was committed 20 years ago. While there, eliminate two instances of the same dead assignment. ok? Index: mkioconf.c === RCS file: /var/cvs/src/usr.sbin/config/mkioconf.c,v retrieving revision 1.3

Re: config(8): remove some disabled code

2016-10-27 Thread Martin Natano
On Thu, Oct 27, 2016 at 12:09:39PM +0200, Theo Buehler wrote: > This code has been disabled since it was committed 20 years ago. While > there, eliminate two instances of the same dead assignment. > > ok? Absolutely. > > Index: mkioconf.c >

config(8): remove OLDSCSIBUF

2016-10-27 Thread Theo Buehler
This conditional has been there since the beginning of history and apparently it's never been used or mentioned in our tree. ok? Index: ukcutil.c === RCS file: /var/cvs/src/usr.sbin/config/ukcutil.c,v retrieving revision 1.21 diff -u

Re: config(8): remove OLDSCSIBUF

2016-10-27 Thread Martin Natano
On Thu, Oct 27, 2016 at 12:24:29PM +0200, Theo Buehler wrote: > This conditional has been there since the beginning of history and > apparently it's never been used or mentioned in our tree. > > ok? OK > > Index: ukcutil.c > === >

locale(1) in printf(1)

2016-10-27 Thread Ingo Schwarze
Hi, this topic is quite tricky, so i'm sending this to a wider audience. The patch below improves printf(1) with respect to the locale(1) in three respects: 1. It fixes an outright documentation bug. According to both our implementation and the POSIX standard, %s with a precision limit

Re: snmpd(8): turn snmpd_env the only global

2016-10-27 Thread Jeremie Courreges-Anglas
Rafael Zalamena writes: > This diff removes all "extern struct snmpd *" lines from source files, > replaces all 'env' occurences with 'snmpd_env' and adds the extern > declaration for snmpd_env in the snmpd.h header. > > With this diff we only need to guarantee that this variable is set, > we avo