Re: pool cpu caches and a systat view of them

2017-06-14 Thread David Gwynne
> On 14 Jun 2017, at 10:14 pm, Todd C. Miller wrote: > > This looks useful to me. Do you plan to do anything with the fails > stats? i dont think theyre that interesting to look at, and i was running out of space for the things i thought were important in the systat view. on the other hand,

Re: Static linking without PIE

2017-06-14 Thread Ted Unangst
Charles Collicutt wrote: > On 14 June 2017 at 19:22, Ted Unangst wrote: > > > Charles Collicutt wrote: > > > That works, thank you. gcc-local(1) only mentions -nopie as an option for > > > the linker, so I thought it ought to be passed with -Wl,... > > > > I think I would interpret that sentence

install.sub: ieee80211_{scan,config}: Allow quoted SSIDs

2017-06-14 Thread Klemens Nanni
Instead of ignoring SSIDs containing whitespaces, slightly adjust the commands to take everything in between 'nwid ' and ' chan' as SSID; if it has double quotes at start *and* end, simply remove those. This enables users to select networks such as "Unitymedia WifiSpot" "FRITZ!Box 7490" for examp

Re: Static linking without PIE

2017-06-14 Thread Charles Collicutt
On 14 June 2017 at 19:22, Ted Unangst wrote: > Charles Collicutt wrote: > > That works, thank you. gcc-local(1) only mentions -nopie as an option for > > the linker, so I thought it ought to be passed with -Wl,... > > I think I would interpret that sentence to mean linker as in the gcc > invoked

tweak installer to use vnetid/parent for vlan config

2017-06-14 Thread David Gwynne
the installer uses the vlan/vlandev ifconfig params to configure vlan interfaces. this updates it to use vnetid and parent. there's some semantic tweaks in here too. firstly, instead of creating a vlan interface so it can be selected to configure, this adds the next vlan interface to the list of o

Re: Add support for rdonly keyword in fstab

2017-06-14 Thread Klemens Nanni
On Wed, Jun 14, 2017 at 07:54:48PM +0200, Jérôme FRGACIC wrote: I recently realized that the word "rdonly" is not an alias for "ro" in the fstab file, which is inconsistent with the mount(1) command. I would suggest to add support for it with this small patch. fstab(5) has always used ro/rw for

Add support for rdonly keyword in fstab

2017-06-14 Thread Jérôme FRGACIC
Hi @tech, I recently realized that the word "rdonly" is not an alias for "ro" in the fstab file, which is inconsistent with the mount(1) command. I would suggest to add support for it with this small patch. Index: fstab.c === RCS

Re: Static linking without PIE

2017-06-14 Thread Ted Unangst
Charles Collicutt wrote: > On 14 June 2017 at 17:34, Ted Unangst wrote: > > > gcc -static -nopie -o foo foo.c > > > > That works, thank you. gcc-local(1) only mentions -nopie as an option for > the linker, so I thought it ought to be passed with -Wl,... > > So passing -nopie to gcc both causes

Re: Static linking without PIE

2017-06-14 Thread Charles Collicutt
On 14 June 2017 at 17:34, Ted Unangst wrote: > gcc -static -nopie -o foo foo.c > That works, thank you. gcc-local(1) only mentions -nopie as an option for the linker, so I thought it ought to be passed with -Wl,... So passing -nopie to gcc both causes it to link against the correct crt0 and als

Re: Better handling of short reads

2017-06-14 Thread Ted Unangst
Mike Belopuhov wrote: > On Wed, Jun 14, 2017 at 11:43 -0400, Ted Unangst wrote: > > Mike Belopuhov wrote: > > > still looking forward to replies to the original set of changes. > > > > i'm a little in between. on the one hand, yes, ok, it's good that we don't > > leave corrupted buffers around wit

csh(1): close less file descriptors

2017-06-14 Thread Anton Lindqvist
Hi, While studying the behavior of csh using ktrace I did notice it trying to close every single fd up to _SC_OPEN_MAX except for the ones in use. This seems a bit excessive, here's a different approach: since the fds in use can vary one can't make assumptions about the largest fd in use. Instead o

Re: CPU_LIDSUSPEND in init(8) and reboot(8)

2017-06-14 Thread Mike Larkin
On Wed, Jun 14, 2017 at 07:45:42AM +0200, Martin Natano wrote: > ping? > I think I said ok a long time ago. -ml > > On Sun, May 21, 2017 at 09:46:45AM +0200, Martin Natano wrote: > > While switching init and reboot to CPU_LIDACTION, I forgot about the > > #ifdef's. Ok? > > > > natano > > > >

Re: fix iwm ioctl races ('could not initiate scan', 'device timeout')

2017-06-14 Thread Stefan Sperling
On Thu, Jan 05, 2017 at 03:35:15PM -0500, Ted Unangst wrote: > Stefan Sperling wrote: > > The problem seems to be that iwm's various tasks will sleep while waiting > > for a device command to finish. If an ioctl process now sneaks in it will > > trigger new commands to be sent in parallel, which th

Re: Static linking without PIE

2017-06-14 Thread Ted Unangst
Charles Collicutt wrote: > Hi, > > Is the following expected behaviour? > > $ gcc -static -Wl,-nopie -Wl,-v -o foo foo.c gcc -static -nopie -o foo foo.c

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 11:43 -0400, Ted Unangst wrote: > Mike Belopuhov wrote: > > still looking forward to replies to the original set of changes. > > i'm a little in between. on the one hand, yes, ok, it's good that we don't > leave corrupted buffers around with bad data. on the other hand, don

Static linking without PIE

2017-06-14 Thread Charles Collicutt
Hi, Is the following expected behaviour? $ gcc -static -Wl,-nopie -Wl,-v -o foo foo.c collect2 version 4.2.1 20070719 (OpenBSD/x86-64 ELF) /usr/bin/ld -e __start -Bstatic -dynamic-linker /usr/libexec/ld.so -o foo /usr/lib/rcrt0.o /usr/lib/crtbegin.o -L/usr/lib/gcc-lib/amd64-unknown-openbsd6.1/4

Re: Better handling of short reads

2017-06-14 Thread Ted Unangst
Mike Belopuhov wrote: > still looking forward to replies to the original set of changes. i'm a little in between. on the one hand, yes, ok, it's good that we don't leave corrupted buffers around with bad data. on the other hand, don't we want to learn about these problems and fix them? i don't thi

install.sub: Clean v[46]_info() ouput

2017-06-14 Thread Klemens Nanni
With this patch, v[46]_info() both output exactly what their description says. As of now, these functions are only used through set -- $(v4_info $_if) which gracefully handles any constellation of whitespaces in the output just fine. However future usage might change (or not) and being pr

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 09:12 -0600, Bob Beck wrote: > > > As you all might have gathered by now Amit has jumped the gun > > but was wrong to do so. His setup is not affected by this change. > > That was expected so please don't get distracted by this as I'm > > still looking forward to replies t

Re: Better handling of short reads

2017-06-14 Thread Bob Beck
> As you all might have gathered by now Amit has jumped the gun > but was wrong to do so. His setup is not affected by this change. > That was expected so please don't get distracted by this as I'm > still looking forward to replies to the original set of changes. > beck@? > > > diff --git sys/k

Re: Better handling of short reads

2017-06-14 Thread Bob Beck
- ok mike, I'm looking at it.. Allow me a short while to beat my head against a wall for a bit to get it into readahead mode... On Wed, Jun 14, 2017 at 3:56 AM, Mike Belopuhov wrote: > On Thu, Jun 08, 2017 at 11:55 +0200, Mike Belopuhov wrote: > > On Wed, Jun 07, 2017 at 23:04 -0500, Amit Ku

Re: Better handling of short reads

2017-06-14 Thread Amit Kulkarni
On Wed, Jun 14, 2017 at 4:56 AM, Mike Belopuhov wrote: > On Thu, Jun 08, 2017 at 11:55 +0200, Mike Belopuhov wrote: >> On Wed, Jun 07, 2017 at 23:04 -0500, Amit Kulkarni wrote: >> > On Wed, 7 Jun 2017 21:27:27 -0500 >> > Amit Kulkarni wrote: >> > >> > > On Thu, 8 Jun 2017 01:57:25 +0200 >> > > Mi

Re: m4(1): add -e flag support

2017-06-14 Thread Brian Callahan
On 6/14/2017 10:18 AM, marc espie wrote: > on wed, jun 14, 2017 at 09:58:54am -0400, brian callahan wrote: >> hi marc -- >> >> how's this version? >> also includes a slight tweak to the single -e flag regress test. >> >> ~brian > comment nit, otherwise good. > >> +extern int error_warns;

Re: m4(1): add -e flag support

2017-06-14 Thread marc espie
on wed, jun 14, 2017 at 09:58:54am -0400, brian callahan wrote: > hi marc -- > > how's this version? > also includes a slight tweak to the single -e flag regress test. > > ~brian comment nit, otherwise good. > +extern int error_warns; /* make warnings cause exit_code > 0 */ exit_cod

Re: m4(1): add -E flag support

2017-06-14 Thread Brian Callahan
Hi Marc -- How's this version? Also includes a slight tweak to the single -E flag regress test. ~Brian Index: usr.bin/m4/eval.c === RCS file: /cvs/src/usr.bin/m4/eval.c,v retrieving revision 1.74 diff -u -p -u -p -r1.74 eval.c --- u

Re: pool cpu caches and a systat view of them

2017-06-14 Thread Todd C. Miller
This looks useful to me. Do you plan to do anything with the fails stats? - todd

Re: tweak txp to avoid ifq_deq_begin/commit/rollback

2017-06-14 Thread Mike Belopuhov
On Mon, Jun 05, 2017 at 16:13 +0200, Mike Belopuhov wrote: > On Wed, May 31, 2017 at 20:40 +0200, Mike Belopuhov wrote: > > According to the FreeBSD driver, txp(4) is not setting up its TX > > ring correctly. FreeBSD driver uses up to 16 fragments, while we > > use up to 252 which is suspicious. >

Re: Better handling of short reads

2017-06-14 Thread Mike Belopuhov
On Thu, Jun 08, 2017 at 11:55 +0200, Mike Belopuhov wrote: > On Wed, Jun 07, 2017 at 23:04 -0500, Amit Kulkarni wrote: > > On Wed, 7 Jun 2017 21:27:27 -0500 > > Amit Kulkarni wrote: > > > > > On Thu, 8 Jun 2017 01:57:25 +0200 > > > Mike Belopuhov wrote: > > > > > > > On Wed, Jun 07, 2017 at 18:

Re: Copying a file on msdos FS (fat32) changes content

2017-06-14 Thread Stefan Fritsch
On Tue, 13 Jun 2017, Martijn Rijkeboer wrote: > Yes, this patch fixes the problem. Thanks for the report and the testing. I have committed the revert yesterday.

Re: m4(1): add -E flag support

2017-06-14 Thread Marc Espie
On Tue, Jun 13, 2017 at 05:05:56PM -0400, Brian Callahan wrote: > Hi -- > > Whoops, that was unintentional. Fixed. > > ~Brian Sorry for not looking sooner. I would rather you use two variables for -E flags. e.g., set error_warns for one -E flag, and fatal_warns for multiple -E flags. That way

Re: pool cpu caches and a systat view of them

2017-06-14 Thread Mike Belopuhov
On Wed, Jun 14, 2017 at 13:50 +1000, David Gwynne wrote: > i have a few things left to do in the pools per cpu caches, one of > which is make their activity visibile. to that end, here's a diff > provides a way for userland to request stats from the per cpu caches, > and uses that in systat so you

mailwrapper(8): remove main() prototype

2017-06-14 Thread Anton Lindqvist
Hi, The prototype for main() is inherited from the import of mailwrapper back in 1999. While at it, my understanding is that the envp argument can also be removed since the environ is unaltered. This however requires changing the calls from execve() to execv(). Where execv() is appropriate since ev