> It agree that it my not seem reasonable enough (to you), but there is a
> technical point to it.
Well, maybe you'll get to it eventually.
On Sat, Jul 01, 2017 at 11:17:55PM -0600, Theo de Raadt wrote:
On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote:
>Don't understand your point. What is this fixing?
Nothing gets "fixed", it just avoids unnecessary forking and makes clear
that the inner commands do not require a subsh
> On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote:
> >Don't understand your point. What is this fixing?
> Nothing gets "fixed", it just avoids unnecessary forking and makes clear
> that the inner commands do not require a subshell - there are no side
> effects on the environment so a
On Sat, Jul 01, 2017 at 10:13:45PM -0700, Philip Guenther wrote:
I've lost track of how many times at work and in OpenBSD I've tested a
diff, made a final modification and then committed...a change broken
by that final modification. Once you've tested a diff, either don't
make a "this is easy!"
On Sat, Jul 1, 2017 at 9:47 PM, Klemens Nanni wrote:
> On Sat, Jul 01, 2017 at 09:35:09PM -0700, Philip Guenther wrote:
>>
>> On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote:
>>>
>>> A simple command list suffices as this is just about redirecting all
>>> output at once.
>>>
>>> Feedback/OK?
On Sat, Jul 01, 2017 at 11:01:00PM -0600, Theo de Raadt wrote:
Don't understand your point. What is this fixing?
Nothing gets "fixed", it just avoids unnecessary forking and makes clear
that the inner commands do not require a subshell - there are no side
effects on the environment so a command
On Sat, Jul 01, 2017 at 08:48:18PM -0400, Bryan Steele wrote:
> On Sat, Jul 01, 2017 at 06:53:29PM -0400, Bryan Steele wrote:
> > On Sun, Jul 02, 2017 at 12:26:19AM +0200, Ingo Schwarze wrote:
> > > I don't see a need for two char * variables here, that's an artifact
> > > of the typical fgetln(3)
Don't understand your point. What is this fixing?
> A simple command list suffices as this is just about redirecting all
> output at once.
>
> Feedback/OK?
>
> Index: install.sub
> ===
> RCS file: /cvs/src/distrib/miniroot/install.
On Sat, Jul 01, 2017 at 09:35:09PM -0700, Philip Guenther wrote:
On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote:
A simple command list suffices as this is just about redirecting all
output at once.
Feedback/OK?
...
+ {dmesg; cat $CGI_INFO /*.conf; sysctl; route -n show; df;
This
On Sat, Jul 1, 2017 at 9:27 PM, Klemens Nanni wrote:
> A simple command list suffices as this is just about redirecting all
> output at once.
>
> Feedback/OK?
...
> + {dmesg; cat $CGI_INFO /*.conf; sysctl; route -n show; df;
This code has not been tested (and does not work).
Philip Guenth
Remove unused variable from header file.
Index: ifstated.h
===
RCS file: /cvs/src/usr.sbin/ifstated/ifstated.h,v
retrieving revision 1.12
diff -u -p -r1.12 ifstated.h
--- ifstated.h 28 Jun 2017 11:10:08 - 1.12
+++ ifstated.h
A simple command list suffices as this is just about redirecting all
output at once.
Feedback/OK?
Index: install.sub
===
RCS file: /cvs/src/distrib/miniroot/install.sub,v
retrieving revision 1.1016
diff -u -p -r1.1016 install.sub
--
Remove variable assignment in declaration and add whitespace to improve
readability. No functional change.
Rob
Index: ifstated.c
===
RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v
retrieving revision 1.45
diff -u -p -r1.45 ifstate
No functional change or bugfix but queue(3) is the for a reason. That
way the code even is a tad clearer to me (and two lines shorter).
Feedback/OK?
Index: tee.c
===
RCS file: /cvs/src/usr.bin/tee/tee.c,v
retrieving revision 1.11
di
On Sat, Jul 01, 2017 at 06:53:29PM -0400, Bryan Steele wrote:
> On Sun, Jul 02, 2017 at 12:26:19AM +0200, Ingo Schwarze wrote:
> > I don't see a need for two char * variables here, that's an artifact
> > of the typical fgetln(3) complications. Just
> >
> > char*line = NULL;
> > size_t
On Sun, Jul 02, 2017 at 01:09:19AM +0100, Ricardo Mestre wrote:
You're blindly replacing strtoul with strtonum without taking the base 0
into account.
I'd recommend you take a look at strtoul's manpage first and check what
using base 0 means (strtonum always use base 10).
Don't worry, I can rea
Hi,
so i was bored, and decided to see, if i could revive an old diff of mine,
which does separate bus_dma.h out of arm/include/bus.h, and mostly
inlines the rest in armv7/include/bus.h (credit for the idea of inlining
bus space goes to miod@).
the diff below might not be absolutely complete, i b
Ricardo Mestre wrote:
> Of course the diff still may make sense if working with different bases,
> apart from 10, is not required anymore.
i had a glance through and didn't see any that made sense to keep support for
octal or hex. was hoping a more serious brconfig user would also take a look
at t
Of course the diff still may make sense if working with different bases,
apart from 10, is not required anymore.
On 01:09 Sun 02 Jul , Ricardo Mestre wrote:
> Hi Klemens,
>
> You're blindly replacing strtoul with strtonum without taking the base 0
> into account.
>
> I'd recommend you take a
Hi Klemens,
You're blindly replacing strtoul with strtonum without taking the base 0
into account.
I'd recommend you take a look at strtoul's manpage first and check what
using base 0 means (strtonum always use base 10).
Best regards,
mestre
On Fri, Jun 09, 2017 at 08:33:16PM +0200, Klemens Nanni wrote:
No need for temporary variables either, strtonum guarantees through
maxval that its return value won't overflow when casted.
Index: brconfig.c
===
RCS file: /cvs/src/sbi
On Sun, Jul 02, 2017 at 12:26:19AM +0200, Ingo Schwarze wrote:
> I don't see a need for two char * variables here, that's an artifact
> of the typical fgetln(3) complications. Just
>
> char*line = NULL;
> size_t linesize = 0;
> ssize_t slen;
>
> while ((slen = getl
Hi,
Nicholas Marriott wrote on Sat, Jul 01, 2017 at 09:48:08PM +0100:
> Safer how?
1. fgetln(3) returns a char array that is not NUL-terminated.
That is prone to buffer overrun bugs in general.
getline(3) always returns proper NUL-terminated C strings.
2. The array returned from fget
never.never say always.always.
Rename one of the "always" variables to "body" for improved readability.
No functional change.
>From ifstated.conf(5):
"Each state consistes of an init block and a body. The init block is used
to initialize the state and is executed each time the state is entered.
Right but we are already taking that into account, that is not a problem
here. Anyway, change it if you like, it is shorter anyway.
On Sat, Jul 01, 2017 at 05:03:41PM -0400, Bryan Steele wrote:
> On Sat, Jul 01, 2017 at 09:48:08PM +0100, Nicholas Marriott wrote:
> > Safer how?
>
> I believe that
On Sat, Jul 01, 2017 at 09:48:08PM +0100, Nicholas Marriott wrote:
> Safer how?
I believe that's in reference to the CAVEATS mentioned in fgetln(3).
http://man.openbsd.org/fgetln.3#CAVEATS
getline(3) returns C strings.
> I don't mind too much, but you will also need to initialize size to 0
> (i
Safer how?
I don't mind too much, but you will also need to initialize size to 0
(it is currently uninitialized) before calling getline().
On Sat, Jul 01, 2017 at 04:35:39PM -0400, Bryan Steele wrote:
> On Sat, Jul 01, 2017 at 09:27:47PM +0100, Nicholas Marriott wrote:
> >
> > What is the po
I'm not sure I see much point in this but do it if you like. It will
potentially close STDIN_FILENO though, I think that is harmless at the
moment - or perhaps prepare_input should dup() it.
On Sat, Jul 01, 2017 at 03:26:27PM -0400, Bryan Steele wrote:
> I think I lost this part in my larger dif
On Sat, Jul 01, 2017 at 09:27:47PM +0100, Nicholas Marriott wrote:
>
> What is the point of doing this? fgetln works fine.
>
There's been other examples of commits replacing fgetln for getline,
while portability isn't a major concern, it's been suggested that
getline may be safer.
http://marc.i
What is the point of doing this? fgetln works fine.
On Sat, Jul 01, 2017 at 02:47:25PM -0400, Bryan Steele wrote:
> Seems to work, does this look right?
>
> -Bryan.
>
> Index: magic-load.c
> ===
> RCS file: /cvs/src/usr.bin/file
I think I lost this part in my larger diff, make sure fds are closed
after testing files.
-Bryan.
Index: file.c
===
RCS file: /cvs/src/usr.bin/file/file.c,v
retrieving revision 1.63
diff -u -p -u -r1.63 file.c
--- file.c 28 Jun
I haven't been paying attention to mail on these LDOMs. Thanks for the
heads up. Output looks good.
>From r...@puffyfive.ldom.openbsd.local Sat Jul 1 14:07:05 2017
Delivered-To: r...@puffyfive.ldom.openbsd.local
From: Charlie Root
To: r...@puffyfive.ldom.openbsd.local
Subject: puffyfive.ldom.ope
> I've put the snapshot LDOM through some paces with each snapshot: high CPU
> load, networking, and heavy filesystem utilization. It's every bit as solid
> as the other LDOMs. I have only seen the "relinking" message at the end of
> snapshot upgrades, but due to /bsd changing upon each reboot, I b
Sebastian Benoit(be...@openbsd.org) on 2017.07.01 20:40:17 +0200:
> Sebastian Benoit(be...@openbsd.org) on 2017.07.01 16:44:14 +0200:
> > This makes netstat show only listening sockets for tcp sockets
> > when invoked as netstat -l.
> >
> > With it "netstat -l -finet -p tcp" is equivalent to
> > "
sparc64 snapshots, run inside an LDOM. Primary domain and the other 6 LDOMs
are 6.1-STABLE.
I've put the snapshot LDOM through some paces with each snapshot: high CPU
load, networking, and heavy filesystem utilization. It's every bit as solid
as the other LDOMs. I have only seen the "relinking" me
Seems to work, does this look right?
-Bryan.
Index: magic-load.c
===
RCS file: /cvs/src/usr.bin/file/magic-load.c,v
retrieving revision 1.25
diff -u -p -r1.25 magic-load.c
--- magic-load.c1 Jul 2017 14:34:29 - 1.25
Sebastian Benoit(be...@openbsd.org) on 2017.07.01 16:44:14 +0200:
> This makes netstat show only listening sockets for tcp sockets
> when invoked as netstat -l.
>
> With it "netstat -l -finet -p tcp" is equivalent to
> "netstat -a -finet | grep LISTEN"
>
> I (re)used -l because Linux has the same
This follows on the footsteps of guenther@, who did a similar job in the
kernel.
Basically, the old-style "make depend, then make all" bsd makefile pattern
is GONE.
More accurately, dependencies are now generated on the fly using gcc and
clang's -M* options.
Instead of a "magical" .depend file,
This makes netstat show only listening sockets for tcp sockets
when invoked as netstat -l.
With it "netstat -l -finet -p tcp" is equivalent to
"netstat -a -finet | grep LISTEN"
I (re)used -l because Linux has the same option.
FreeBSD does not have -l, but it does not error out when invoked with
ok nicm, it should not fclose this because it didn't open it
On Sat, Jul 01, 2017 at 10:19:32AM -0400, Bryan Steele wrote:
> magic_load() is only called in main and fcloses magicfp immediately,
> this removes a redundant fclose.
>
> Index: magic-load.c
> =
magic_load() is only called in main and fcloses magicfp immediately,
this removes a redundant fclose.
Index: magic-load.c
===
RCS file: /cvs/src/usr.bin/file/magic-load.c,v
retrieving revision 1.24
diff -u -p -u -r1.24 magic-load.c
--
On Tue, 27 Jun 2017 09:29:10 +, Otto Moerbeek wrote:
>
> at last a followup, for the original problem.
>
> This diff incorporates your later comment. It does not cause the newly
> added regress test to fail, though.
>
> So that poses the question if this is what you meant.
>
> -Ott
Almost certainly the last version.
A less used architecture met with a snag, because libsa/Makefile.inc
uses depend:: which got make to barf out as target: and target:: don't
mesh.
Apart from that, I've got tb@'s okay, and krw@ seemed happy as well...
further comments should happen about now,
Hi,
just in case i didn't make it clear what it is for, here's diff "fixing"
current uses below, compile-tested.
-Artturi
diff --git a/sys/arch/arm/arm/cpufunc.c b/sys/arch/arm/arm/cpufunc.c
index c91108e7066..fcb56627af7 100644
--- a/sys/arch/arm/arm/cpufunc.c
+++ b/sys/arch/arm/arm/cpufunc.c
44 matches
Mail list logo