fine tuning PF_LOCK in pfioctl()

2017-10-27 Thread Alexandr Nedvedicky
Hello, patch below fine tunes PF_LOCK in pfioctl() function. Currently pfioctl() function grabs PF_LOCK() for all operations at line 1006, right before 'the big switch' is entered. The PF_LOCK() gets released once we are done with 'the big switch' at line 2477: 905 int 906 pfioctl(dev_t

[PATCH] Fix out-of-bounds read in libc/regex

2017-10-27 Thread Vlad Tsyrklevich
This is a patch for a bug found by oss-fuzz [1] through the copy of libc/regex in LLVM and fixed downstream [2]. The bug is an out-of-bounds read detected with address sanitizer that happens when 'sp' in p_b_coll_elems() includes NUL byte[s], e.g. if it's equal to "GS\x00". In that case len will

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Mark Kettenis
> Date: Fri, 27 Oct 2017 20:08:43 +0200 > From: Stefan Sperling > > On Fri, Oct 27, 2017 at 04:47:20PM +0200, Mark Kettenis wrote: > > I don't know, but with the ioctl removed, there is nothing that sets > > the IEEE80211_F_QOS flag anymore. That seems weird. > > This flag is

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Stefan Sperling
On Fri, Oct 27, 2017 at 04:47:20PM +0200, Mark Kettenis wrote: > I don't know, but with the ioctl removed, there is nothing that sets > the IEEE80211_F_QOS flag anymore. That seems weird. This flag is just unused for now. It is a left-over from unfinished 11n support code by damien. But I expect

Re: [PATCH 1/2] VMD: Require interface to be defined in switches

2017-10-27 Thread Mike Larkin
On Fri, Oct 27, 2017 at 09:58:09AM +0200, Martin Pieuchot wrote: > On 26/10/17(Thu) 23:47, Mike Larkin wrote: > > On Fri, Oct 27, 2017 at 08:23:05AM +0200, Martin Pieuchot wrote: > > > On 26/10/17(Thu) 16:23, Carlos Cardenas wrote: > > > > * Require interface name to be defined for switches in

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Mark Kettenis
> Date: Fri, 27 Oct 2017 23:57:35 +1100 > From: Jonathan Gray > > On Fri, Oct 27, 2017 at 02:34:32PM +0200, Mark Kettenis wrote: > > > Date: Fri, 27 Oct 2017 12:33:15 +0200 > > > From: Stefan Sperling > > > > > > On Fri, Oct 27, 2017 at 09:08:07PM +1100,

Re: rm exits 0

2017-10-27 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Fri, Oct 27, 2017 at 11:51:25AM +0100: > On Fri, Oct 27, 2017 at 11:42:30AM +0200, Jan Stary wrote: >> "rm exits 0" does not seem right (though I'm not a native speaker). > well it is clear, so i don;t see a problem. virtually every man page > with an EXIT STATUS

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Jonathan Gray
On Fri, Oct 27, 2017 at 02:34:32PM +0200, Mark Kettenis wrote: > > Date: Fri, 27 Oct 2017 12:33:15 +0200 > > From: Stefan Sperling > > > > On Fri, Oct 27, 2017 at 09:08:07PM +1100, Jonathan Gray wrote: > > > use in ifconfig was removed in 2009 > > > > Yes, please remove this.

Re: tftpd(8): diff for ip path rewrite

2017-10-27 Thread Jan Klemkow
On Wed, Oct 25, 2017 at 04:54:01PM +, Jeremie Courreges-Anglas wrote: > On Tue, Oct 24 2017, Jeremie Courreges-Anglas wrote: > > On Mon, Oct 23 2017, Jan Klemkow wrote: > >> On Sun, Oct 22, 2017 at 09:32:54PM +, Jeremie Courreges-Anglas wrote: > >>>

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Mark Kettenis
> Date: Fri, 27 Oct 2017 12:33:15 +0200 > From: Stefan Sperling > > On Fri, Oct 27, 2017 at 09:08:07PM +1100, Jonathan Gray wrote: > > use in ifconfig was removed in 2009 > > Yes, please remove this. Thanks. How would one go about setting QoS mode without this ioctl? > >

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Kevin Lo
On Fri, Oct 27, 2017 at 09:08:07PM +1100, Jonathan Gray wrote: > > use in ifconfig was removed in 2009 sure, ok kevlo@ > Index: ieee80211_ioctl.c > === > RCS file: /cvs/src/sys/net80211/ieee80211_ioctl.c,v > retrieving revision

Re: urndis printf cleanup

2017-10-27 Thread Jeremie Courreges-Anglas
On Fri, Oct 27 2017, Mikhail wrote: > On Fri, Oct 27, 2017 at 1:19 PM, Jeremie Courreges-Anglas > wrote: >> On Fri, Oct 27 2017, Mikhail wrote: >>> add missed DEVNAME's and \n's >> >> They are not missing. The point is to have _attach()

Re: rm exits 0

2017-10-27 Thread Jason McIntyre
On Fri, Oct 27, 2017 at 11:42:30AM +0200, Jan Stary wrote: > "rm exits 0" does not seem right (though I'm not a native speaker). > > Jan > > Index: rm.1 > === > RCS file: /cvs/src/bin/rm/rm.1,v > retrieving revision 1.42 >

Re: elf_abi.h -> elf.h

2017-10-27 Thread Jeremie Courreges-Anglas
On Fri, Oct 27 2017, Martin Pieuchot wrote: > I'd like to get rid of which is not portable at all. > > is at least present on Solaris, FreeBSD and OSX. > > ok? ok -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: urndis printf cleanup

2017-10-27 Thread Mikhail
On Fri, Oct 27, 2017 at 1:19 PM, Jeremie Courreges-Anglas wrote: > On Fri, Oct 27 2017, Mikhail wrote: >> add missed DEVNAME's and \n's > > They are not missing. The point is to have _attach() print a single > line in dmesg. > > PS: your diff would not apply

Re: remove 80211WMMPARMS ioctls

2017-10-27 Thread Stefan Sperling
On Fri, Oct 27, 2017 at 09:08:07PM +1100, Jonathan Gray wrote: > use in ifconfig was removed in 2009 Yes, please remove this. Thanks. > Index: ieee80211_ioctl.c > === > RCS file: /cvs/src/sys/net80211/ieee80211_ioctl.c,v >

Re: urndis printf cleanup

2017-10-27 Thread Jeremie Courreges-Anglas
On Fri, Oct 27 2017, Mikhail wrote: > add missed DEVNAME's and \n's They are not missing. The point is to have _attach() print a single line in dmesg. PS: your diff would not apply (mangled whitespace) > Index: dev/usb/if_urndis.c >

remove 80211WMMPARMS ioctls

2017-10-27 Thread Jonathan Gray
use in ifconfig was removed in 2009 Index: ieee80211_ioctl.c === RCS file: /cvs/src/sys/net80211/ieee80211_ioctl.c,v retrieving revision 1.54 diff -u -p -r1.54 ieee80211_ioctl.c --- ieee80211_ioctl.c 26 Oct 2017 15:00:28 -

rm exits 0

2017-10-27 Thread Jan Stary
"rm exits 0" does not seem right (though I'm not a native speaker). Jan Index: rm.1 === RCS file: /cvs/src/bin/rm/rm.1,v retrieving revision 1.42 diff -u -p -r1.42 rm.1 --- rm.128 Jun 2017 06:24:39 - 1.42

urndis printf cleanup

2017-10-27 Thread Mikhail
add missed DEVNAME's and \n's Index: dev/usb/if_urndis.c === RCS file: /home/misha/work/cvs/src/sys/dev/usb/if_urndis.c,v retrieving revision 1.67 diff -u -p -r1.67 if_urndis.c --- dev/usb/if_urndis.c 19 Jul 2017 16:31:56 - 1.67

elf_abi.h -> elf.h

2017-10-27 Thread Martin Pieuchot
I'd like to get rid of which is not portable at all. is at least present on Solaris, FreeBSD and OSX. ok? Index: games/hangman/ksyms.c === RCS file: /cvs/src/games/hangman/ksyms.c,v retrieving revision 1.10 diff -u -p -r1.10

Re: [patch] make ifconfig report 'SIOCSIFMEDIA' when ioctl fails

2017-10-27 Thread Martin Pieuchot
On 26/10/17(Thu) 23:41, Jesper Wallin wrote: > Hi all, > > First off, as always, I apologize if I'm wasting anyone's time because > I'm missing something obvious here. > > So, I accidentally ran "ifconfig iwm0 mode 11g" as a regular user and > noticed it didn't throw an error. A quick look at

Re: [PATCH 1/2] VMD: Require interface to be defined in switches

2017-10-27 Thread Martin Pieuchot
On 26/10/17(Thu) 23:47, Mike Larkin wrote: > On Fri, Oct 27, 2017 at 08:23:05AM +0200, Martin Pieuchot wrote: > > On 26/10/17(Thu) 16:23, Carlos Cardenas wrote: > > > * Require interface name to be defined for switches in vm.conf > > > ** Requires user to create bridge(4) beforehand > > > * Remove

Re: [PATCH 1/2] VMD: Require interface to be defined in switches

2017-10-27 Thread Mike Larkin
On Fri, Oct 27, 2017 at 08:23:05AM +0200, Martin Pieuchot wrote: > On 26/10/17(Thu) 16:23, Carlos Cardenas wrote: > > * Require interface name to be defined for switches in vm.conf > > ** Requires user to create bridge(4) beforehand > > * Remove code to create bridges on the fly > > * Add code to

Re: [PATCH 1/2] VMD: Require interface to be defined in switches

2017-10-27 Thread Martin Pieuchot
On 26/10/17(Thu) 16:23, Carlos Cardenas wrote: > * Require interface name to be defined for switches in vm.conf > ** Requires user to create bridge(4) beforehand > * Remove code to create bridges on the fly > * Add code to ensure bridge really exists > * Update manpage switch and example sections