Re: VMD: revise check for regular files on disks

2018-01-03 Thread Mike Larkin
On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote: > Howdy. > > Attached is a patch to address a TOCTOU issue with checking to > ensure disks are regular files, reported by jca@ . > > Comments? Ok? > > +--+ > Carlos > Index: config.c > =

Re: drm: fix debug build

2018-01-03 Thread Jonathan Gray
On Thu, Dec 21, 2017 at 04:11:44PM +0200, Paul Irofti wrote: > On Thu, Dec 21, 2017 at 02:25:41PM +0100, Mark Kettenis wrote: > > > Date: Thu, 21 Dec 2017 13:01:31 +0200 > > > From: Paul Irofti > > > > > > If no one objects, I will commit this tomorrow. > > > > Fix is wrong since it will break w

Re: yacc print_grammar(): loop -> fprintf()

2018-01-03 Thread Anders Andersson
On Wed, Jan 3, 2018 at 1:58 PM, Michael W. Bombardieri wrote: > Hello, > > In yacc the function print_grammar() writes the file y.output if > the -v option is used. fprintf() can be used directly for writing > "spacing" space characters of indentation so a loop can be removed. > > - Michael > > >

VMD: revise check for regular files on disks

2018-01-03 Thread Carlos Cardenas
Howdy. Attached is a patch to address a TOCTOU issue with checking to ensure disks are regular files, reported by jca@ . Comments? Ok? +--+ Carlos Index: config.c === RCS file: /home/los/cvs/src/usr.sbin/vmd/config.c,v retrieving re

jot(1): remove arbitrary length limits

2018-01-03 Thread kshe
Hi, Currently, jot(1) restricts arguments given to the `-s', `-b' and `-w' options to BUFSIZ characters; this is a typical misuse of that constant, which has essentially nothing to do with the expected maximum size of argv's elements. Besides, I have actually hit this limit multiple times recentl

Re: use inline functions instead of __statement

2018-01-03 Thread Philip Guenther
On Wed, Jan 3, 2018 at 3:59 PM, Damien Miller wrote: > On Thu, 4 Jan 2018, David Gwynne wrote: > > > my theory is that __statement (a gcc extension) was used to allow > > macros to evaluate their argument(s) once by assigning it to a local > > variable, and then returning a value. this is difficu

Re: use inline functions instead of __statement

2018-01-03 Thread Damien Miller
On Thu, 4 Jan 2018, David Gwynne wrote: > my theory is that __statement (a gcc extension) was used to allow > macros to evaluate their argument(s) once by assigning it to a local > variable, and then returning a value. this is difficult with normal > macros. Not understanding - doesn't this: > -

use inline functions instead of __statement

2018-01-03 Thread David Gwynne
my theory is that __statement (a gcc extension) was used to allow macros to evaluate their argument(s) once by assigning it to a local variable, and then returning a value. this is difficult with normal macros. these days you can use inline functions to get the same effect, but it is a more obviou

Re: Intel CPU Security Flaw Kernel Memory Leak (no microcode update) SW workarounds only

2018-01-03 Thread Lampshade
https://security.googleblog.com/2018/01/todays-cpu-vulnerability-what-you-need.html https://googleprojectzero.blogspot.com/2018/01/reading-privileged-memory-with-side.html or shortened URLs: goo.gl/ndYk6H goo.gl/kTfwfn Od: "Tom Smyth" Do: tech@openbsd.org; Temat: Intel CPU Security Flaw Kernel

Re: ASMedia ASM1061 SATA support for ahci(4)

2018-01-03 Thread Mark Kettenis
> Date: Wed, 3 Jan 2018 10:31:14 +1000 > From: Jonathan Matthew > > On Tue, Jan 02, 2018 at 11:25:55PM +0100, Mark Kettenis wrote: > > This cip advertises itself as a PCI IDE controller, but actually > > implements an AHCI interface. Adding it to the ahci_devices lists, > > without any quirks ma

Re: unifdef snd/rcv

2018-01-03 Thread Claudio Jeker
On Wed, Jan 03, 2018 at 03:46:13PM +0100, Martin Pieuchot wrote: > These defines do not help, they'll make further changes more complicated > to understand, so I'd like to remove them. ok? Yes, this is just being lazy in the wrong place. OK claudio@ > Index: kern/uipc_usrreq.c > ===

unifdef snd/rcv

2018-01-03 Thread Martin Pieuchot
These defines do not help, they'll make further changes more complicated to understand, so I'd like to remove them. ok? Index: kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v retrieving revision 1.122 diff -u -p -r

Intel CPU Security Flaw Kernel Memory Leak (no microcode update) SW workarounds only

2018-01-03 Thread Tom Smyth
Hello all, Thought I might mention this CPU Flaw that apparently allows unauthorised viewing of kernel Memory https://www.theregister.co.uk/2018/01/02/intel_cpu_design_flaw/ apparently there is no microcode update to fix it, and that software only workarounds with heavy performance penalties are

planned outage: openbsd.cs.toronto,edu, obsdacvs.cs.toronto.edu, man.openbsd.org cvsweb.openbsd.org

2018-01-03 Thread Nick Holland
Hiya. Due to facilities maintenance, the following resources will be unavailable from somewhere around Jan 3 8:30pm EST until Jan 7 8:30am EST: * openbsd.cs.toronto,edu * obsdacvs.cs.toronto.edu * man.openbsd.org * cvsweb.openbsd.org Thanks for your patience! Nick.

yacc print_grammar(): loop -> fprintf()

2018-01-03 Thread Michael W. Bombardieri
Hello, In yacc the function print_grammar() writes the file y.output if the -v option is used. fprintf() can be used directly for writing "spacing" space characters of indentation so a loop can be removed. - Michael Index: reader.c ===

malloc cleanup and small optimization (step 3)

2018-01-03 Thread Otto Moerbeek
Hi, this is mostly kshe's work, with an additional change on the cache maintenance by me. I did not take the ffs change yet, since I want to measure the impact separately. -Otto Index: malloc.c === RCS file: /cvs/src/lib/li

include task/timeout in 'struct ifnet'

2018-01-03 Thread Martin Pieuchot
Rather than always allocating them as M_TEMP, include them directly in the structure. ok? Index: net/if.c === RCS file: /cvs/src/sys/net/if.c,v retrieving revision 1.533 diff -u -p -r1.533 if.c --- net/if.c2 Jan 2018 12:52:17 -00

Re: size for free() in if_bwfm_pci.c

2018-01-03 Thread Patrick Wildt
On Wed, Jan 03, 2018 at 03:36:31PM +0800, Michael W. Bombardieri wrote: > Hello, > > In bwfm_pci_dmamem_alloc() and bwfm_pci_dmamem_free(), bdm points > to a single struct not an array. When freeing it we can just use > the struct size. Does this look correct? Yes, thanks, committed! > > - Mich