Re: Move FREF() inside fd_getfile()

2018-04-25 Thread Martin Pieuchot
On 25/04/18(Wed) 17:07, Visa Hankala wrote: > On Wed, Apr 25, 2018 at 12:12:29PM +0200, Martin Pieuchot wrote: > > The goal is to avoid races between fd_getfile() and FREF(). So we want > > a properly refcounted 'struct file *' as soon as possible. > > Boot hangs with this patch. The last line on

Re: net80211: stub SIOCS80211SCAN, make ifconfig scan instant

2018-04-25 Thread Landry Breuil
On Wed, Apr 25, 2018 at 09:14:42PM +0300, Paul Irofti wrote: > On Wed, Apr 25, 2018 at 08:55:26PM +0300, Paul Irofti wrote: > > Hi, > > > > The following diff removes the functionality of the SIOCS80211SCAN ioctl. > > After long discussions with stps@, mpi@, and deraadt@ we decided that > > this w

Re: ifconfig: add -tunneldomain option

2018-04-25 Thread Jason McIntyre
On Wed, Apr 25, 2018 at 10:55:05PM -0700, Ayaka Koshibe wrote: > On Wed, Apr 25, 2018 at 11:58:30AM +0100, Jason McIntyre wrote: > > On Wed, Apr 25, 2018 at 12:20:35PM +0200, Sebastian Benoit wrote: > > > ok > > > > > > > while doing it, can you move the tunneldomain options (both) to after > > t

ifconfig: add -tunneldomain option

2018-04-25 Thread Ayaka Koshibe
On Wed, Apr 25, 2018 at 11:58:30AM +0100, Jason McIntyre wrote: > On Wed, Apr 25, 2018 at 12:20:35PM +0200, Sebastian Benoit wrote: > > ok > > > > while doing it, can you move the tunneldomain options (both) to after > tunneldf instead of before it (both in the mini synopsis and the list)? > if n

Re: [vmd] errror -> error

2018-04-25 Thread Carlos Cardenas
On Wed, Apr 25, 2018 at 07:59:52PM +0200, llgx...@gmail.com wrote: > Hi, > > I spotted a couple more typos: Thanks, I'll commit this later this evening. +--+ Carlos > > Index: vioscsi.c > === > RCS file: /cvs/src/usr.sbin/vmd/vios

minor readability improvement

2018-04-25 Thread Ryan Lennox
Hi, I know this is trivial, but an extra "o" character here might be worth the slight improvement in readability: Index: src/sys/arch/amd64/stand/libsa/memprobe.c === RCS file: /cvs/src/sys/arch/amd64/stand/libsa/memprobe.c,v retrie

query usb device info at device creation

2018-04-25 Thread Landry Breuil
Hi, prompted by mpi@ i tried simplifying the way we get the vendor/product/serial info from the device. Currently this is done lazily, and sometimes several times. Instead of this, let's query the device in usbd_new_device(), fallback to the global known lists then to the USB IDs, cache the info i

Re: net80211: stub SIOCS80211SCAN, make ifconfig scan instant

2018-04-25 Thread Florian Obser
On Wed, Apr 25, 2018 at 09:14:42PM +0300, Paul Irofti wrote: > On Wed, Apr 25, 2018 at 08:55:26PM +0300, Paul Irofti wrote: > > Hi, > > > > The following diff removes the functionality of the SIOCS80211SCAN ioctl. > > After long discussions with stps@, mpi@, and deraadt@ we decided that > > this w

Re: net80211: don't start bgscan timeout unnecessarily

2018-04-25 Thread Paul Irofti
On Wed, Apr 25, 2018 at 06:29:38PM +0200, Stefan Sperling wrote: > If the driver does not provide an ic_bgscan_start function > there is no point in scheduling ic_bgscan_timeout() since > this timeout will find that it has nothing to do. > > ok? OK > Index: ieee80211_input.c > ==

Re: net80211: stub SIOCS80211SCAN, make ifconfig scan instant

2018-04-25 Thread Paul Irofti
On Wed, Apr 25, 2018 at 08:55:26PM +0300, Paul Irofti wrote: > Hi, > > The following diff removes the functionality of the SIOCS80211SCAN ioctl. > After long discussions with stps@, mpi@, and deraadt@ we decided that > this was the correct way of fixing ifconfig scan from blocking the > network st

Re: net80211: stub SIOCS80211SCAN, make ifconfig scan instant

2018-04-25 Thread Stefan Sperling
On Wed, Apr 25, 2018 at 08:55:26PM +0300, Paul Irofti wrote: > Currently tested on iwm(4), urtwn(4), run(4) and athn(4). We are > interested in wider testing, specially on iwn(4) and athn(4) in client > mode. To clarify, we tested athn(4) on USB. We are still looking for a test with athn(4) on PCI

[vmd] errror -> error

2018-04-25 Thread llgxela
Hi, I spotted a couple more typos: Index: vioscsi.c === RCS file: /cvs/src/usr.sbin/vmd/vioscsi.c,v retrieving revision 1.4 diff -u -p -u -p -r1.4 vioscsi.c --- vioscsi.c 19 Jan 2018 14:23:52 - 1.4 +++ vioscsi.c 25 Apr 2

net80211: stub SIOCS80211SCAN, make ifconfig scan instant

2018-04-25 Thread Paul Irofti
Hi, The following diff removes the functionality of the SIOCS80211SCAN ioctl. After long discussions with stps@, mpi@, and deraadt@ we decided that this was the correct way of fixing ifconfig scan from blocking the network stack. The kernel will continue scanning in the background and filling the

Re: eliminate some magic numbers in tetris

2018-04-25 Thread Stefan Sperling
On Wed, Apr 25, 2018 at 07:19:35PM +0200, Theo Buehler wrote: > Trivial turd polishing, inspired by something similar done in Dragonfly > but using the more familiar idiom for a for loop. OK > Index: games/tetris/tetris.c > === > RCS

eliminate some magic numbers in tetris

2018-04-25 Thread Theo Buehler
Trivial turd polishing, inspired by something similar done in Dragonfly but using the more familiar idiom for a for loop. Index: games/tetris/tetris.c === RCS file: /var/cvs/src/games/tetris/tetris.c,v retrieving revision 1.32 diff -u

Re: Move FREF() inside fd_getfile()

2018-04-25 Thread Visa Hankala
On Wed, Apr 25, 2018 at 12:12:29PM +0200, Martin Pieuchot wrote: > The goal is to avoid races between fd_getfile() and FREF(). So we want > a properly refcounted 'struct file *' as soon as possible. Boot hangs with this patch. The last line on the console is "setting tty flags". Two issues spott

net80211: don't start bgscan timeout unnecessarily

2018-04-25 Thread Stefan Sperling
If the driver does not provide an ic_bgscan_start function there is no point in scheduling ic_bgscan_timeout() since this timeout will find that it has nothing to do. ok? Index: ieee80211_input.c === RCS file: /cvs/src/sys/net80211/i

Re: RTM_CHGADDRATTR

2018-04-25 Thread Peter Hessler
On 2018 Apr 18 (Wed) at 19:49:41 +0200 (+0200), Florian Obser wrote: :On Wed, Apr 18, 2018 at 05:05:59PM +0200, Florian Obser wrote: :> This is to inform userland (i.e. slaacd(8)) when duplicate address :> detection finishes. :> :> Not a big fan of the lock/unlock dance but I guess it can't be hel

Re: options(4) improvements

2018-04-25 Thread Il Ka
>>patch: malformed patch at line 44: kernel. Hm. Lets try again. Attached patch works for me on latest version from git. I also uploaded it to https://pastebin.com/raw/LqsbWk5x so, you can do $ ftp -o- https://pastebin.com/raw/LqsbWk5x | dos2unix | patch But I just ran patch attached be

Re: RTM_CHGADDRATTR

2018-04-25 Thread Florian Obser
anyone? should slaacd just poll? On Wed, Apr 18, 2018 at 07:49:41PM +0200, Florian Obser wrote: > On Wed, Apr 18, 2018 at 05:05:59PM +0200, Florian Obser wrote: > > This is to inform userland (i.e. slaacd(8)) when duplicate address > > detection finishes. > > > > Not a big fan of the lock/unlock

Re: Fix for "config(8) "kernel building" instructions lead to bad kernel name (which breaks relink)"

2018-04-25 Thread Jason McIntyre
On Mon, Apr 16, 2018 at 12:32:25AM +0300, IL Ka wrote: > See: > https://marc.info/?l=openbsd-bugs&m=152380023916176&w=2 > > > diff --git usr.sbin/config/config.8 usr.sbin/config/config.8 > index 748aaab7a..10fdf7b92 100644 > --- usr.sbin/config/config.8 > +++ usr.sbin/config/config.8 > @@ -341,6

Re: some const for libcrypto

2018-04-25 Thread Jeremie Courreges-Anglas
On Wed, Apr 25 2018, Theo Buehler wrote: > This is the second, larger part of the diff that was part of sthen's > i386 bulk and it had no fallout. It adds const like OpenSSL to most of > the public API exposed in asn1.h and needs some adjustments in internal > functions. I deliberately left BIO_f_

Re: ifconfig: add -tunneldomain option

2018-04-25 Thread Jason McIntyre
On Wed, Apr 25, 2018 at 12:20:35PM +0200, Sebastian Benoit wrote: > ok > while doing it, can you move the tunneldomain options (both) to after tunneldf instead of before it (both in the mini synopsis and the list)? if not, i can fix it later. jmc > Ayaka Koshibe(akosh...@openbsd.org) on 2018.04

Re: ifconfig: add -tunneldomain option

2018-04-25 Thread Jeremie Courreges-Anglas
On Wed, Apr 25 2018, Ayaka Koshibe wrote: > Hi, > > A while back I got a suggestion to add a '-tunneldomain' option as shorthand > for 'tunneldomain 0' to be consistent with '-rdomain'. > > OK? ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: ifconfig: add -tunneldomain option

2018-04-25 Thread Sebastian Benoit
ok Ayaka Koshibe(akosh...@openbsd.org) on 2018.04.25 00:08:55 -0700: > Hi, > > A while back I got a suggestion to add a '-tunneldomain' option as shorthand > for 'tunneldomain 0' to be consistent with '-rdomain'. > > OK? > > Thanks, > Ayaka > > Index: ifconfig.8 > =

Move FREF() inside fd_getfile()

2018-04-25 Thread Martin Pieuchot
The goal is to avoid races between fd_getfile() and FREF(). So we want a properly refcounted 'struct file *' as soon as possible. Ok? Index: kern/kern_descrip.c === RCS file: /cvs/src/sys/kern/kern_descrip.c,v retrieving revision 1.

Re: some const for libcrypto

2018-04-25 Thread Brent Cook
Looks good, ok bcook@ On Wed, Apr 25, 2018 at 3:22 AM, Theo Buehler wrote: > This is the second, larger part of the diff that was part of sthen's > i386 bulk and it had no fallout. It adds const like OpenSSL to most of > the public API exposed in asn1.h and needs some adjustments in internal > f

Re: sprinkle some const over libssl

2018-04-25 Thread Brent Cook
Nice to see the "const unsigned char *p = d;" hackery going away. ok bcook@ On Tue, Apr 24, 2018 at 2:50 PM, Theo Buehler wrote: > OpenSSL started adding const to functions all over the place. The patch > below makes all our libssl functions match theirs wrt const, except for > BIO_f_ssl(3). I p

some const for libcrypto

2018-04-25 Thread Theo Buehler
This is the second, larger part of the diff that was part of sthen's i386 bulk and it had no fallout. It adds const like OpenSSL to most of the public API exposed in asn1.h and needs some adjustments in internal functions. I deliberately left BIO_f_asn1() for later. Index: lib/libcrypto/asn1/a_bit

ifconfig: add -tunneldomain option

2018-04-25 Thread Ayaka Koshibe
Hi, A while back I got a suggestion to add a '-tunneldomain' option as shorthand for 'tunneldomain 0' to be consistent with '-rdomain'. OK? Thanks, Ayaka Index: ifconfig.8 === RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v retrievin