Re: Fix acpi(4) GeneralSerialBus implementation

2018-05-18 Thread Mike Larkin
On Fri, May 18, 2018 at 08:53:41PM +0200, Mark Kettenis wrote: > Turns out there is an alternate way to encode > AttribBytes/AttribRawBytes (and AttribRawProcessBytes) that I didn't > implement. In fact our parsing of fields has always been wrong when > this alternative encoding is present. But

libcrypto const: first round of mopping up

2018-05-18 Thread Theo Buehler
This is a potpourri of functions that still need conversion. I either missed them in eaerlier batches or they didn't fit nicely with anything else. It's the last piece of the big diff that sthen ran through his bulk build. Note that this diff needs my previous submission "const for s2i_*

const for s2i_* and i2s_ conversion functions

2018-05-18 Thread Theo Buehler
The last bit of my const spree can be nicely be cut into two pieces. The first piece sprinkles some const over these conversion methods: i2o_ECPublicKey(), i2s_ASN1_OCTET_STRING(), s2i_ASN1_OCTET_STRING(), i2s_ASN1_INTEGER(), i2s_ASN1_ENUMERATED(), i2s_ASN1_ENUMERATED_TABLE(). Index:

Re: const for X509_CRL_* functions

2018-05-18 Thread Brent Cook
ok bcook@ On Fri, May 18, 2018 at 9:13 AM, Theo Buehler wrote: > On Fri, May 18, 2018 at 04:03:16PM +0200, Theo Buehler wrote: > > Simple diff that adds const qualifiers to the X509_CRL *x and > > ASN1_OBJECT *obj arguments of X509_CRL_get_ext_count(3), > >

Fix acpi(4) GeneralSerialBus implementation

2018-05-18 Thread Mark Kettenis
Turns out there is an alternate way to encode AttribBytes/AttribRawBytes (and AttribRawProcessBytes) that I didn't implement. In fact our parsing of fields has always been wrong when this alternative encoding is present. But for some reason we lucked out the parser didn't go fully off the rails.

Yet more const for x509.

2018-05-18 Thread Theo Buehler
If I'm not totally confused, this is the penultimate big batch I have lined up. In this diff there are two things I'd like to mention: * a2i_GENERAL_NAME() grew const for its 'char *value' argument. The function contains this piece of code: if (!ASN1_STRING_set(gen->d.ia5,

x509 const continued

2018-05-18 Thread Theo Buehler
Most of these are trivial getters. Only X509_TRUST_add(3), X509_PURPOSE_get_by_sname(3) and X509_PURPOSE_add(3) require a bit more work. Again part of sthen's bulk. Index: lib/libcrypto/x509/x509.h === RCS file:

more const qualifiers for x509

2018-05-18 Thread Theo Buehler
Here is a larger diff. More of the same. The only noteworthy thing here is that OpenSSL can't easily change their ASN1-generated version of X509_NAME_ENTRY_dup(3) into a const function, so we need to cast const away in X509_NAME_add_entry(3). Again part of sthen's bulk. Index:

Re: const for X509_CRL_* functions

2018-05-18 Thread Theo Buehler
On Fri, May 18, 2018 at 04:03:16PM +0200, Theo Buehler wrote: > Simple diff that adds const qualifiers to the X509_CRL *x and > ASN1_OBJECT *obj arguments of X509_CRL_get_ext_count(3), > X509_CRL_get_ext_by_NID(3), X509_CRL_get_ext_by_OBJ(3), > X509_CRL_get_ext_by_critical(3), X509_CRL_get_ext(3),

const for X509_CRL_* functions

2018-05-18 Thread Theo Buehler
Simple diff that adds const qualifiers to the X509_CRL *x and ASN1_OBJECT *obj arguments of X509_CRL_get_ext_count(3), X509_CRL_get_ext_by_NID(3), X509_CRL_get_ext_by_OBJ(3), X509_CRL_get_ext_by_critical(3), X509_CRL_get_ext(3), X509_CRL_get_ext_d2i(3). Index: lib/libcrypto/x509/x509.h

Re: Allow disks to be specifid by duid in install.sub

2018-05-18 Thread Theo Buehler
On Thu, May 17, 2018 at 06:42:15PM -0600, Aaron Bieber wrote: > On Thu, May 17, 2018 at 06:37:56PM -0600, Aaron Bieber wrote: > > On Fri, Mar 02, 2018 at 07:32:04AM -0700, Aaron Bieber wrote: > > > Hi, > > > > > > Currently disks can only be entered in the [sw]d[0-9][0-9] format at the > > >

Re: ldapd: add bsd.schema?

2018-05-18 Thread Reyk Floeter
On Fri, May 18, 2018 at 10:42:43AM +0200, Reyk Floeter wrote: > So, OK? > As sthen@ pointed out, I had shadowPassword in both MUST and MAY. (The reason is that I intended to move it from MUST to MAY, but forgot to remove the MUST). userPassword in nis.schema is also MAY, so it must not be MUST

Re: diff: add if group table to snmpd

2018-05-18 Thread Jan Klemkow
On Mon, May 14, 2018 at 09:21:13PM +0200, Jan Klemkow wrote: > On Mon, May 14, 2018 at 06:53:20PM +0100, Stuart Henderson wrote: > > On 2018/05/14 17:59, Jan Klemkow wrote: > > > The following diff adds an interface group table to the OpenBSD MIBs and > > > the OpenSNMPd. The new snmp table helps

Re: ldapd: add bsd.schema?

2018-05-18 Thread Reyk Floeter
So, OK? On Tue, May 15, 2018 at 02:24:19PM +0200, Reyk Floeter wrote: > Hi, > > could we add an LDAP schema file that makes it easier to use sshd's > "AuthorizedKeysCommand"? > > While most howtos out there agree on the attribute name > "sshPublicKey", there is no common LDAP schema that

errors in usage.c - libusbhid

2018-05-18 Thread David Bern
Hello! Have been using libusbhid and discovered a couple of discrepancies in the man-page (libusbhid.3) and the source of usage.c Some are just factual misses, but I also got (what I think is) 2 errors. I will try to explain them; 1. (This is the I think is an error but not sure). The man-page

Re: mfii(4): add bio(4) support

2018-05-18 Thread Naoki Fukaumi
Hi, From: Jonathan Matthew Subject: Re: mfii(4): add bio(4) support Date: Fri, 18 May 2018 15:30:31 +1000 > On 15/05/18 14:13, Naoki Fukaumi wrote: >> Hi Jonathan Matthew, >> here is updated patch. could you review it? > > I've just committed a series of changes based on