nice side-effect, but rebound doesn't play

2018-07-13 Thread Peter J. Philipp
Hi, Yesterday I was messing with my network and particularily my workstation with the goal of having an internal nameserver serve "internal.centroid.eu" zones for my computers at home, and also do "168.192.in-addr.arpa" reverse. I had no luck diverting this from BIND, and then something

Re: bgpd: less hardcoded rdomain 0

2018-07-13 Thread Claudio
On Fri, Jul 13, 2018 at 11:25:56AM +0200, Sebastian Benoit wrote: > get rid of two more implicit ktable_get with rdomain 0 > ie. ktable_get(/* XXX */ 0) > > should not change anything when run in rdomain 0. > > ok? OK claudio@ > (benno_more_rdomain_instead_of_0.diff) > > diff --git

Re: make sbin/route monitor work on all rdomains

2018-07-13 Thread Claudio Jeker
On Fri, Jul 13, 2018 at 11:55:33AM +0200, Sebastian Benoit wrote: > > ok? > > (benno_route_monitor.diff) > > diff --git sbin/route/route.c sbin/route/route.c > index f98bdeae0a2..d4467a77d04 100644 > --- sbin/route/route.c > +++ sbin/route/route.c > @@ -150,6 +150,7 @@ main(int argc, char

Re: bgpd use struct filterstate in more places

2018-07-13 Thread Claudio Jeker
On Tue, Jul 10, 2018 at 06:37:44PM +0200, Claudio Jeker wrote: > This uses struct filterstate in rde_update_dispatch() and passes the > struct to a few functions down (rde_update_update, path_update and some > more friends). After that it should become easier to move nexthop and > later maybe the

Re: Document xcrypt in the amd64 version of cpu.4

2018-07-13 Thread Jason McIntyre
On Fri, Jul 13, 2018 at 08:36:28PM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to document xcrypt in the amd64 version of cpu.4. > Bits taken from the i386 version. > > Comments? OK? > ok by me. i always wished these pages fleshed out a bit more about some of the flags that

Re: make sbin/route monitor work on all rdomains

2018-07-13 Thread Klemens Nanni
OK kn

Document xcrypt in the amd64 version of cpu.4

2018-07-13 Thread Frederic Cambus
Hi tech@, Here is a diff to document xcrypt in the amd64 version of cpu.4. Bits taken from the i386 version. Comments? OK? Index: share/man/man4/man4.amd64/cpu.4 === RCS file: /cvs/src/share/man/man4/man4.amd64/cpu.4,v retrieving

add -f option to script(1)

2018-07-13 Thread bijan
Hi tech. While trying to test liveshell[1], I noticed the script(1) from base is missing the -f option, flushing the output after each write, which is kinda critical for monitoring the output file by another process. the Linux script utility uses fflush(3) after each write (duhh) but I'm not

Re: typos in unveil(2)

2018-07-13 Thread Jason McIntyre
On Fri, Jul 13, 2018 at 06:04:29PM +0100, Ricardo Mestre wrote: > Cool :) Just did that, now the 4th time is the charm: > fine by me. jmc > Index: unveil.2 > === > RCS file: /cvs/src/lib/libc/sys/unveil.2,v > retrieving revision

Re: typos in unveil(2)

2018-07-13 Thread Ricardo Mestre
Cool :) Just did that, now the 4th time is the charm: Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.1 diff -u -p -u -r1.1 unveil.2 --- unveil.213 Jul 2018 09:25:22 - 1.1 +++

Re: typos in unveil(2)

2018-07-13 Thread Jason McIntyre
On Fri, Jul 13, 2018 at 05:51:44PM +0100, Ricardo Mestre wrote: > Hi Jason, > > Like this? While reviewing I found another tyop > yes. frankly i'd run it through mandoc -Tlint too. jmc > Index: unveil.2 > === > RCS file:

Re: typos in unveil(2)

2018-07-13 Thread Ricardo Mestre
Hi Jason, Like this? While reviewing I found another tyop Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.1 diff -u -p -u -r1.1 unveil.2 --- unveil.213 Jul 2018 09:25:22 - 1.1 +++

Re: typos in unveil(2)

2018-07-13 Thread Jason McIntyre
On Fri, Jul 13, 2018 at 01:00:59PM +0100, Ricardo Mestre wrote: > This one looks better > > Index: unveil.2 > === > RCS file: /cvs/src/lib/libc/sys/unveil.2,v > retrieving revision 1.1 > diff -u -p -u -r1.1 unveil.2 > --- unveil.2

Re: openssl s_time, speed: rename timer operations

2018-07-13 Thread Jeremie Courreges-Anglas
On Fri, Jul 13 2018, Scott Cheloha wrote: > This was supposed to happen ~8 months ago but I got sidetracked > on the "how" of cleaning up the s_time and speed modules. I think I > have an idea of how to attack that now so I want to close off this > separate line of changes before starting in on

openssl s_time, speed: rename timer operations

2018-07-13 Thread Scott Cheloha
This was supposed to happen ~8 months ago but I got sidetracked on the "how" of cleaning up the s_time and speed modules. I think I have an idea of how to attack that now so I want to close off this separate line of changes before starting in on that. As suggested by jca@, change TM_START ->

define rebound magic numbers

2018-07-13 Thread Peter J. Philipp
Hi, While reading through rebound, I noticed the author uses a lot of magic numbers in DNS flags field. I present OpenBSD a set of #defines that I wrote in 2002 on an OpenBSD/macppc iBook in Montreal. If I didn't write all of it then, I followed up with it in 2005 when my own DNS server came

Re: typos in unveil(2)

2018-07-13 Thread Todd C. Miller
On Fri, 13 Jul 2018 13:00:59 +0100, Ricardo Mestre wrote: > This one looks better OK millert@ - todd

Re: typos in unveil(2)

2018-07-13 Thread Ricardo Mestre
This one looks better Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.1 diff -u -p -u -r1.1 unveil.2 --- unveil.213 Jul 2018 09:25:22 - 1.1 +++ unveil.213 Jul 2018 11:59:49 -

typos in unveil(2)

2018-07-13 Thread Ricardo Mestre
Hi, This one is still fresh on the tree, but here's a diff for some typos OK? Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.1 diff -u -p -u -r1.1 unveil.2 --- unveil.213 Jul 2018 09:25:22

make sbin/route monitor work on all rdomains

2018-07-13 Thread Sebastian Benoit
ok? (benno_route_monitor.diff) diff --git sbin/route/route.c sbin/route/route.c index f98bdeae0a2..d4467a77d04 100644 --- sbin/route/route.c +++ sbin/route/route.c @@ -150,6 +150,7 @@ main(int argc, char **argv) int kw; int Terr = 0; int af = AF_UNSPEC; + u_int

bgpd: less hardcoded rdomain 0

2018-07-13 Thread Sebastian Benoit
get rid of two more implicit ktable_get with rdomain 0 ie. ktable_get(/* XXX */ 0) should not change anything when run in rdomain 0. ok? (benno_more_rdomain_instead_of_0.diff) diff --git usr.sbin/bgpd/bgpd.c usr.sbin/bgpd/bgpd.c index 03dec715288..8299102340b 100644 --- usr.sbin/bgpd/bgpd.c

Re: bn_add.c cleanup

2018-07-13 Thread Klemens Nanni
On Wed, Jul 11, 2018 at 06:46:50AM +0200, Theo Buehler wrote: > Our current implementations of BN_{,u}{add,sub}() are plain disgusting. > OpenSSL cleaned this up quite a bit recently -- still under > '(the "License")' -- and now you can actually follow what is going on. > There should be no

Re: Unplugging USB network stick during tcpdump crashes system

2018-07-13 Thread Stefan Sperling
On Wed, Jul 04, 2018 at 11:15:03PM +0200, Alexander Bluhm wrote: > On Wed, Jul 04, 2018 at 08:18:53PM +, Moritz Buhl wrote: > > Removing my usb network interface during `tcpdump -i rum0` caused my > > kernel to crash. A fix is attached. > > This error comes from the usbd_is_dying() check in

Re: rad(8): add rad.conf to changelist(5)

2018-07-13 Thread Florian Obser
On Fri, Jul 13, 2018 at 08:19:17AM +0200, Sebastien Marie wrote: > Hi, > > As rad(8) is linked in the build, I think it makes sens to add rad.conf > to changelist ? thanks! I always forget about the changelist. Commited with tb's tweak. > > Thanks. > -- > Sebastien Marie > > Index:

Re: rad(8): add rad.conf to changelist(5)

2018-07-13 Thread Theo Buehler
On Fri, Jul 13, 2018 at 08:19:17AM +0200, Sebastien Marie wrote: > Hi, > > As rad(8) is linked in the build, I think it makes sens to add rad.conf > to changelist ? If it sorted before radiusd.conf, then it's ok tb > > Thanks. > -- > Sebastien Marie > > Index: changelist >

rad(8): add rad.conf to changelist(5)

2018-07-13 Thread Sebastien Marie
Hi, As rad(8) is linked in the build, I think it makes sens to add rad.conf to changelist ? Thanks. -- Sebastien Marie Index: changelist === RCS file: /cvs/src/etc/changelist,v retrieving revision 1.120 diff -u -p -r1.120