Re: ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > Hi, > > > > Since slaacd is able to use pledge in the parent process I thought it may > > be possible for ospfd too. > > > > It works fine until ospfd gets re

Re: smtpd: malloc+strlcpy -> strndup

2018-09-01 Thread Gilles Chehade
On Sat, Sep 01, 2018 at 09:20:59PM +0800, Michael Mikonos wrote: > Hello, > > Replace a malloc+strlcpy with strndup in cmdline_symset(). > Parameter s is a "keyname=value" string and sym is the > "keyname" part. > > If s is "=value", sym will be an empty string. > The patch doesn't change this be

Re: ims: match on HID touchscreens

2018-09-01 Thread joshua stein
On Sat, 01 Sep 2018 at 20:53:45 +0200, Mark Kettenis wrote: > Not sure if that is indeed the right approach, but we can always fix > it in a better way later. The HID report descriptor contains this: [...] 0x05, 0x01,// Usage Page (Generic Desktop Ctrls) 0x09, 0x30,// Usag

Re: ospf6d: prevent additional ospf6d from starting

2018-09-01 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.08.31 15:49:32 +0200: > Hi, > > this is the adaption of the recent ospfd commit to ospf6d. > > Early in the startup the main process checks if another process is listening > on the control socket and exits if that is the case. Otherwise the master > pr

Re: ospfd: pledge parent process

2018-09-01 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > Hi, > > Since slaacd is able to use pledge in the parent process I thought it may > be possible for ospfd too. > > It works fine until ospfd gets reloaded. At this point it uses setsockopt > to set the priority filter on the rou

ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
Hi, Since slaacd is able to use pledge in the parent process I thought it may be possible for ospfd too. It works fine until ospfd gets reloaded. At this point it uses setsockopt to set the priority filter on the routing socket. Since I could not find a promise for this I extended wroute. Does t

Re: ims: match on HID touchscreens

2018-09-01 Thread Mark Kettenis
> Date: Fri, 31 Aug 2018 16:44:57 -0500 > From: joshua stein > > If there is an i2c HID device that has a Digitizers/Touchscreen > collection and an X report, attach ims to it. hidms already has > support for touchscreens. > > This may help if you have a newer laptop with a touchscreen. > >

Re: ssh: use getservbyname(3) for port numbers

2018-09-01 Thread Theo de Raadt
> Is there a reason ssh doesn't consult services(5) for port numbers? I think I know why but I'm not going to speak about those dark days. Diff looks good to me.

smtpd: malloc+strlcpy -> strndup

2018-09-01 Thread Michael Mikonos
Hello, Replace a malloc+strlcpy with strndup in cmdline_symset(). Parameter s is a "keyname=value" string and sym is the "keyname" part. If s is "=value", sym will be an empty string. The patch doesn't change this behaviour although it might be undesirable to call symset() with an empty string. P

Re: syslogd log rotate documentation

2018-09-01 Thread Todd C. Miller
On Sat, 01 Sep 2018 11:58:25 +0200, Ingo Schwarze wrote: > When starting up, > .Nm > reads its configuration file, > .Xr syslogd.conf 5 , > and opens the configured logfiles and TCP and TLS connections. > The configured logfiles already have to exist > with the correct permissions. > When receivin

Re: relayd close 0

2018-09-01 Thread Todd C. Miller
On Sat, 01 Sep 2018 00:20:15 +0200, Alexander Bluhm wrote: > Accidentally relayd(8) closes file descriptor 0 in the pfe child > process. Usually this is a bad idea. > > snmp_init() does this: > > if (env->sc_snmp != -1) { > ... > close(env->sc_snmp); >

Re: smtpd: smtp_client_state() error message

2018-09-01 Thread Gilles Chehade
On Sat, Sep 01, 2018 at 06:41:43PM +0800, Michael Mikonos wrote: > Hello, > > smtp_client_state() and smtp_client_response() both do > > switch (proto->state) ... > > but smtp_client_state() doesn't print the id of the bad state > in the default case. This patch makes the fatalx() message

Re: smtpd: smtp_client_state() error message

2018-09-01 Thread Stefan Sperling
On Sat, Sep 01, 2018 at 06:41:43PM +0800, Michael Mikonos wrote: > Hello, > > smtp_client_state() and smtp_client_response() both do > > switch (proto->state) ... > > but smtp_client_state() doesn't print the id of the bad state > in the default case. This patch makes the fatalx() message

smtpd: smtp_client_state() error message

2018-09-01 Thread Michael Mikonos
Hello, smtp_client_state() and smtp_client_response() both do switch (proto->state) ... but smtp_client_state() doesn't print the id of the bad state in the default case. This patch makes the fatalx() message the same for both. Does this look OK? - Michael Index: smtp_client.c ===

Re: relayd close 0

2018-09-01 Thread Sebastian Benoit
ok Alexander Bluhm(alexander.bl...@gmx.net) on 2018.09.01 00:20:15 +0200: > Hi, > > Accidentally relayd(8) closes file descriptor 0 in the pfe child > process. Usually this is a bad idea. > > snmp_init() does this: > > if (env->sc_snmp != -1) { > ... > clo

Re: syslogd log rotate documentation

2018-09-01 Thread Ingo Schwarze
Hi Alexander, Alexander Bluhm wrote on Fri, Aug 31, 2018 at 08:59:15PM +0200: > A coworker did not know that he has to send SIGHUP to syslogd after > rotating the log files. I realized that it is not documented. > > ok to add it to the man page? > > While there, replace two 'syslogd' with .Nm