csh: memory leak in setDolp()

2018-09-19 Thread Michael Mikonos
Hello, In setDolp() pointers cp and dp initially point to the same copied string, but later dp can become NULL if Strstr() finds no match. The copied string is not freed in this case. NetBSD added this fix in their dol.c revision 1.23 (2006). OK? - Michael Index: dol.c

Re: memory leak in amdisplay_attach()

2018-09-19 Thread Ian Sutton
On Tue, Sep 18, 2018 at 2:16 AM, Jonathan Gray wrote: > On Tue, Sep 18, 2018 at 08:34:55AM +0200, Claudio Jeker wrote: >> On Tue, Sep 18, 2018 at 03:49:15PM +1000, Jonathan Gray wrote: >> > Index: amdisplay.c >> > === >> > RCS file:

Re: bgpd: more RB tree less simpleq

2018-09-19 Thread Sebastian Benoit
ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.09.19 10:15:22 +0200: > Switch the prefixset simpleq into an RB trie. This allows to spot > duplicates in the parser and is a requirement for roa-sets where > conflicts need to be specially handled. > > OK? > -- > :wq Claudio > > Index:

Re: bgpd: more RB tree less simpleq

2018-09-19 Thread Denis Fondras
On Wed, Sep 19, 2018 at 10:41:15PM +0200, Claudio Jeker wrote: > On Wed, Sep 19, 2018 at 08:50:41PM +0200, Denis Fondras wrote: > > On Wed, Sep 19, 2018 at 10:15:22AM +0200, Claudio Jeker wrote: > > > Switch the prefixset simpleq into an RB trie. This allows to spot > > > duplicates in the parser

Re: bgpd: more RB tree less simpleq

2018-09-19 Thread Claudio Jeker
On Wed, Sep 19, 2018 at 08:50:41PM +0200, Denis Fondras wrote: > On Wed, Sep 19, 2018 at 10:15:22AM +0200, Claudio Jeker wrote: > > Switch the prefixset simpleq into an RB trie. This allows to spot > > duplicates in the parser and is a requirement for roa-sets where > > conflicts need to be

Re: inpcb table and socket lock

2018-09-19 Thread Alexander Bluhm
On Mon, Sep 17, 2018 at 04:00:28PM +0200, Alexander Bluhm wrote: > + /* XXXSMP Is it safe to call notify with inpcbtable mutex? */ > if (notify) > (*notify)(inp, errno); visa@ pointed out that this may cause a deadlock as the notify functions may

Re: bgpd: more RB tree less simpleq

2018-09-19 Thread Denis Fondras
On Wed, Sep 19, 2018 at 10:15:22AM +0200, Claudio Jeker wrote: > Switch the prefixset simpleq into an RB trie. This allows to spot > duplicates in the parser and is a requirement for roa-sets where > conflicts need to be specially handled. > > OK? I don't know if the case is relevant but

Re: simplify dev_mkdb

2018-09-19 Thread Theo de Raadt
Not sure it matters, but I should point out a difference. Your diff makes dev_mkdb -- illegal. In a POSIX world, many programs have to use getopt. Not sure if this is one.

simplify dev_mkdb

2018-09-19 Thread Clemens Goessnitzer
simplify dev_mkdb: -) no need for getopt() since there are no possible options, just check if argc < 1 -) usage() only used once: move it to the single point of failure for user input -) bzero => memset, bcopy => memcpy -) no brackets for

Re: csh: avoid using uninitialized stat buffer

2018-09-19 Thread Michael Mikonos
On Wed, Sep 19, 2018 at 09:19:22AM -0600, Todd C. Miller wrote: > When getcwd() fails, the stat buffer 'swd' is used uninitialized > by the else clause. Since it is used in both clauses we should > perform the stat before the if(). > > However, fixing this causes 'cp' to be unitialized in some

csh: avoid using uninitialized stat buffer

2018-09-19 Thread Todd C. Miller
When getcwd() fails, the stat buffer 'swd' is used uninitialized by the else clause. Since it is used in both clauses we should perform the stat before the if(). However, fixing this causes 'cp' to be unitialized in some case so initialize cp to NULL and move the "cp == NULL" check out of the

bgpd: stop crashing SE after RDE crash

2018-09-19 Thread Claudio Jeker
If the RDE process dies it takes the session engine along. The problem is that the ibuf structures to the RDE become invalid but the SE still tries to send the RDE messages which ends up in tears and SIGSEGV. Wrap the imsg_compose() to ibuf_rde in a new helper function which does a NULL check

Re: Speed up UEFI framebuffer console

2018-09-19 Thread Mark Kettenis
> Date: Sat, 25 Aug 2018 17:38:12 +0200 (CEST) > From: Mark Kettenis > > Here is a diff to speed up the initial framebuffer console on amd64. > It remaps the framebuffer write-combining early on, which speeds up > writing to the framebuffer considerably. > > Remapping is done using

Re: add explanations of vmctl send command in vmctl.8

2018-09-19 Thread Mike Larkin
On Wed, Sep 19, 2018 at 12:22:21PM +0200, Solene Rapenne wrote: > Solene Rapenne wrote: > > This diff explains a little more about the send commands. > > send pauses the VM and send its memory + the start parameters. > > > > new diff with some changes, also thx bentley@ for telling me sentences

Maybe need to enrich `-T' option in netcat manual

2018-09-19 Thread Nan Xiao
Hi tech@, For `-T' option explanation in netcat manual: -T keyword Change the IPv4 TOS value or the TLS options. But in fact, the netcat code not only processes IPv4 but also IPv6: if (Tflag != -1) { if (af == AF_INET && setsockopt(s, IPPROTO_IP,

Re: add explanations of vmctl send command in vmctl.8

2018-09-19 Thread Solene Rapenne
Solene Rapenne wrote: > This diff explains a little more about the send commands. > send pauses the VM and send its memory + the start parameters. > new diff with some changes, also thx bentley@ for telling me sentences should start on a newline in mdoc. Index: vmctl.8

add explanations of vmctl send command in vmctl.8

2018-09-19 Thread Solene Rapenne
This diff explains a little more about the send commands. send pauses the VM and send its memory + the start parameters. It's not obvious when you don't know vmctl. Index: vmctl.8 === RCS file: /cvs/src/usr.sbin/vmctl/vmctl.8,v

bgpd: more RB tree less simpleq

2018-09-19 Thread Claudio Jeker
Switch the prefixset simpleq into an RB trie. This allows to spot duplicates in the parser and is a requirement for roa-sets where conflicts need to be specially handled. OK? -- :wq Claudio Index: bgpd.c === RCS file: