bgpd better yacc error messages

2018-09-20 Thread Claudio Jeker
Fix some of the yyerror messages. Try to be a bit more clear than just "syntax error". Now only the yacc internal "syntax error" is left. -- :wq Claudio ? obj Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving

bgpd, AS 0 is also special

2018-09-20 Thread Claudio Jeker
Similar to AS_TRANS (23456) AS 0 should not be allowed. This adds this restriction for asnumbers which are used on AS, remote-as and local-as tokens in the config. Inside filters as4numer_any is used which does not have any kind of restriction. OK? -- :wq Claudio ? obj Index: parse.y

Re: bgpd, next step towards ROA validation

2018-09-20 Thread Claudio Jeker
On Thu, Sep 20, 2018 at 07:58:10PM +0200, Denis Fondras wrote: > On Thu, Sep 20, 2018 at 01:56:04PM +0200, Claudio Jeker wrote: > > This is the next step for ROA validation. > > > > Implement code to parse, print and reload roa-set tables. > > This is sharing a lot of code with prefixset which

Re: Add "Spleen 5x8" font to wsfont

2018-09-20 Thread Daniel Gracia
Very nice indeed; this is a real alternative for our current devices with 2x16 serial LCDs. Regards! El jue., 20 sept. 2018 a las 21:45, Frederic Cambus () escribió: > Hi tech@, > > Here is a diff to add "Spleen 5x8" to wsfont, a font targetted at small > OLED displays to be used with devices

Add "Spleen 5x8" font to wsfont

2018-09-20 Thread Frederic Cambus
Hi tech@, Here is a diff to add "Spleen 5x8" to wsfont, a font targetted at small OLED displays to be used with devices handled by ssdfb(4). It contains all printable ASCII characters (96 glyphes). The font is 2-Clause BSD licensed and is my original creation. In order to enable and test the

Re: bgpd, next step towards ROA validation

2018-09-20 Thread Denis Fondras
On Thu, Sep 20, 2018 at 01:56:04PM +0200, Claudio Jeker wrote: > This is the next step for ROA validation. > > Implement code to parse, print and reload roa-set tables. > This is sharing a lot of code with prefixset which makes all a bit easier. > A roa-set is defined like this: > roa-set "test2"

Re: bgpd, next step towards ROA validation

2018-09-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.09.20 13:56:04 +0200: > This is the next step for ROA validation. > > Implement code to parse, print and reload roa-set tables. > This is sharing a lot of code with prefixset which makes all a bit easier. > A roa-set is defined like this: > roa-set

Re: csh: memory leak in setDolp()

2018-09-20 Thread Todd C. Miller
On Thu, 20 Sep 2018 12:30:05 +0800, Michael Mikonos wrote: > In setDolp() pointers cp and dp initially point to the same > copied string, but later dp can become NULL if Strstr() finds > no match. The copied string is not freed in this case. > NetBSD added this fix in their dol.c revision 1.23

bgpd, next step towards ROA validation

2018-09-20 Thread Claudio Jeker
This is the next step for ROA validation. Implement code to parse, print and reload roa-set tables. This is sharing a lot of code with prefixset which makes all a bit easier. A roa-set is defined like this: roa-set "test2" { 1.2.3.0/24 source-as 1, 1.2.8.0/22 source-as 3 } This

Re: imsg over network

2018-09-20 Thread Jason McIntyre
anyone want to ok this (or better yet, fix themselves)? jmc On Fri, Sep 14, 2018 at 01:57:13PM -0700, Geoff Hill wrote: > The imsg_init(3) man page currently doesn't make it clear whether > this library can be used for remote communication. > > The current text reads: > > The imsg functions

Re: Maybe need to enrich `-T' option in netcat manual

2018-09-20 Thread Jason McIntyre
On Wed, Sep 19, 2018 at 06:35:13PM +0800, Nan Xiao wrote: > Hi tech@, > > For `-T' option explanation in netcat manual: > > -T keyword > Change the IPv4 TOS value or the TLS options. > > But in fact, the netcat code not only processes IPv4 but also IPv6: > > if (Tflag != -1) { >

Re: Harmonize spacing after ellipses in install.sub

2018-09-20 Thread Frederic Cambus
On Tue, Aug 14, 2018 at 11:31:30AM +0200, Frederic Cambus wrote: > We are using spacing after ellipses in displayed messages in an > inconsistant way. Here is an improved diff which takes into account the cursor position while we are waiting for the task to complete, as pointed out by deraadt@.

Re: bgpd: more refactoring for ROA sets

2018-09-20 Thread Claudio Jeker
On Tue, Sep 18, 2018 at 06:10:48PM +0200, Claudio Jeker wrote: > Since the first bit of ROA sets is in here some refactoring of the code. > Split up as_set into a set_table and an as_set. The first is what does > the lookup and will now also be used in roa-set tries. The as_set is glue > to add

Re: simplify dev_mkdb

2018-09-20 Thread Clemens Goessnitzer
On Wed, Sep 19, 2018 at 12:46:37PM -0600, Theo de Raadt wrote: > Not sure it matters, but I should point out a difference. > > Your diff makes > > dev_mkdb -- > > illegal. > > In a POSIX world, many programs have to use getopt. Not sure if this is one. True, I did not consider that,