Re: user mod -u lead to segfault

2018-10-13 Thread Todd C. Miller
On Sat, 13 Oct 2018 16:57:46 +0200, Moritz Buhl wrote: > I belief this is due to the changes to getpwnam etc. > Sadly I am unable to figure out, why exactly the call to getpwuid > segfaults. But replacing it with a call to user_from_uid helped. > I could not crash the program with other flags

gre(4): handle IPv6 traffic class like IPv4 tos

2018-10-13 Thread David Gwynne
pretty straightforward... ok? Index: if_gre.c === RCS file: /cvs/src/sys/net/if_gre.c,v retrieving revision 1.124 diff -u -p -r1.124 if_gre.c --- if_gre.c24 Jul 2018 07:40:35 - 1.124 +++ if_gre.c13 Oct 2018 21:57:23

user mod -u lead to segfault

2018-10-13 Thread Moritz Buhl
Hi, when using user mod -u, my machine ran into a segfault and the passwd file was left locked. I belief this is due to the changes to getpwnam etc. Sadly I am unable to figure out, why exactly the call to getpwuid segfaults. But replacing it with a call to user_from_uid helped. I could not

pf/pfctl: use PFR_FB_NONE consistently

2018-10-13 Thread Klemens Nanni
Replace hardcoded 0 and implicit checks with enum as done in all other use cases of `pfra_fback'. No object change. OK? Index: sys/net/pf_table.c === RCS file: /cvs/src/sys/net/pf_table.c,v retrieving revision 1.128 diff -u -p

ping: sockaddr size check

2018-10-13 Thread Klemens Nanni
After calling getaddrinfo(3) we check the size of the returned socket address to match for AF-specific cases, but I fail to see how this is even possible. `hints.ai_family' is set appropiately and `res->ai_family' is checked, so `res->ai_addrlen' is guaranteed to be correct. It seems like this

Re: [PATCH] Expose arpinq through sysctl

2018-10-13 Thread Florian Obser
Seems like a reasonable addition. OK florian@ or if someone gives me an OK I can commit it. On Wed, Oct 10, 2018 at 03:18:51PM +0200, Daniel Hokka Zakrisson wrote: > Hi, > > While investigating packet loss through OpenBSD 6.3 firewalls I noticed > that a lot of packets were getting dropped by