Re: uvm_fault: ip_ctloutput

2018-12-01 Thread Greg Steuck
This thwarts the reproducer. Again, I don't know if the invariants are getting violated somewhere else and the patch below is simply papering over the symptoms. Please include with the fix: Reported-by: syzbot+02168317bd0156c13...@syzkaller.appspotmail.com diff --git a/sys/netinet/ip_output.c

Re: uvm_fault: sogetopt

2018-12-01 Thread Greg Steuck
Even though I have no idea what I'm doing, the patch below is enough to thwart the reproducer. There are multiple places where the result of sotounpcb is used without checking the result, but I don't know which invariants are established non-locally. Please do me a favor when committing this or a

Re: apmd: -t: use strtonum()

2018-12-01 Thread Theo Buehler
On Sat, Dec 01, 2018 at 02:26:05PM +0100, Klemens Nanni wrote: > On Sat, Dec 01, 2018 at 08:58:31AM +0100, Martijn van Duren wrote: > > > I'm not sure the EINVAL error string adds valuable information. I would > > > prefer if all these used variants of the idiom suggested in the strtonum > > >

Re: option kcov + GENERIC.MP -> silent crash

2018-12-01 Thread Greg Steuck
Hi Anton, Unfortunately it's still crashing. The log is below, but to make sure I'm not deluding myself, the source tree is https://github.com/blackgnezdo/src/tree/anton-kcov-dec1 This is the workdir where I'm building: commit fea58d64a837907fd3b5c45eb2b77351ac105d5f (HEAD -> anton-kcov-dec1)

Re: option kcov + GENERIC.MP -> silent crash

2018-12-01 Thread Martin Pieuchot
On 01/12/18(Sat) 16:34, Anton Lindqvist wrote: > On Tue, Nov 27, 2018 at 05:52:15PM -0800, Greg Steuck wrote: > > I booted the patched kernel and it seems to have gone farther and I believe > > reached init before crashing. > > By performing a semi-automated bisect I was able to identify the

Re: athn(4) hostap: mem leak

2018-12-01 Thread Martin Pieuchot
On 30/11/18(Fri) 13:49, Benjamin Baier wrote: > Hi > > There is a leak of *arg in > dev/usb/if_athn_usb.c:athn_usb_newauth() line 1263 > since Rev. 1.49 > Because athn_usb_do_async() memcpy's the argument anyway. > > Found with llvm/scan-build. > > Instead of adding free(arg) I opted to make

Re: option kcov + GENERIC.MP -> silent crash

2018-12-01 Thread Anton Lindqvist
On Tue, Nov 27, 2018 at 05:52:15PM -0800, Greg Steuck wrote: > I booted the patched kernel and it seems to have gone farther and I believe > reached init before crashing. By performing a semi-automated bisect I was able to identify the source files that are incompatible with tracing. Common for

Re: apmd: -t: use strtonum()

2018-12-01 Thread Klemens Nanni
On Sat, Dec 01, 2018 at 08:58:31AM +0100, Martijn van Duren wrote: > > I'm not sure the EINVAL error string adds valuable information. I would > > prefer if all these used variants of the idiom suggested in the strtonum > > manual, something like: > > > > errx("number of seconds is

Re: athn(4) hostap: mem leak

2018-12-01 Thread Alexandre Ratchov
On Sat, Dec 01, 2018 at 10:14:38AM +0100, Benjamin Baier wrote: > On Fri, 30 Nov 2018 16:55:42 +0100 > Alexandre Ratchov wrote: > > > On Fri, Nov 30, 2018 at 01:49:56PM +0100, Benjamin Baier wrote: > > > Hi > > > > > > There is a leak of *arg in > > > dev/usb/if_athn_usb.c:athn_usb_newauth()

Re: athn(4) hostap: mem leak

2018-12-01 Thread Benjamin Baier
On Fri, 30 Nov 2018 16:55:42 +0100 Alexandre Ratchov wrote: > On Fri, Nov 30, 2018 at 01:49:56PM +0100, Benjamin Baier wrote: > > Hi > > > > There is a leak of *arg in > > dev/usb/if_athn_usb.c:athn_usb_newauth() line 1263 > > since Rev. 1.49 > > Because athn_usb_do_async() memcpy's the