print regress results

2019-05-14 Thread Alexander Bluhm
Hi, Regress prints FAILED in the middle of the make output, this is hard to watch. tb@ asked me to print a PASSED at the end. As the make processes cannot hold state over several targets or directories, I create a regress log. It is placed in the top directory where you invoke make regress. Al

Re: clean up LC_COLLATE and LC_CTYPE in sort(1)

2019-05-14 Thread Theo Buehler
On Tue, May 14, 2019 at 05:55:21PM +0200, Ingo Schwarze wrote: > Hi, > > after my LC_NUMERIC cleanup for sort(1) went in (thanks to tb@ for > the review), i'd like to adress the rest of locale dependency. > > Large amounts of extremely ugly code in sort(1) - many hundreds of > lines - deal with L

Re: free() sizes in zlib

2019-05-14 Thread Mark Kettenis
> From: Miod Vallat > Date: Tue, 14 May 2019 17:09:36 - (UTC) > > > I have serious doubt whether the whole "plan" for using the sizes to > > change the malloc implementation is feasable. The drm(4) code for > > example relies on emulation of Linux memory allocation APIs to keep > > the diffs

Re: free() sizes in zlib

2019-05-14 Thread Miod Vallat
> I have serious doubt whether the whole "plan" for using the sizes to > change the malloc implementation is feasable. The drm(4) code for > example relies on emulation of Linux memory allocation APIs to keep > the diffs small and jsg@ and myself sane. Most of these APIs don't > pass sizes in the

Re: free() sizes in zlib

2019-05-14 Thread Mark Kettenis
> Date: Tue, 14 May 2019 13:51:05 + > From: Miod Vallat > > This tries to keep diffability against upstream, hence a questionable > choice of the size type for zcfree() - but all sizes should fit in 32 > bits anyway. > > Since all zcfree routines used in the tree cope with NULL arguments > (

Re: clean up LC_COLLATE and LC_CTYPE in sort(1)

2019-05-14 Thread Todd C . Miller
On Tue, 14 May 2019 17:55:21 +0200, Ingo Schwarze wrote: > Consequently, the byte_sort variable can be deleted immediately, > killing case 2 for good, but i'm keeping the sort_mb_cur_max variable > as a global constant for now, even though more than half of the > code it controls is currently dead

clean up LC_COLLATE and LC_CTYPE in sort(1)

2019-05-14 Thread Ingo Schwarze
Hi, after my LC_NUMERIC cleanup for sort(1) went in (thanks to tb@ for the review), i'd like to adress the rest of locale dependency. Large amounts of extremely ugly code in sort(1) - many hundreds of lines - deal with LC_COLLATE, which we don't support now and have no intention to support in the

free() sizes in zlib

2019-05-14 Thread Miod Vallat
This tries to keep diffability against upstream, hence a questionable choice of the size type for zcfree() - but all sizes should fit in 32 bits anyway. Since all zcfree routines used in the tree cope with NULL arguments (including the various alloc.c used by the boot blocks), I have simplified TR

Re: free() sizes for ahc(4)

2019-05-14 Thread Ted Unangst
Miod Vallat wrote: > Note ahc_set_name() gets invoked with the dv_xname field of a struct > device, so it's not a good idea to free anything, should it be invoked > more than once. nice catch.

Re: free() sizes for ahc(4)

2019-05-14 Thread Jan Klemkow
On Tue, May 14, 2019 at 10:35:22AM +, Miod Vallat wrote: > Note ahc_set_name() gets invoked with the dv_xname field of a struct > device, so it's not a good idea to free anything, should it be invoked > more than once. > > Tested on: > ahc0 at pci0 dev 1 function 0 "Adaptec AIC-7880" rev 0x00:

Re: remove regress maxtime

2019-05-14 Thread Otto Moerbeek
On Tue, May 14, 2019 at 02:16:19AM -0400, Alexander Bluhm wrote: > Hi, > > Does anyone use the REGRESS_MAXTIME feature? I would like to remove it. > > - The timeout based on CPU seconds is pretty useless. > Most hanging tests sleep and do not spin. > - A timeout cannot be distinguished from f

Re: Don't use '.Sx' to refer to external sections

2019-05-14 Thread Ingo Schwarze
Hi Stephen, Stephen Gregoratto wrote on Tue, May 14, 2019 at 01:08:00PM +1000: > It was mentioned previously that the use of .Sx to refer to a section in > a different manual page is incorrect. I grepped through the src tree to > see if there were any cases of this and I found a couple. Thanks,

Re: remove regress maxtime

2019-05-14 Thread Ingo Schwarze
Hi Alexander, Alexander Bluhm wrote on Tue, May 14, 2019 at 02:16:19AM -0400: > Does anyone use the REGRESS_MAXTIME feature? Not me. > I would like to remove it. > > - The timeout based on CPU seconds is pretty useless. > Most hanging tests sleep and do not spin. > - A timeout cannot be dist

free() sizes for ahc(4)

2019-05-14 Thread Miod Vallat
Note ahc_set_name() gets invoked with the dv_xname field of a struct device, so it's not a good idea to free anything, should it be invoked more than once. Tested on: ahc0 at pci0 dev 1 function 0 "Adaptec AIC-7880" rev 0x00: irq 8 ahc0: Host Adapter Bios disabled. Using default SCSI device param