Re: unveil dhclient (privileged process)

2019-07-10 Thread Theo de Raadt
Looks solid to me. Ricardo Mestre wrote: > Since krw@ gave me feedback on yet another way to handle the defines I'd > rather > leave that alone for now, it can be left as an exercise later on as you point > out. > > I'll go ahead and commit this instead if no one objects. > > Index: dhclient.

Re: unveil dhclient (privileged process)

2019-07-10 Thread Ricardo Mestre
Since krw@ gave me feedback on yet another way to handle the defines I'd rather leave that alone for now, it can be left as an exercise later on as you point out. I'll go ahead and commit this instead if no one objects. Index: dhclient.c ===

Re: unveil dhclient (privileged process)

2019-07-10 Thread Theo de Raadt
Klemens Nanni wrote: > On Wed, Jul 10, 2019 at 03:44:55PM +0100, Ricardo Mestre wrote: > > Index: dhcpd.h > > === > > RCS file: /cvs/src/sbin/dhclient/dhcpd.h,v > > retrieving revision 1.278 > > diff -u -p -u -r1.278 dhcpd.h > > ---

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread YASUOKA Masahiko
On Wed, 10 Jul 2019 23:50:23 +0100 Stuart Henderson wrote: > On 2019/07/10 23:27, Alexandr Nedvedicky wrote: >> Hello Stuart, >> >> On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: >> > On 2019/07/05 17:09, YASUOKA Masahiko wrote: >> > > Hi, >> > > >> > > Previous diff made src-

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Stuart Henderson
On 2019/07/10 23:27, Alexandr Nedvedicky wrote: > Hello Stuart, > > On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: > > On 2019/07/05 17:09, YASUOKA Masahiko wrote: > > > Hi, > > > > > > Previous diff made src-node have a reference for the kif. My > > > colleague pointed out th

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Alexandr Nedvedicky
Hello Stuart, On Wed, Jul 10, 2019 at 08:19:13PM +0100, Stuart Henderson wrote: > On 2019/07/05 17:09, YASUOKA Masahiko wrote: > > Hi, > > > > Previous diff made src-node have a reference for the kif. My > > colleague pointed out that incrementing the reference count of the kif > > is required.

Re: wsfont & free(9) sizes

2019-07-10 Thread Jan Klemkow
On Wed, Jul 10, 2019 at 12:59:41PM -0300, Martin Pieuchot wrote: > Some free(9) sizes & fix to make wsfont_remove() compile. This function > is #ifndef for the moment. That's mainly for coherency and to reduce > grep noise. > > ok? ok jan > Index: dev/wsfont/wsfont.c > ===

bgpd adj-rib-out rewrite

2019-07-10 Thread Claudio Jeker
This diff is a bit of a monster. It changes the Adj-RIB-Out to be a peer specific set of RB trees instead of using a rib in the original sense. The reason for this is that the more peers a system has the more elements end up being linked into the adj-rib-out and many operations do linear searches w

Re: bgpd: pimp imsg pipes

2019-07-10 Thread Claudio Jeker
On Mon, Jun 17, 2019 at 09:43:00PM +0200, Claudio Jeker wrote: > I noticed that by default the send and recv socket buffers for > socketpair(2) is rather low (4k IIRC). The result is a fairly inefficent > write/read behaviour on the imsg sockets. Increasing SO_SNDBUF and > SO_RCVBUF seems to help i

Re: sysupgrade: select sets to install

2019-07-10 Thread Alexander Bluhm
On Wed, Jul 10, 2019 at 12:18:33PM -0600, Theo de Raadt wrote: > > Ofcourse there are also custom sets, like site${VERSION}-*.tgz . Which is > > something to keep in mind. > > Yeah, we could delete support for that entirely I use site.tgz to configure my regression test machines. This is a useful

Re: pf: use proper interface for route-to when it is used with sticky-address

2019-07-10 Thread Stuart Henderson
On 2019/07/05 17:09, YASUOKA Masahiko wrote: > Hi, > > Previous diff made src-node have a reference for the kif. My > colleague pointed out that incrementing the reference count of the kif > is required. > > ok? > > Fix previous commit which made src-node have a reference for the kif. > Src-nod

Re: sysupgrade: select sets to install

2019-07-10 Thread Theo de Raadt
Hiltjo Posthuma wrote: > On Tue, Jul 09, 2019 at 05:09:12PM +0200, Klemens Nanni wrote: > > I think sysupgrade should, if at all, use the same semantics as the > > installer. That is, something like `sysugprade -S '-* b*'" to upgrade > > nothing but kernels and base. > > > > Such options offer

Re: sysupgrade: select sets to install

2019-07-10 Thread Hiltjo Posthuma
On Tue, Jul 09, 2019 at 05:09:12PM +0200, Klemens Nanni wrote: > I think sysupgrade should, if at all, use the same semantics as the > installer. That is, something like `sysugprade -S '-* b*'" to upgrade > nothing but kernels and base. > > Such options offer great potential for users to shoot th

Re: unveil dhclient (privileged process)

2019-07-10 Thread Klemens Nanni
On Wed, Jul 10, 2019 at 03:44:55PM +0100, Ricardo Mestre wrote: > Index: dhcpd.h > === > RCS file: /cvs/src/sbin/dhclient/dhcpd.h,v > retrieving revision 1.278 > diff -u -p -u -r1.278 dhcpd.h > --- dhcpd.h 22 May 2019 12:56:31 -

Re: wsfont & free(9) sizes

2019-07-10 Thread Martin Pieuchot
On 10/07/19(Wed) 12:59, Martin Pieuchot wrote: > Some free(9) sizes & fix to make wsfont_remove() compile. This function > is #ifndef for the moment. That's mainly for coherency and to reduce > grep noise. Simpler approach that removed compiled-out wsfont_remove(), so we don't have to keep track

Re: OpenBSD: patch for bridge(4) to fix incoming interface for pf(4)

2019-07-10 Thread Martin Pieuchot
On 17/06/19(Mon) 16:15, Eygene Ryabinkin wrote: > Sun, Jun 09, 2019 at 11:44:10AM -0300, Martin Pieuchot wrote: > > On 07/06/19(Fri) 20:50, Eygene Ryabinkin wrote: > > > The attached patch fixes incoming interface for pf(4) processing > > > in the case of bridging of multiple VLAN interfaces which

Re: unveil dhclient (privileged process)

2019-07-10 Thread Bryan Steele
On Wed, Jul 10, 2019 at 03:44:55PM +0100, Ricardo Mestre wrote: > Hi, > > Since the last email I sent, mentioned at the bottom, dhclient(8) has dropped > support for re-execing itself on SIGHUP and so what path, hardcoded or not, > should be unveiled for the executable is out of this conversation.

wsfont & free(9) sizes

2019-07-10 Thread Martin Pieuchot
Some free(9) sizes & fix to make wsfont_remove() compile. This function is #ifndef for the moment. That's mainly for coherency and to reduce grep noise. ok? Index: dev/wsfont/wsfont.c === RCS file: /cvs/src/sys/dev/wsfont/wsfont.c,

libressl: thunderbird -> postfix: started seeing CRYPTO_internal:bad decrypt

2019-07-10 Thread Stuart Henderson
I've had some problems start showing up with users of Thunderbird on Windows sending mail with smtp-auth+TLS. Doesn't seem to affect all mails, possibly just large ones. Started happening yesterday from a couple of different users - I don't see any Thunderbird update at the time though can't rule o

Re: sysupgrade: select sets to install

2019-07-10 Thread Theo de Raadt
Stuart Henderson wrote: > On 2019/07/10 17:02, Ingo Schwarze wrote: > > Hi Theo, > > > > Theo de Raadt wrote on Tue, Jul 09, 2019 at 09:23:25AM -0600: > > > Klemens Nanni wrote: > > > > >> I think sysupgrade should, if at all, use the same semantics as the > > >> installer. That is, something

Re: sysupgrade: select sets to install

2019-07-10 Thread Stuart Henderson
On 2019/07/10 17:02, Ingo Schwarze wrote: > Hi Theo, > > Theo de Raadt wrote on Tue, Jul 09, 2019 at 09:23:25AM -0600: > > Klemens Nanni wrote: > > >> I think sysupgrade should, if at all, use the same semantics as the > >> installer. That is, something like `sysugprade -S '-* b*'" to upgrade >

Re: unveil dhclient (privileged process)

2019-07-10 Thread Ricardo Mestre
Hi, Since the last email I sent, mentioned at the bottom, dhclient(8) has dropped support for re-execing itself on SIGHUP and so what path, hardcoded or not, should be unveiled for the executable is out of this conversation. Please check a new diff which unveils /etc/resolv.conf with write/create

Re: sysupgrade: select sets to install

2019-07-10 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Tue, Jul 09, 2019 at 09:23:25AM -0600: > Klemens Nanni wrote: >> I think sysupgrade should, if at all, use the same semantics as the >> installer. That is, something like `sysugprade -S '-* b*'" to upgrade >> nothing but kernels and base. >> >> Such options offe