Re: iwm: fix support for 3168 devices

2019-11-10 Thread Kevin Lo
On Sat, Nov 09, 2019 at 01:01:39PM +0200, Stefan Sperling wrote: > > This diff makes 3168 devices actually work with iwm(4). > These devices have never worked right since the driver just threw > errors when trying to load firmware. Indeed. The 3168 device didn't work for me (for example, ifconfi

HEADS UP: ntpd changing

2019-11-10 Thread Theo de Raadt
The ntpd options -s and -S are going to be removed soon and at startup with print: -s option no longer works and will be removed soon. Please reconfigure to use constraints or trusted servers. Probably after 6.7 we'll delete the warning. Maybe for 6.8 we'll remove -s and -S from getopt,

TCP send window underflow

2019-11-10 Thread Alexander Bluhm
Hi, FreeBSD has a fix for TCP send window underflow. markus@ has seen that this bug is also triggered in our code. https://svnweb.freebsd.org/base/head/sys/netinet/tcp_input.c?r1=296935&r2=298408 Prevent underflows in tp->snd_wnd if the remote side ACKs more than tp->snd_wnd. This can

Re: db_access & db_expr_t

2019-11-10 Thread Mark Kettenis
> Date: Sun, 10 Nov 2019 13:09:44 +0100 > From: Martin Pieuchot > > 'db_expr_t' is defined as 'long' on all platforms. I'd like to use some > of the ddb interfaces without having to pull all the type & cast mess into > non-DDB code. > > Here's an example of getting rid of in MI code > and usin

tsleep_nsec(9) for 1sec or more

2019-11-10 Thread Martin Pieuchot
This convert tsleep(9) calls that wait for a multiple of `hz' in dev/usb. Ok? Index: if_athn_usb.c === RCS file: /cvs/src/sys/dev/usb/if_athn_usb.c,v retrieving revision 1.53 diff -u -p -r1.53 if_athn_usb.c --- if_athn_usb.c 12

Fewer arguments in DDB backtraces

2019-11-10 Thread Martin Pieuchot
If the kernel successful found a CTF section but a symbol isn't present in it assume it has no argument. This make ddb(4) print simpler trace without garbage for symbols in locore: db_enter() at db_enter+0x10 comintr(80122000) at comintr+0x2af intr_handler(8000

Fix rw_assert_unlocked(9)

2019-11-10 Thread Martin Pieuchot
rw_assert_unlocked(9) should check if the current thread is holding the lock, not if the lock is held by anyone else. The general check is racy and I cannot think of any safe way to use it. Diff below is required for the vm_map_asssert_locked() diff I sent earlier. Index: kern/kern_rwlock.c

Re: /etc/rc: remove useless cat

2019-11-10 Thread Antoine Jacoutot
On Sun, Nov 10, 2019 at 02:51:32PM +0100, Christian Weisgerber wrote: > Since /etc/rc uses ksh constructs anyway, we should use $( of $(cat file). > > ok? OK aja > > Index: rc > === > RCS file: /cvs/src/etc/rc,v > retrieving revisi

Re: /etc/rc: remove useless cat

2019-11-10 Thread Theo Buehler
On Sun, Nov 10, 2019 at 02:51:32PM +0100, Christian Weisgerber wrote: > Since /etc/rc uses ksh constructs anyway, we should use $( of $(cat file). > > ok? ok > > Index: rc > === > RCS file: /cvs/src/etc/rc,v > retrieving revision 1

/etc/rc: remove useless cat

2019-11-10 Thread Christian Weisgerber
Since /etc/rc uses ksh constructs anyway, we should use $(

Re: use nameservers learned from router solicitations in unwind(8)

2019-11-10 Thread Florian Obser
updated diff - makes unwindctl compile - use correct size in add/rem autoconf_forwarders for ipv6 to calculate correct number for forwarders commit ea5f00a210296c44983e1cb64f62ac29005d7119 Author: Florian Obser Date: Fri Nov 8 13:54:20 2019 +0100 Send DNS proposals on route socket when

Re: flex: dead code around flex_die()

2019-11-10 Thread Michael Mikonos
Ping, in case anyone would like to comment. On Thu, Oct 31, 2019 at 08:55:46AM +0800, Michael Mikonos wrote: > Hello, > > The macro flex_die(), defined in flexdef.h, never returns. > Instead it does FLEX_EXIT() which longjmp()s back to flex_main() > before exiting. > The following patch removes s

db_access & db_expr_t

2019-11-10 Thread Martin Pieuchot
'db_expr_t' is defined as 'long' on all platforms. I'd like to use some of the ddb interfaces without having to pull all the type & cast mess into non-DDB code. Here's an example of getting rid of in MI code and using 'long' instead of 'db_expr_t'. ok? Index: ddb/db_access.c ==

Re: ifconfig man page wifi clarifications

2019-11-10 Thread Stefan Sperling
On Sat, Nov 09, 2019 at 07:34:24PM +, Jason McIntyre wrote: > hi stefan. i like your diff. i'll inline some minor comments: Thanks, I have applied your suggestion to my tree. It will commit these changes soon (both the functional change and the man page update).