Re: unwind and split-horizon DNS

2019-11-29 Thread Otto Moerbeek
On Fri, Nov 29, 2019 at 11:37:40PM +0100, Björn Ketelaars wrote: > On Fri 29/11/2019 21:35, Otto Moerbeek wrote: > > On Fri, Nov 29, 2019 at 10:27:57AM +0100, Florian Obser wrote: > > > > > On Fri, Nov 29, 2019 at 07:28:20AM +0100, Otto Moerbeek wrote: > > > > On Fri, Nov 29, 2019 at 07:02:27AM +

ldomctl: Add create-vdisk command

2019-11-29 Thread Klemens Nanni
Just like on amd64 with vmctl(8), I want to be able to easily create disk images. ldomctl(8) currently advises to use dd(1), those files are not sparse either so creating big images may take a lot of time and the process tends to be error prone. `ldomctl create-vdisk -s size file' behaves like `v

Re: syscall call-from verification

2019-11-29 Thread Theo de Raadt
Josh Elsasser wrote: > On Fri, Nov 29, 2019 at 10:12:10AM +0100, Thomas de Grivel wrote: > > Maybe Go is not the only problem, I see SBCL compiling syscalls too. > > > > Truth is libc is for C and not all programs are written in C nowadays. > > Where are you seeing SBCL compiling direct syscall

Re: syscall call-from verification

2019-11-29 Thread Josh Elsasser
On Fri, Nov 29, 2019 at 10:12:10AM +0100, Thomas de Grivel wrote: > Maybe Go is not the only problem, I see SBCL compiling syscalls too. > > Truth is libc is for C and not all programs are written in C nowadays. Where are you seeing SBCL compiling direct syscalls? In my testing, SBCL self-hosts j

Re: unwind and split-horizon DNS

2019-11-29 Thread Björn Ketelaars
On Fri 29/11/2019 21:35, Otto Moerbeek wrote: > On Fri, Nov 29, 2019 at 10:27:57AM +0100, Florian Obser wrote: > > > On Fri, Nov 29, 2019 at 07:28:20AM +0100, Otto Moerbeek wrote: > > > On Fri, Nov 29, 2019 at 07:02:27AM +0100, Björn Ketelaars wrote: > > > > I experienced no regression while using

Re: unwind and split-horizon DNS

2019-11-29 Thread Otto Moerbeek
On Fri, Nov 29, 2019 at 10:27:57AM +0100, Florian Obser wrote: > On Fri, Nov 29, 2019 at 07:28:20AM +0100, Otto Moerbeek wrote: > > On Fri, Nov 29, 2019 at 07:02:27AM +0100, Björn Ketelaars wrote: > > > I experienced no regression while using the free wifi service of the > > > Dutch railways, whic

Re: unveil(2) pcidump(8)

2019-11-29 Thread Ricardo Mestre
Of course I missed unveil(NULL, NULL) Index: pcidump.c === RCS file: /cvs/src/usr.sbin/pcidump/pcidump.c,v retrieving revision 1.55 diff -u -p -u -r1.55 pcidump.c --- pcidump.c 28 Jun 2019 13:32:49 - 1.55 +++ pcidump.c 29

Re: unveil(2) pcidump(8)

2019-11-29 Thread Ricardo Mestre
My emails are getting delayed, I sent another one with unveil(NULL, NULL) right afterwards :) On 10:05 Fri 29 Nov , Theo de Raadt wrote: > Klemens Nanni wrote: > > > On Fri, Nov 29, 2019 at 03:01:45PM +, Ricardo Mestre wrote: > > > All combination of parameters were tested, comments, OK?

Re: unveil(2) usbdevs(8)

2019-11-29 Thread Klemens Nanni
On Fri, Nov 29, 2019 at 03:40:39PM +, Ricardo Mestre wrote: > usbdevs(8) only needs to open devices in O_RDONLY mode from /dev OK kn

Re: unveil(2) pcidump(8)

2019-11-29 Thread Theo de Raadt
Klemens Nanni wrote: > On Fri, Nov 29, 2019 at 03:01:45PM +, Ricardo Mestre wrote: > > All combination of parameters were tested, comments, OK? > OK kn > > > Index: pcidump.c > > === > > RCS file: /cvs/src/usr.sbin/pcidump/pcidu

Re: unveil(2) pcidump(8)

2019-11-29 Thread Klemens Nanni
On Fri, Nov 29, 2019 at 03:01:45PM +, Ricardo Mestre wrote: > All combination of parameters were tested, comments, OK? OK kn > Index: pcidump.c > === > RCS file: /cvs/src/usr.sbin/pcidump/pcidump.c,v > retrieving revision 1.55 > d

unveil(2) usbdevs(8)

2019-11-29 Thread Ricardo Mestre
Hi, usbdevs(8) only needs to open devices in O_RDONLY mode from /dev Comments? OK? Index: usbdevs.c === RCS file: /cvs/src/usr.sbin/usbdevs/usbdevs.c,v retrieving revision 1.31 diff -u -p -u -r1.31 usbdevs.c --- usbdevs.c 14 Apr 2

Re: unveil(2) pcidump(8)

2019-11-29 Thread Theo de Raadt
Looks good. Ricardo Mestre wrote: > Hi, > > pcidump(8) only opens devices in O_RDONLY from /dev, and additionally writes a > `romfile' if -r is used, but since I'm only unveiling after that file is > actually opened there's no need to unveil it as well. > > All combination of parameters were t

Re: Reduce pledge(2) on file(1)'s main proc

2019-11-29 Thread Theo de Raadt
I am surprised to see this missing. Covers a pretty short chunk of code and looks obvious. Ricardo Mestre wrote: > Hi, > > After fork(2) the main proc needs rpath for {l,}stat/open and sendfd for > imsg_* > to send fds to the child proc which is already pledged by recvfd to receive > them. >

Re: typo fix in csh/file.c

2019-11-29 Thread Klemens Nanni
On Thu, Nov 28, 2019 at 09:25:50PM -0700, Nayden Markatchev wrote: > spotted when reading code.. Sure, just commit it right away.

unveil(2) pcidump(8)

2019-11-29 Thread Ricardo Mestre
Hi, pcidump(8) only opens devices in O_RDONLY from /dev, and additionally writes a `romfile' if -r is used, but since I'm only unveiling after that file is actually opened there's no need to unveil it as well. All combination of parameters were tested, comments, OK? Index: pcidump.c

Re: Reduce pledge(2) on file(1)'s main proc

2019-11-29 Thread Bryan Steele
On Fri, Nov 29, 2019 at 11:06:45AM +, Ricardo Mestre wrote: > Hi, > > After fork(2) the main proc needs rpath for {l,}stat/open and sendfd for > imsg_* > to send fds to the child proc which is already pledged by recvfd to receive > them. > > Still passes regress tests, OK? > > Index: file.c

proctree lock diff

2019-11-29 Thread Martin Pieuchot
For archive, here's the diff on top of -current. diff --git sys/kern/exec_elf.c sys/kern/exec_elf.c index 24adf0dbed6..ccbbc6eb3a9 100644 --- sys/kern/exec_elf.c +++ sys/kern/exec_elf.c @@ -1217,12 +1217,14 @@ coredump_notes_elf(struct proc *p, void *iocookie, size_t *sizep) cpi.c

Reduce pledge(2) on file(1)'s main proc

2019-11-29 Thread Ricardo Mestre
Hi, After fork(2) the main proc needs rpath for {l,}stat/open and sendfd for imsg_* to send fds to the child proc which is already pledged by recvfd to receive them. Still passes regress tests, OK? Index: file.c === RCS file: /cvs/s

Re: Add __func__ to panic() and printf() calls in sys/netinet6/*:

2019-11-29 Thread Martin Pieuchot
On 28/11/19(Thu) 16:49, nayden wrote: > Hello, > > A mostly mechanical diff that makes use of __func__ in place of hardcoded > function names in panic() and printf() calls. > > If someone is working in netinet6 and this change will trample > your work please let me know and I'll hold off. > > ok

Re: unwind and split-horizon DNS

2019-11-29 Thread Florian Obser
On Fri, Nov 29, 2019 at 07:28:20AM +0100, Otto Moerbeek wrote: > On Fri, Nov 29, 2019 at 07:02:27AM +0100, Björn Ketelaars wrote: > > I experienced no regression while using the free wifi service of the > > Dutch railways, which is known to do strange things with DNS. > > Thanks for testing. The D

Re: syscall call-from verification

2019-11-29 Thread Thomas de Grivel
Maybe Go is not the only problem, I see SBCL compiling syscalls too. Truth is libc is for C and not all programs are written in C nowadays. Le jeu. 28 nov. 2019 à 21:04, Theo de Raadt a écrit : > > Miod Vallat wrote: > > > > For dynamic binaries, valid regions are ld.so's text segment, the sign