sparc64: magma(4): timeout_add(9) -> timeout_add_msec(9)

2020-02-10 Thread Scott Cheloha
Another sbus(4) device driver. This code converts between milliseconds and ticks. If we strip out the conversions we can just use milliseconds directly with timeout_add_msec(9) and delete the conversion code, too. This is only built for sparc64. It ought to compile but I'm not sure. Assuming i

sparc64: stp(4): tsleep(9) -> tsleep_nsec(9)

2020-02-10 Thread Scott Cheloha
Ticks to microseconds. The parameter name "ms" is misleading. All the calling code uses microseconds. I think the author's thought process in choosing that name was roughly: "microseconds" -> "Micro Seconds" -> "ms". In any case, I've renamed the parameter to the less misleading "usecs". This

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
On Feb 10 14:53:33, mill...@openbsd.org wrote: > On Mon, 10 Feb 2020 17:12:53 +0100, Jan Stary wrote: > > > The -r option of newsyslog(8) removes the requirement > > that newsyslog runs as root. Would it also make sense > > to not try to send the SIGHUP to syslogd in that case? > > This seems wro

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
Hi Ingo, On Feb 10 22:40:20, schwa...@usta.de wrote: > > The -r option of newsyslog(8) removes the requirement > > that newsyslog runs as root. Would it also make sense > > to not try to send the SIGHUP to syslogd in that case? > > While i'm not sure that i want to take care of this patch, > give

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Todd C . Miller
On Mon, 10 Feb 2020 17:12:53 +0100, Jan Stary wrote: > The -r option of newsyslog(8) removes the requirement > that newsyslog runs as root. Would it also make sense > to not try to send the SIGHUP to syslogd in that case? This seems wrong to me. You are disabling more than just sending a signal

Re: setlocale() in cron

2020-02-10 Thread Todd C . Miller
On Mon, 10 Feb 2020 22:16:04 +0100, Ingo Schwarze wrote: > Even if there were something locale-dependent in cron(8), and even > if we consider somebody using these program in a portable way on a > non-OpenBSD system, i believe a daemon started as root should not be > locale-dependent, so i'd like

Re: don't try to signal with newsyslog -r

2020-02-10 Thread Ingo Schwarze
Hi, Jan Stary wrote on Mon, Feb 10, 2020 at 05:12:53PM +0100: > The -r option of newsyslog(8) removes the requirement > that newsyslog runs as root. Would it also make sense > to not try to send the SIGHUP to syslogd in that case? While i'm not sure that i want to take care of this patch, given

Re: syslogd closing all udp is a tiny bit aggressiv

2020-02-10 Thread sven falempin
On Sun, Feb 9, 2020 at 4:12 PM Alexander Bluhm wrote: > On Thu, Feb 06, 2020 at 05:57:15PM -0500, sven falempin wrote: > > > Your DNS lookup fails at startup, sockets are closed. > > > Later at SIGHUP you DNS works again. Now the sockets are needed. > > > So do not close them if DNS for udp fail

Re: setlocale() in cron

2020-02-10 Thread Ingo Schwarze
Hi, Jan Stary wrote on Mon, Feb 10, 2020 at 01:13:58PM +0100: > Why does cron(8) and crontab(1) need to setlocale()? I looked through the *.c files in /usr/src/usr.sbin/cron/ and found the following locale-dependent functions: atrun.c: isalpha(3), isupper(3) cron.c: strtod(3) do_comm

Re: Audio control API, part 2: add new sndioctl(1) utility

2020-02-10 Thread Alexandre Ratchov
On Mon, Feb 10, 2020 at 09:59:09AM +, Raf Czlonka wrote: > On Sun, Feb 09, 2020 at 12:14:47PM GMT, Alexandre Ratchov wrote: > > Here's a new sndioctl utility similar to mixerctl(1) but using the new > > sndio API. Example: > > > > $ sndioctl

Re: hidmt(4): only allow hid_input kind

2020-02-10 Thread Peter Stuge
Hi, Mark Kettenis wrote: > > Since we don't filter out hid_(end)collection, we add this item to the > > list. So, by making sure we only add hid_input items, the Pinebook > > Pro's trackpad works. > > > > Now I'm not sure if the hid code is supposed to re-use the Y-coordi- > > nates usage on the

Re: nep(4) rx error interrupts

2020-02-10 Thread Jonathan Matthew
On Mon, Feb 10, 2020 at 02:04:06PM +0100, Mark Kettenis wrote: > Jonathan Matthew schreef op 2020-02-10 13:19: > > I'm trying to use aggr on top of nep(4), which has turned up a few bugs. > > Firstly, the nic appears to report rx errors in the second interrupt > > state vector, which the driver doe

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-10 Thread Marc Espie
On Sun, Feb 09, 2020 at 01:37:33PM +, Jason McIntyre wrote: > On Sun, Feb 09, 2020 at 02:27:23PM +0100, Marc Espie wrote: > > On Sun, Feb 09, 2020 at 12:41:43AM +0100, Sebastian Benoit wrote: > > > Ingo Schwarze(schwa...@usta.de) on 2020.02.09 00:33:06 +0100: > > > > Hi, > > > > > > > > Jason

Re: gpio(4) support for APU2

2020-02-10 Thread Theo de Raadt
Mark Kettenis wrote: > Nathanael Rensen schreef op 2020-01-29 15:47: > > The diff below adds gpio(4) support to wbsio(4) for Nuvoton NCT5104D > > (pcengines APU2). It is based on Matt Dainty's diff posted to this list > > in November 2018: > > > > https://marc.info/?l=openbsd-tech&m=15413494102

Re: Add note about example dhclient.conf

2020-02-10 Thread Ingo Schwarze
Hi Kyle, Kyle Isom wrote on Mon, Feb 10, 2020 at 07:34:25AM -0800: > On Sat, Feb 8, 2020, at 14:15, Jason McIntyre wrote: >> - i'm ok with adding the path to these files to a FILES section > Done. I already committed a comprehensive diff doing that in a simpler way earlier today: https://mar

don't try to signal with newsyslog -r

2020-02-10 Thread Jan Stary
The -r option of newsyslog(8) removes the requirement that newsyslog runs as root. Would it also make sense to not try to send the SIGHUP to syslogd in that case? Jan Index: newsyslog.8 === RCS file: /cvs/src/usr.bin/newsysl

Re: Add note about example dhclient.conf

2020-02-10 Thread Kyle Isom
On Sat, Feb 8, 2020, at 14:15, Jason McIntyre wrote: > - i'm ok with adding the path to these files to a FILES section Done. - Kyle Index: sbin/dhclient/dhclient.conf.5 === RCS file: /cvs/src/sbin/dhclient/dhclient.conf.5,v retrievi

Re: lcd(4/hppa): timeout_add(9) -> timeout_add_usec(9)

2020-02-10 Thread Scott Cheloha
On Mon, Feb 10, 2020 at 11:48:34AM +0100, Mark Kettenis wrote: > On 2020-02-08 20:15, Scott Cheloha wrote: > > On Sun, Dec 22, 2019 at 01:17:56PM -0600, Scott Cheloha wrote: > > > lcd_softc.sc_delay's unit appears to be microseconds. > > > > > > ok? > > > > 1 month bump. > > While the diff looks

Re: hidmt(4): only allow hid_input kind

2020-02-10 Thread Mark Kettenis
Patrick Wildt schreef op 2020-01-26 06:50: Hi, on the Pinebook Pro the trackpad isn't working. The reason is that the Y-coordinate is extracted twice. The first location has thevalue correctly, the second location has it zeroed or garbage. This is because when we iterate over the report, the

Re: nep(4) rx error interrupts

2020-02-10 Thread Mark Kettenis
Jonathan Matthew schreef op 2020-02-10 13:19: I'm trying to use aggr on top of nep(4), which has turned up a few bugs. Firstly, the nic appears to report rx errors in the second interrupt state vector, which the driver doesn't expect, so I get this: nep3: nep_intr 0 8 0 and then, since the int

Re: ldom.conf: Support devlias keyword for vdisk

2020-02-10 Thread Mark Kettenis
Klemens Nanni schreef op 2020-02-05 21:35: Straight forward diff to allow calling disks names: $ cat ldom.conf domain guest { vcpu 4 memory 8G vnet vdisk "/var/ldom/guest.img" vdisk "/var/ldom/miniroo

Re: gpio(4) support for APU2

2020-02-10 Thread Mark Kettenis
Nathanael Rensen schreef op 2020-01-29 15:47: The diff below adds gpio(4) support to wbsio(4) for Nuvoton NCT5104D (pcengines APU2). It is based on Matt Dainty's diff posted to this list in November 2018: https://marc.info/?l=openbsd-tech&m=154134941027009&w=2 A key difference from Matt Daint

nep(4) rx error interrupts

2020-02-10 Thread Jonathan Matthew
I'm trying to use aggr on top of nep(4), which has turned up a few bugs. Firstly, the nic appears to report rx errors in the second interrupt state vector, which the driver doesn't expect, so I get this: nep3: nep_intr 0 8 0 and then, since the interrupt wasn't rearmed, the interface stops. The

Re: iwm: work around missing Tx completion interrupts

2020-02-10 Thread Mark Kettenis
Stefan Sperling schreef op 2020-02-06 12:45: At 36c3 I noticed roaming failures with iwm(4) where we would get stuck trying to roam to a different AP. Debugging this with bluhm@ we found that the reason it gets stuck is a non-zero refcount on the ic_bss node. When roaming, we wait for this ref

setlocale() in cron

2020-02-10 Thread Jan Stary
Why does cron(8) and crontab(1) need to setlocale()? Jan Index: cron.c === RCS file: /cvs/src/usr.sbin/cron/cron.c,v retrieving revision 1.77 diff -u -p -r1.77 cron.c --- cron.c 23 Oct 2017 15:15:22 - 1.77 +++

cp.c and rm.c embedded in mv(1)

2020-02-10 Thread Jan Stary
mv code contains copies of cp.c and rm.c - is that so that mv can avoid the fork+exec (and call the relevant cp/rm code itself)? If so, is it so that mv can be pledged? It isn't. There must be something worth the duplication ... Jan

Re: lcd(4/hppa): timeout_add(9) -> timeout_add_usec(9)

2020-02-10 Thread Mark Kettenis
On 2020-02-08 20:15, Scott Cheloha wrote: On Sun, Dec 22, 2019 at 01:17:56PM -0600, Scott Cheloha wrote: lcd_softc.sc_delay's unit appears to be microseconds. ok? 1 month bump. While the diff looks ok to me, I can't test this until I have physical access to my hppa machines. Index: dev/lc

Re: Audio control API, part 2: add new sndioctl(1) utility

2020-02-10 Thread Raf Czlonka
On Sun, Feb 09, 2020 at 12:14:47PM GMT, Alexandre Ratchov wrote: > Here's a new sndioctl utility similar to mixerctl(1) but using the new > sndio API. Example: > > $ sndioctl > output.level=127 > app/aucat0.level=127 > app/firefox0.level=127 > a