Re: amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-29 Thread Charlie Burnett
Doesn’t DRM_INFO output even if DRMDEBUG is enabled? I thought DRM_DEBUG only output when debug’s enabled while DRM_INFO is pretty much just a wrapper for printk? Either way, I found the call writing to the GPU register it doesn’t like earlier this weekend, but haven’t figured out what exactly it’

Re: kvm_getfiles and KERN_FILE_BYFILE

2020-11-29 Thread Martijn van Duren
On Sun, 2020-11-29 at 16:15 -0800, Philip Guenther wrote: > On Sun, Nov 29, 2020 at 12:14 PM Martijn van Duren > wrote: > > On Sat, 2020-11-28 at 16:23 -0800, Philip Guenther wrote: > > > On Thu, Nov 26, 2020 at 1:08 PM Martijn van Duren > > > wrote: > > > > I'm currently playing around a bit w

Re: Un-const pci_attach_args var

2020-11-29 Thread Kevin Lo
On Sun, Nov 29, 2020 at 07:00:53PM -0800, Greg Steuck wrote: > > Kevin Lo writes: > > > ok? > > I guess your goal was consistency (though I'd prefer the opposite > direction). There's one more case: > > ./dev/pci/if_de.c:4401:struct pci_attach_args * const pa = (struct > pci_attach_args *

Re: amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-29 Thread Jonathan Gray
On Sun, Nov 29, 2020 at 10:17:22PM -0600, Charlie Burnett wrote: > Howdy all, > For reasons that are beyond me, when printf is called in amdgpu_device.c to > print the CU info, it gives me a psp firmware load failure on a Radeon VII > (Vega 20) gpu. Switching the printf statement to a DRM_INFO stat

amdgpu(4): use DRM_INFO instead of printf for printing compute unit info

2020-11-29 Thread Charlie Burnett
Howdy all, For reasons that are beyond me, when printf is called in amdgpu_device.c to print the CU info, it gives me a psp firmware load failure on a Radeon VII (Vega 20) gpu. Switching the printf statement to a DRM_INFO statement as used in the rest of amdgpu seems to fix it though. ok? diff --

Re: tcpdump: use unsigned char in isprint

2020-11-29 Thread Greg Steuck
Vitaliy Makkoveev writes: > Hi. > > For me `ch' is unwanted here. > > Index: usr.sbin/tcpdump/util.c > === > RCS file: /cvs/src/usr.sbin/tcpdump/util.c,v > retrieving revision 1.30 > diff -u -p -r1.30 util.c > --- usr.sbin/tcpdump/ut

Re: Un-const pci_attach_args var

2020-11-29 Thread Greg Steuck
Kevin Lo writes: > ok? I guess your goal was consistency (though I'd prefer the opposite direction). There's one more case: ./dev/pci/if_de.c:4401:struct pci_attach_args * const pa = (struct pci_attach_args *) aux; which, funny enough, has been since rev 1.1. Thanks Greg

Re: kvm_getfiles and KERN_FILE_BYFILE

2020-11-29 Thread Philip Guenther
On Sun, Nov 29, 2020 at 12:14 PM Martijn van Duren < openbsd+t...@list.imperialat.at> wrote: > On Sat, 2020-11-28 at 16:23 -0800, Philip Guenther wrote: > > On Thu, Nov 26, 2020 at 1:08 PM Martijn van Duren < > openbsd+t...@list.imperialat.at> wrote: > > > I'm currently playing around a bit with k

Re: tcpdump: use unsigned char in isprint

2020-11-29 Thread Vitaliy Makkoveev
Hi. For me `ch' is unwanted here. Index: usr.sbin/tcpdump/util.c === RCS file: /cvs/src/usr.sbin/tcpdump/util.c,v retrieving revision 1.30 diff -u -p -r1.30 util.c --- usr.sbin/tcpdump/util.c 24 Jan 2020 22:46:37 - 1.30

tcpdump: use unsigned char in isprint

2020-11-29 Thread Martin Vahlensieck
Hi I think this is the way it was meant. Best, Martin Index: util.c === RCS file: /cvs/src/usr.sbin/tcpdump/util.c,v retrieving revision 1.30 diff -u -p -r1.30 util.c --- util.c 24 Jan 2020 22:46:37 - 1.30 +++ util.c

Re: kvm_getfiles and KERN_FILE_BYFILE

2020-11-29 Thread Martijn van Duren
On Sat, 2020-11-28 at 16:23 -0800, Philip Guenther wrote: > On Thu, Nov 26, 2020 at 1:08 PM Martijn van Duren > wrote: > > I'm currently playing around a bit with kvm_getfiles and found that I > > couldn't use KERN_FILE_BYFILE with DTYPE_SOCKET. > > According to kvm_getfiles(3): > >      For KERN

Re: Fwd: gre(4): mgre

2020-11-29 Thread Pierre Emeriaud
Le sam. 28 nov. 2020 à 21:46, Jason McIntyre a écrit : > > > > +.Bd -literal > > > add "-offset indent" to match the other examples > > Done, although I copied this block from gre example, so there's > > another occurrence here which I didn't touch. > > > > yes, sorry, that's my mistake. i think t

Re: ldapd warning

2020-11-29 Thread Florian Obser
On Sun, Nov 29, 2020 at 08:41:50AM +0100, Theo Buehler wrote: > On Sun, Nov 29, 2020 at 08:02:45AM +0100, Emil Engler wrote: > > It can overflow! Please check for the positivity and width of size_t before! > > What can overflow? ret is guaranteed to be non-negative before the cast. > > As for the

rad(8): rdomain support

2020-11-29 Thread Florian Obser
Let rad(8) handle all rdomains in a single daemon, similar to previous work in slaacd. Suggested / requested by tb who showed me previous work by reyk which unfortunately predated my work in slaacd and followed a different pattern. There has already been a fair bit of testing and input from

Re: ldapd warning

2020-11-29 Thread Florian Obser
On Sun, Nov 29, 2020 at 06:42:47PM +1000, Jonathan Matthew wrote: > On Sat, Nov 28, 2020 at 11:20:30PM +0100, Theo Buehler wrote: > > /usr/src/usr.sbin/ldapd/util.c:46:21: warning: comparison of integers of > > different signs: > > 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] >

Re: ldapd warning

2020-11-29 Thread Jonathan Matthew
On Sat, Nov 28, 2020 at 11:20:30PM +0100, Theo Buehler wrote: > /usr/src/usr.sbin/ldapd/util.c:46:21: warning: comparison of integers of > different signs: > 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] > if (ret < 0 || ret >= size) >~~~ ^ >

Re: vmm(4): cpuid leaf 0x15 fixes clock speed problem in Linux guest [PATCH]

2020-11-29 Thread Jozef Hatala
On Sun, Nov 29, 2020 at 12:04:04AM -0800, I wrote: > On Sun, Nov 29, 2020 at 06:36:17AM +, Mike wrote: > > And what are you going to return for the other leaf nodes now that > > you are claiming a CPUID level of 0x15, on CPUs that are less than > > that? > > > > Eg, if your host supports level

Re: vmm(4): cpuid leaf 0x15 fixes clock speed problem in Linux guest [PATCH]

2020-11-29 Thread Jozef Hatala
On Sun, Nov 29, 2020 at 06:36:17AM +, Mike wrote: > And what are you going to return for the other leaf nodes now that > you are claiming a CPUID level of 0x15, on CPUs that are less than > that? > > Eg, if your host supports level 0xb (11), what happens in your diff > if the guest VM requests