small typo in imsg_init.3

2020-12-12 Thread Aisha Tammy
Hi,   While creating a portable version of imsg, I noticed a small typo in the imsg_init.3 man page which says the returned value is 'len' instead of 'datalen'. Attached the patch to fix it. OK? Cheers, Aisha diff --git a/lib/libutil/imsg_init.3 b/lib/libutil/imsg_init.3 index

Re: diff: cleanup type handling

2020-12-12 Thread Alexander Bluhm
On Sat, Dec 12, 2020 at 02:25:03PM +0100, Jan Klemkow wrote: > The type of the local variable hash in pf_map_addr() has right length > but the wrong type. This diff uses the correct type and removes the > useless casts. Both functions uses hash as pf_addr, so no cast is > needed. > > OK? OK

syncer_thread: sleep without lbolt

2020-12-12 Thread Scott Cheloha
Hi, The syncer thread is one of the last users of the lbolt (lightning bolt!) sleep channel. If we add a syncer-specific sleep channel (syncer_chan) and do a bit of time math we can replicate the current behavior and remove another lbolt user. This isn't a perfect recreation of the current

diff: cleanup type handling

2020-12-12 Thread Jan Klemkow
Hi, The type of the local variable hash in pf_map_addr() has right length but the wrong type. This diff uses the correct type and removes the useless casts. Both functions uses hash as pf_addr, so no cast is needed. OK? bye, Jan Index: net/pf_lb.c

diff: replace useless use of MCLGETL with MCLGET

2020-12-12 Thread Jan Klemkow
Hi, The use of MCLGETL with the default length MCLBYTES is useless. Thus, this diff removes '(void)' from the MCLGET macro as it is in the MCLGETL and replaces all uses of MCLGETL with MCLBYTES by MCLGET. OK? bye, Jan Index: arch/octeon/dev/if_ogx.c

Re: libcurses: --enable-const

2020-12-12 Thread Todd C . Miller
On Sat, 12 Dec 2020 16:28:18 +0100, Christian Weisgerber wrote: > ncurses has a configure option that adds a few more consts to its > headers by way of the NCURSES_CONST define. Starting with version > 6.0, this has become the default. OpenBSD is still on ncurses 5.7, > but FreeBSD and I guess

libcurses: --enable-const

2020-12-12 Thread Christian Weisgerber
ncurses has a configure option that adds a few more consts to its headers by way of the NCURSES_CONST define. Starting with version 6.0, this has become the default. OpenBSD is still on ncurses 5.7, but FreeBSD and I guess most Linux distributions have moved on. I suggest we also enable the

Re: uvm_fault: entering swap code

2020-12-12 Thread Jonathan Matthew
On Thu, Dec 10, 2020 at 10:46:58AM -0300, Martin Pieuchot wrote: > On 08/12/20(Tue) 22:55, Jonathan Matthew wrote: > > On Mon, Dec 07, 2020 at 03:15:50PM -0300, Martin Pieuchot wrote: > > > Getting a page from the fault handler might require poking at some > > > swap-related states. > > > > > >

Re: openrsync: fix poll_timeout in server mode

2020-12-12 Thread Claudio Jeker
On Sat, Dec 12, 2020 at 07:07:20AM -0500, Daniel Moch wrote: > A recent change to openrsync added the --timeout opt. There's code to > handle the (default) case of --timeout=0, which sets the poll_timeout > to -1 (INFTIM). Unfortunately that code doesn't run in the server > process, meaning all

openrsync: fix poll_timeout in server mode

2020-12-12 Thread Daniel Moch
A recent change to openrsync added the --timeout opt. There's code to handle the (default) case of --timeout=0, which sets the poll_timeout to -1 (INFTIM). Unfortunately that code doesn't run in the server process, meaning all of the relevant calls to poll(2) return immediately and the process

Re: Switch select(2) to kqueue-based implementation

2020-12-12 Thread Visa Hankala
On Fri, Dec 11, 2020 at 09:35:59AM -0300, Martin Pieuchot wrote: > On 10/12/20(Thu) 09:59, Martin Pieuchot wrote: > > All previous kqueue refactoring have been committed, here's a final diff > > to modify the internal implementation of {p,}select(2) to query kqfilter > > handlers instead of poll