Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Christian Weisgerber wrote: > Theo de Raadt: > > > What is lacking in this converstation is the justification. > > Why? > > Providing STAILQ in OpenBSD will simplify porting to OpenBSD. > (Reality check: There is one port affected by this.) > > Switching OpenBSD to STAILQ will simplify porting

extern int optreset not needed

2020-12-26 Thread Jan Stary
ftpd doesn't need to declare extern int optreset as that is already done in the included unistd.h Jan Index: popen.c === RCS file: /cvs/src/libexec/ftpd/popen.c,v retrieving revision 1.29 diff -u -p -r1.29 popen.c --- popen.c

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Christian Weisgerber
Theo de Raadt: > What is lacking in this converstation is the justification. > Why? Providing STAILQ in OpenBSD will simplify porting to OpenBSD. (Reality check: There is one port affected by this.) Switching OpenBSD to STAILQ will simplify porting from OpenBSD. (There are three or four FreeBSD

bpf(4): remove ticks

2020-12-26 Thread Scott Cheloha
Now that we've removed bd_rdStart from the bpf_d struct, removing ticks from bpf(4) itself is straightforward. - bd_rtout becomes a timespec; update bpfioctl() accordingly. Cap it at MAXTSLP nanoseconds to avoid arithmetic overflow in bpfread(). - At the start of bpfread(), if a timeout is se

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Todd C. Miller wrote: > On Sat, 26 Dec 2020 10:45:21 -0700, "Theo de Raadt" wrote: > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > with FreeBSD and Linux. > > > > More than half the stuff being touched doesn't exist in FreeBSD or Linux. > > > > SIMPLEQ_ goes ba

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Stuart Henderson
On 2020/12/26 18:39, Denis Fondras wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base t

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Todd C . Miller
On Sat, 26 Dec 2020 10:45:21 -0700, "Theo de Raadt" wrote: > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > with FreeBSD and Linux. > > More than half the stuff being touched doesn't exist in FreeBSD or Linux. > > SIMPLEQ_ goes back to 97. STAILQ goes back to 96. NetB

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
Le Sat, Dec 26, 2020 at 06:55:09PM +0100, Mark Kettenis a écrit : > > Date: Sat, 26 Dec 2020 18:39:36 +0100 > > From: Denis Fondras > > > > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > > w

Improve vi(1) recovery

2020-12-26 Thread trondd
While investigating an occasional crash when recovering a file with 'vi -r' after a power failure, I noticed that the recovery files are actually never updated during an editing session. The recovery files are created upon initial modification of the file which saves the state of the file at the

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Mark Kettenis
> Date: Sat, 26 Dec 2020 18:39:36 +0100 > From: Denis Fondras > > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Denis Fondras wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > > t

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
> This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > with FreeBSD and Linux. More than half the stuff being touched doesn't exist in FreeBSD or Linux. SIMPLEQ_ goes back to 97. Why is this the direction to go??? Denis, you appear to be making an arbitrary decision and not

Re: unwind.conf.5: default preference list

2020-12-26 Thread Florian Obser
sure On 26 December 2020 17:51:08 CET, Klemens Nanni wrote: > >I think the manual is behind: > > $ unwind -nvf/dev/null > preference { DoT oDoT-forwarder forwarder recursor oDoT-dhcp dhcp stub >} > >OK? > > >Index: unwind.conf.5 >===

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Martin Pieuchot wrote: > On 26/12/20(Sat) 18:23, Mark Kettenis wrote: > > [...] > > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > > removing one in favour of the other is helpful. > > It would be helpful to provide both set of macros for some time to ease > the transiti

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > > > FreeBSD and Linux. > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > they will > > > be removed as soon a

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Martin Pieuchot
On 26/12/20(Sat) 18:23, Mark Kettenis wrote: > [...] > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > removing one in favour of the other is helpful. It would be helpful to provide both set of macros for some time to ease the transition/conversion. Then we can decide if w

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Mark Kettenis
> Date: Sat, 26 Dec 2020 16:40:15 +0100 > From: Christian Weisgerber > > Denis Fondras: > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > > FreeBSD and Linux. > > > > I added aliases at the end of queue.h to avoid breaking base too much. they > > will > > be re

unwind.conf.5: default preference list

2020-12-26 Thread Klemens Nanni
I think the manual is behind: $ unwind -nvf/dev/null preference { DoT oDoT-forwarder forwarder recursor oDoT-dhcp dhcp stub } OK? Index: unwind.conf.5 === RCS file: /cvs/src/sbin/unwind/unwind.conf.5,v retrieving

make.1: sync variable substitution bits with NetBSD

2020-12-26 Thread Klemens Nanni
Our make(1) is behind NetBSD's and FreeBSD's make(1) on at least the rules of variable substitution. Our DESCRIPION says There are seven different types of lines in a makefile: dependency lines, shell commands, variable assignments, include statements, conditional directives, for l

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Christian Weisgerber
Denis Fondras: > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > FreeBSD and Linux. > > I added aliases at the end of queue.h to avoid breaking base too much. they > will > be removed as soon as diff 2,3,4,5,6,7 are commited. We'll need to run a ports bulk build wit

Re: ksh(1): '[' and ']' chars disturbing substitution?

2020-12-26 Thread Alessandro De Laurenzis
Hello Andreas, Got the point, thanks a lot for your feedback. Cheers On 26/12/2020 16:04, Andreas Kusalananda Kähäri wrote: On Sat, Dec 26, 2020 at 01:29:58PM +0100, Alessandro De Laurenzis wrote: Greetings, While extracting the first two characters from a string I noticed the following: $

Re: ksh(1): '[' and ']' chars disturbing substitution?

2020-12-26 Thread Andreas Kusalananda Kähäri
On Sat, Dec 26, 2020 at 01:29:58PM +0100, Alessandro De Laurenzis wrote: > Greetings, > > While extracting the first two characters from a string I noticed the > following: > > > $ str="-- foo bar blahblahblah" > > $ echo "First 2 chars: ${str%${str#??}}" > > First 2 chars: -- > > $ str="-- foo b

ksh(1): '[' and ']' chars disturbing substitution?

2020-12-26 Thread Alessandro De Laurenzis
Greetings, While extracting the first two characters from a string I noticed the following: $ str="-- foo bar blahblahblah" $ echo "First 2 chars: ${str%${str#??}}" First 2 chars: -- $ str="-- foo bar blahblahblah [foo]" $ echo "First 2 chars: ${str%${str#??}}" First 2 chars: -- foo bar blahb

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Todd C . Miller
I read through all the diffs and they look fine to me. My only comment is that it would be nice if the whitespace changes to queue.h were done separately as they makes it more difficult to see the important changes. I was pleasntly surprised to find the nothing in the tree reaches into the data s

Rename SIMPLEQ_ to STAILQ_, diff 6/7 (usr.bin)

2020-12-26 Thread Denis Fondras
Rename SIMPLEQ_* to STAILQ_* in /usr/src/usr.bin Index: ctfconv/dw.c === RCS file: /cvs/src/usr.bin/ctfconv/dw.c,v retrieving revision 1.4 diff -u -p -r1.4 dw.c --- ctfconv/dw.c27 Sep 2017 08:59:38 - 1.4 +++ ctfconv/d

Rename SIMPLEQ_ to STAILQ_, diff 5/7 (usr.sbin)

2020-12-26 Thread Denis Fondras
Rename SIMPLEQ_* to STAILQ_* in /usr/src/usr.sbin Index: bgpd/bgpd.c === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.c,v retrieving revision 1.230 diff -u -p -r1.230 bgpd.c --- bgpd/bgpd.c 5 Nov 2020 11:52:59 - 1.230 +++ bgpd/bgpd

Rename SIMPLEQ_ to STAILQ_, diff 7/7 (man+regress)

2020-12-26 Thread Denis Fondras
Rename SIMPLEQ_* to STAILQ_* in /usr/src/share and /usr/src/regress Index: regress/usr.sbin/bgpd/unittests/rde_sets_test.c === RCS file: /cvs/src/regress/usr.sbin/bgpd/unittests/rde_sets_test.c,v retrieving revision 1.7 diff -u -p -r1

Rename SIMPLEQ_ to STAILQ_, diff 4/7 (sbin)

2020-12-26 Thread Denis Fondras
Rename SIMPLEQ_* to STAILQ_* in /usr/src/sbin Index: iked/iked.h === RCS file: /cvs/src/sbin/iked/iked.h,v retrieving revision 1.179 diff -u -p -r1.179 iked.h --- iked/iked.h 21 Dec 2020 22:49:36 - 1.179 +++ iked/iked.h 25 De

Rename SIMPLEQ_ to STAILQ_, diff 3/7 (lib)

2020-12-26 Thread Denis Fondras
Rename SIMPLEQ_ to STAILQ_ in /usr/src/lib Index: libc/gen/posix_spawn.c === RCS file: /cvs/src/lib/libc/gen/posix_spawn.c,v retrieving revision 1.10 diff -u -p -r1.10 posix_spawn.c --- libc/gen/posix_spawn.c 28 Jun 2019 13:32:41

Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
mpi@ reminded me I had this diff cooking. This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with FreeBSD and Linux. I added aliases at the end of queue.h to avoid breaking base too much. they will be removed as soon as diff 2,3,4,5,6,7 are commited. net/sniproxy has a patch t

Re: kern.video.record - part 2

2020-12-26 Thread Matthias Schmidt
Hi Marcus, * Marcus Glocker wrote: > Thanks for testing Laurie. > > Otherwise I got not much feedback -- No interest in this? Yes, sure. I really like the feature since it offers an additional level of privacy when /dev/video* is not owned by root and is a perfect supplement to kern.audio.recor