Re: monotonic time going back by wrong skews

2021-03-26 Thread Stefmorino
> Feel free to share your raw data. Also includes some standard sendbug dumps: https://0x0.st/-qng.tgz

Re: cwfg: flag sensor as invalid on bogus reads

2021-03-26 Thread Patrick Wildt
Am Sat, Mar 27, 2021 at 12:00:32AM +0100 schrieb Klemens Nanni: > On Fri, Mar 26, 2021 at 11:22:32PM +0100, Patrick Wildt wrote: > > It's pretty normal for voltage to go up once AC is connected. In the > > end, afaik batteries are charged by applying voltage. Additionally > > if an external suppl

Re: efiboot/arm64: fix "mach dtb" return code to avoid bogus boot

2021-03-26 Thread Patrick Wildt
Am Sat, Mar 27, 2021 at 12:09:25AM +0100 schrieb Klemens Nanni: > On Fri, Mar 26, 2021 at 11:28:37PM +0100, Patrick Wildt wrote: > > > fdt = (void *)addr; > > > - return (0); > > > + return (1); > > > > Wait, you've been saying that return code 1 makes it boot. So now you > > changed it so that

Re: efiboot/arm64: fix "mach dtb" return code to avoid bogus boot

2021-03-26 Thread Klemens Nanni
On Fri, Mar 26, 2021 at 11:28:37PM +0100, Patrick Wildt wrote: > > fdt = (void *)addr; > > - return (0); > > + return (1); > > Wait, you've been saying that return code 1 makes it boot. So now you > changed it so that "mach dtb" kicks of booting the kernel? That does > not seem tight to

Re: cwfg: flag sensor as invalid on bogus reads

2021-03-26 Thread Klemens Nanni
On Fri, Mar 26, 2021 at 11:22:32PM +0100, Patrick Wildt wrote: > It's pretty normal for voltage to go up once AC is connected. In the > end, afaik batteries are charged by applying voltage. Additionally > if an external supply provides power, there's a smaller voltage drop. I thought as much, tha

Re: apm/arm64: fix errno, merge ioctl cases

2021-03-26 Thread Patrick Wildt
Am Sat, Mar 20, 2021 at 08:01:51PM +0100 schrieb Klemens Nanni: > The EBADF error is always overwritten for the standby, suspend and > hibernate ioctls, only the mode ioctl has it right. > > Merge the now identical casese while here. > > Tested on a Pinebook Pro. > > OK? ok patrick@ > Index: a

Re: efiboot/arm64: fix "mach dtb" return code to avoid bogus boot

2021-03-26 Thread Patrick Wildt
Am Wed, Mar 24, 2021 at 07:20:29PM +0100 schrieb Klemens Nanni: > Bootloader command functions must return zero in case of failure, > returning 1 tells the bootloader to boot the file. > > arm64's `machine dtb' command has it the wrong way so using it triggers > a boot that doesn't make any sense:

Re: cwfg: flag sensor as invalid on bogus reads

2021-03-26 Thread Patrick Wildt
Am Fri, Mar 26, 2021 at 12:26:51AM +0100 schrieb Klemens Nanni: > Follow-up to "arm64: make cwfg(4) report battery information to apm(4)". > > This driver continues to report stale hw.sensors values when reading > them fails, which can easily be observed on a Pinebook Pro after > plugging in the A

Re: apmd/apm: propagate failure to apm, make apm report failure

2021-03-26 Thread Klemens Nanni
On Fri, Mar 26, 2021 at 10:38:30PM +0100, Klemens Nanni wrote: > apm(8) never knows gets the result of the requested power action carried > out by apmd(8), so platforms without suspend/resume support behave like > this: > > $ zzz; echo $? > Suspending system... > 0 > $ apm

apmd/apm: propagate failure to apm, make apm report failure

2021-03-26 Thread Klemens Nanni
apm(8) never knows gets the result of the requested power action carried out by apmd(8), so platforms without suspend/resume support behave like this: $ zzz; echo $? Suspending system... 0 $ apm -z; echo $? System will enter suspend mode momentarily.

xf86-input-ws: fix hotplugging usb mice on legacy-free machines

2021-03-26 Thread joshua stein
The X server's autoconfiguration probes each /dev/wsmouseN device and if its WSMOUSEIO_GTYPE ioctl returns something like WSMOUSE_TYPE_TOUCHPAD, xf86-input-ws attaches to that device directly which causes the wsmouse device to detach from the mux. This allows xinput to handle these special dev

Re: vmd(8): fix packet handling for dhcpleased(8)

2021-03-26 Thread Dave Voutila
Dave Voutila writes: > tech@, > > While migrating an existing -current vm to use dhcpleased(8), one of the > issues discovered was the dhcp/bootp handling built into vmd(8) for > local interfaces was improperly missing packets sent to the ethernet > address of the host-side tap(4) device. (vmd(8

Re: update explicit_bzero test to not assume SIGSTKSZ to be constant

2021-03-26 Thread Alexander Bluhm
On Mon, Mar 22, 2021 at 08:38:23PM -0500, Brent Cook wrote: > In the next version of Linux glibc, SIGSTKSZ is defined at runtime if > source is built with _GNU_SOURCE. On LibreSSL-portable, this is set to > bring in asprintf/vasprintf, which causes the explicit_bzero test to > fail to compile since

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-26 Thread Alexander Bluhm
On Fri, Mar 26, 2021 at 11:00:22AM +, Schreilechner, Dominik wrote: > --- a/sys/netinet/ip_output.c > +++ b/sys/netinet/ip_output.c > @@ -765,6 +765,11 @@ ip_insertoptions(struct mbuf *m, struct mbuf *opt, int > *phlen) > optlen = opt->m_len - sizeof(p->ipopt_dst); > if (optlen

Re: rpki-client compare file path properly

2021-03-26 Thread Theo Buehler
On Fri, Mar 26, 2021 at 03:38:54PM +0100, Claudio Jeker wrote: > Not sure on what I was tripping when writing filepathcmp() but it makes no > sense to use strcasecmp() there. It compares paths in the filesystem and > these are case-sensitive. ok > > -- > :wq Claudio > > Index: main.c > ===

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread YASUOKA Masahiko
On Fri, 26 Mar 2021 12:12:44 +0100 (CET) Mark Kettenis wrote: >> Date: Fri, 26 Mar 2021 19:43:23 +0900 (JST) >> From: YASUOKA Masahiko >> >> Hi, >> >> On Fri, 26 Mar 2021 09:30:43 +0100 >> Jan Klemkow wrote: >> > If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader >> > wil

rpki-client compare file path properly

2021-03-26 Thread Claudio Jeker
Not sure on what I was tripping when writing filepathcmp() but it makes no sense to use strcasecmp() there. It compares paths in the filesystem and these are case-sensitive. -- :wq Claudio Index: main.c === RCS file: /cvs/src/usr.sb

Re: fix ospf6d.conf example

2021-03-26 Thread Daniel Jakots
On Fri, 26 Mar 2021 09:36:13 +0100, Remi Locherer wrote: > Hi, > > danj@ noticed that our ospf6d.conf example is using multiple areas. > In the man page of ospf6d we state that multi area support is not > available. The daemon accepts such a config but does not do the right > thing if I remember

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread Patrick Wildt
Am Fri, Mar 26, 2021 at 12:12:44PM +0100 schrieb Mark Kettenis: > > Date: Fri, 26 Mar 2021 19:43:23 +0900 (JST) > > From: YASUOKA Masahiko > > > > Hi, > > > > On Fri, 26 Mar 2021 09:30:43 +0100 > > Jan Klemkow wrote: > > > If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader

Re: mpe, mpip, mpw: Only install route with label, fix leak on destroy

2021-03-26 Thread Claudio Jeker
On Fri, Mar 26, 2021 at 01:16:32PM +0100, Klemens Nanni wrote: > On Wed, Mar 17, 2021 at 04:47:36PM +0100, Klemens Nanni wrote: > > `ifconfig mp* mplslabel N' validates the label both in ifconfig and each > > driver's ioctl handler, but there is one case where all drivers install > > a route withou

fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread Jan Klemkow
Hi, If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader will hang while loading the kernel. Because, the UEFI loads the bootloader on the same place in memory, where the bootloader will copy the kernel. We are unable to load the kernel on arbitrary memory. Thus, the followin

Re: mpe, mpip, mpw: Only install route with label, fix leak on destroy

2021-03-26 Thread Klemens Nanni
On Wed, Mar 17, 2021 at 04:47:36PM +0100, Klemens Nanni wrote: > `ifconfig mp* mplslabel N' validates the label both in ifconfig and each > driver's ioctl handler, but there is one case where all drivers install > a route without looking at the label at all. > > SIOCSLIFPHYRTABLE in all three driv

Re: disable PPP_BSDCOMP by default

2021-03-26 Thread Balder Oddson
On Thu, Mar 25, 2021 at 08:46:10PM -0600, Theo de Raadt wrote: > Balder Oddson wrote: > > > On Thu, Mar 25, 2021 at 03:40:15PM -0600, Theo de Raadt wrote: > > > Stuart Henderson wrote: > > > > > > > > Not having read the code, case in point on principle, I'm arguing that > > > > > there should

Re: vmctl: off-by-one error handling mixing -a with a VM id

2021-03-26 Thread Theo Buehler
On Fri, Mar 26, 2021 at 07:24:32AM -0400, Dave Voutila wrote: > > Theo Buehler writes: > > > On Thu, Mar 25, 2021 at 08:07:53PM +0100, Preben Guldberg wrote: > >> Dave Voutila wrote: > >> > Preben Guldberg writes: > >> > > The patch below addresses an off-by-one error reading argv when > >> > > g

Re: Fix iwx wrong ac indexs.

2021-03-26 Thread zxystd
OK. seems it is the only reason why I can see the difference. Thank you. ---Original--- From: "Stefan Sperling"

Re: vmctl: off-by-one error handling mixing -a with a VM id

2021-03-26 Thread Dave Voutila
Dave Voutila writes: > Theo Buehler writes: > >> On Thu, Mar 25, 2021 at 08:07:53PM +0100, Preben Guldberg wrote: >>> Dave Voutila wrote: >>> > Preben Guldberg writes: >>> > > The patch below addresses an off-by-one error reading argv when >>> > > generating the error message. >>> >>> > > I pers

Re: vmctl: off-by-one error handling mixing -a with a VM id

2021-03-26 Thread Dave Voutila
Theo Buehler writes: > On Thu, Mar 25, 2021 at 08:07:53PM +0100, Preben Guldberg wrote: >> Dave Voutila wrote: >> > Preben Guldberg writes: >> > > The patch below addresses an off-by-one error reading argv when >> > > generating the error message. >> >> > > I personally find it clearer if the co

Re: vmd(8) support for gzipped kernels

2021-03-26 Thread Klemens Nanni
On Fri, Mar 26, 2021 at 07:17:26AM -0400, Dave Voutila wrote: > There was a follow-up diff changing some includes, but I'd like to keep > that cleanup separate. As i mentioned in the other reply, this change > works for me and I worked with Josh on the bugs@ thread to arrive at > this diff. I agree

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-26 Thread Alexandr Nedvedicky
Hello, > > You missed the initialization of ipsendraw_mq. Otherwise, ICMP with and > without IP options work for me with the diff. > > I don't know how this is usually handled here and it is probably a bit > nit-picky, but I introduced a new function to remove the duplicate code > in ip_send_dis

Re: vmd(8) support for gzipped kernels

2021-03-26 Thread Dave Voutila
Josh Rickmar writes: > Here's an updated version of the patch I had originally posted to > bugs@ adding support for reading gzipped kernels (needed to boot amd64 > bsd.rd without manually decompressing first), now that the support for > booting a kernel discovered on a ffs filesystem in the imag

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread Mark Kettenis
> Date: Fri, 26 Mar 2021 19:43:23 +0900 (JST) > From: YASUOKA Masahiko > > Hi, > > On Fri, 26 Mar 2021 09:30:43 +0100 > Jan Klemkow wrote: > > If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader > > will hang while loading the kernel. Because, the UEFI loads the > > bootlo

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-26 Thread Schreilechner, Dominik
> -Original Message- > From: Alexandr Nedvedicky > Sent: Donnerstag, 25. März 2021 17:36 > To: Schreilechner, Dominik (RC-AT DI FA DH-GRAZ ICO) > > Cc: tech@openbsd.org > Subject: Re: [External] : [ICMP] IP options lead to malformed reply > > Hello, > > > > > 1) ip_insertoptions()

Re: fyi: get HP EliteBook 830 G7/G8 booting

2021-03-26 Thread YASUOKA Masahiko
Hi, On Fri, 26 Mar 2021 09:30:43 +0100 Jan Klemkow wrote: > If you want to boot OpenBSD on an HP EliteBook 830 G7/G8, the bootloader > will hang while loading the kernel. Because, the UEFI loads the > bootloader on the same place in memory, where the bootloader will copy > the kernel. We are un

Re: rpki-client cleanup poll loop

2021-03-26 Thread Claudio Jeker
On Fri, Mar 26, 2021 at 10:37:27AM +0100, Theo Buehler wrote: > On Fri, Mar 26, 2021 at 09:52:04AM +0100, Claudio Jeker wrote: > > This diff replaces mostly the same code in the poll loop with a for loop. > > It also gives a hint which process closed a connection. > > This is much nicer. Would the

Re: rpki-client cleanup poll loop

2021-03-26 Thread Theo Buehler
On Fri, Mar 26, 2021 at 09:52:04AM +0100, Claudio Jeker wrote: > This diff replaces mostly the same code in the poll loop with a for loop. > It also gives a hint which process closed a connection. This is much nicer. Would the msgbuf_write() errors not benefit from the same hint? ok tb > > --

Re: uvideo(4) new quirk flag UVIDEO_FLAG_NOATTACH

2021-03-26 Thread Martijn van Duren
I'm in no way qualified to OK this, but I'd like to see this get in, because it does help me out :-) martijn@ On Mon, 2021-03-15 at 08:35 +0100, Marcus Glocker wrote: > martijn@ has recently reported that in his machine he has two cams > of which one is doing IR, which isn't really supported by u

rpki-client cleanup poll loop

2021-03-26 Thread Claudio Jeker
This diff replaces mostly the same code in the poll loop with a for loop. It also gives a hint which process closed a connection. -- :wq Claudio Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision

Re: fix ospf6d.conf example

2021-03-26 Thread Claudio Jeker
On Fri, Mar 26, 2021 at 09:36:13AM +0100, Remi Locherer wrote: > Hi, > > danj@ noticed that our ospf6d.conf example is using multiple areas. > In the man page of ospf6d we state that multi area support is not > available. The daemon accepts such a config but does not do the right > thing if I reme

fix ospf6d.conf example

2021-03-26 Thread Remi Locherer
Hi, danj@ noticed that our ospf6d.conf example is using multiple areas. In the man page of ospf6d we state that multi area support is not available. The daemon accepts such a config but does not do the right thing if I remember correctly. OK to change the example to use just one area? Remi Inde

Re: vmd(8): fix packet handling for dhcpleased(8)

2021-03-26 Thread Florian Obser
On Thu, Mar 25, 2021 at 04:36:04PM -0400, Dave Voutila wrote: > > Florian Obser writes: > > Our lease is however still valid, so everything "just works". > > > > Maybe the problem is with the send request command. I don't know yet > > what to do with it. Maybe it should transition to INIT state. T