Re: httpd(8): don't try to chunk-encode an empty body

2021-05-17 Thread Florian Obser
On 2021-05-18 00:47 +02, Sebastian Benoit wrote: > The comments in server_fcgi_header seem to suggest more dragons lurk in this > area. Sush! -- I'm not entirely sure you are real.

httpd(8): login/logout delay on WordPress sites after May 17 patch

2021-05-17 Thread Matthias Pressfreund
After the May 17 httpd(8) patch, logging in and logging out of the admin interface of WordPress sites is delayed by 1 minute. The site itself appears normally and there are no entries in the error log.

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-17 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2021.05.15 17:14:38 +0200: > Turns out it's not that difficult to do this correctly since we already > wait until we read all http headers from the fcgi upstream. We just need > to delay writing of the http header until we know if the body is empty > or not. >

Re: [External] : Re: parallel forwarding vs. bridges

2021-05-17 Thread Alexandr Nedvedicky
Hello, On Mon, May 17, 2021 at 08:19:37PM +0200, Alexander Bluhm wrote: > On Mon, May 17, 2021 at 04:24:15PM +0200, Alexandr Nedvedicky wrote: > > in current tree the ether_input() is protected by NET_LOCK(), which is > > grabbed > > by caller as a writer. bluhm's diff changes NET_LOCK() readlock

Re: [External] : Re: parallel forwarding vs. bridges

2021-05-17 Thread Alexandr Nedvedicky
On Mon, May 17, 2021 at 08:27:12PM +0200, Martin Pieuchot wrote: > On 17/05/21(Mon) 19:52, Alexandr Nedvedicky wrote: > > [...] > > I don't mind to trade pf_lock and pf_state_lock for mutexes, however > > I see such step is kind of 'NO-OP'. We do have sufficient measure > > currently, which is: ke

Re: ftpd(8): remove useless parameter of get_line()

2021-05-17 Thread Chris Cappuccio
Jan Klemkow [j.klem...@wemelug.de] wrote: > Hi, > > This diff removes the useless FILE* parameter of get_line(). In every > call this parameter is always "stdin". Thus, we can replace ever use of > the variable iop with stdin. > > Like every other diff, I tested this diff with the ftpd regressi

Re: [External] : Re: parallel forwarding vs. bridges

2021-05-17 Thread Martin Pieuchot
On 17/05/21(Mon) 19:52, Alexandr Nedvedicky wrote: > [...] > I don't mind to trade pf_lock and pf_state_lock for mutexes, however > I see such step is kind of 'NO-OP'. We do have sufficient measure > currently, which is: keep NET_LOCK() as is. May be I'm not seeing > your idea/plan behind changing

Re: parallel forwarding vs. bridges

2021-05-17 Thread Alexander Bluhm
On Mon, May 17, 2021 at 04:24:15PM +0200, Alexandr Nedvedicky wrote: > in current tree the ether_input() is protected by NET_LOCK(), which is grabbed > by caller as a writer. bluhm's diff changes NET_LOCK() readlock, so > ether_input() can run concurrently. Switching NET_LOCK() to r-lock has > impl

Re: [External] : Re: parallel forwarding vs. bridges

2021-05-17 Thread Alexandr Nedvedicky
Hello, On Mon, May 17, 2021 at 06:59:36PM +0200, Martin Pieuchot wrote: > On 17/05/21(Mon) 16:24, Alexandr Nedvedicky wrote: > > Hrvoje, > > > > managed to trigger diagnostic panics with diff [1] sent by bluhm@ > > some time ago. The panic Hrvoje sees comes from ether_input() here: > > > > 414

Re: parallel forwarding vs. bridges

2021-05-17 Thread Hrvoje Popovski
On 17.5.2021. 16:24, Alexandr Nedvedicky wrote: > Hrvoje, > > managed to trigger diagnostic panics with diff [1] sent by bluhm@ > some time ago. The panic Hrvoje sees comes from ether_input() here: > [1] https://marc.info/?l=openbsd-tech&m=161903387904923&w=2 > > [2] https://marc.info/?l=openbsd

Re: parallel forwarding vs. bridges

2021-05-17 Thread Martin Pieuchot
On 17/05/21(Mon) 16:24, Alexandr Nedvedicky wrote: > Hrvoje, > > managed to trigger diagnostic panics with diff [1] sent by bluhm@ > some time ago. The panic Hrvoje sees comes from ether_input() here: > > 414 > 415 /* > 416 * Third phase: bridge processing. > 417 *

Re: httpd with rdomain

2021-05-17 Thread Theo de Raadt
Claudio Jeker wrote: > I don't think httpd should handle rdomain in its config but instead you > should run multiple httpd processes one for each rdomain. > Not every daemon needs to support running in multiple rdomains at once. I agree with you Claudio. This in particular is what lost me: > >

Re: httpd with rdomain

2021-05-17 Thread Peter J. Philipp
On Mon, May 17, 2021 at 05:55:00PM +0200, Claudio Jeker wrote: [..] > > Granted I did not test it with a difficult config. And I advise any > > committer > > to test this fully before trusting my code. For me it's better than using > > route and starting httpd twice, though. > > > > I don't th

Re: httpd with rdomain

2021-05-17 Thread Claudio Jeker
On Mon, May 17, 2021 at 05:11:41PM +0200, Peter J. Philipp wrote: > Hi, > > I found myself wanting this, this morning. I made a patch but then I put it > in the wrong spot, and noticed it needed rewriting of SERVER in parse.y. > Later in the day I found myself looking into this, and a better patc

httpd with rdomain

2021-05-17 Thread Peter J. Philipp
Hi, I found myself wanting this, this morning. I made a patch but then I put it in the wrong spot, and noticed it needed rewriting of SERVER in parse.y. Later in the day I found myself looking into this, and a better patch came out of it. It works on a simple setup for me (mind the censored IPv6

Re: reposync error

2021-05-17 Thread Hrvoje Popovski
On 17.5.2021. 13:55, Theo Buehler wrote: > On Mon, May 17, 2021 at 11:24:25AM +0200, Hrvoje Popovski wrote: >> Hi all, >> >> today after sysupgrade i' getting this error with reposync >> >> r620-1# su -m cvs -c "reposync -s src rsync://ftp.hostserver.de/cvs >> /home/cvs" >> reposync: rsync error: r

parallel forwarding vs. bridges

2021-05-17 Thread Alexandr Nedvedicky
Hrvoje, managed to trigger diagnostic panics with diff [1] sent by bluhm@ some time ago. The panic Hrvoje sees comes from ether_input() here: 414 415 /* 416 * Third phase: bridge processing. 417 * 418 * Give the packet to a bridge interface, ie, bridge(4),

Re: reposync error

2021-05-17 Thread Theo Buehler
On Mon, May 17, 2021 at 11:24:25AM +0200, Hrvoje Popovski wrote: > Hi all, > > today after sysupgrade i' getting this error with reposync > > r620-1# su -m cvs -c "reposync -s src rsync://ftp.hostserver.de/cvs > /home/cvs" > reposync: rsync error: rsync: did not see server greeting > rsync error:

Re: services(5): more cleanup

2021-05-17 Thread Craig Skinner
On Sun, 16 May 2021 01:11:51 + Aisha Tammy wrote: > I have a few machines which use something to the effect of `pass in on > egress proto tcp to port smtps ...`. > A quick question, does this mean that the port in pf.conf will also > have to be renamed? From experience doing the same Aisha, #

uao_dropswap_range()

2021-05-17 Thread Martin Pieuchot
Diff below makes use of uao_dropswap_range() in uao_free() instead of duplicating it. This function has been imported from NetBSD along with TMPFS. I'd like to use it to reduce the difference with their tree and reduce the size of my upcoming `vmobjlock' diff. ok? Index: uvm/uvm_aobj.c

Re: running network stack forwarding in parallel

2021-05-17 Thread Martin Pieuchot
On 16/05/21(Sun) 15:56, Vitaliy Makkoveev wrote: > > > > On 14 May 2021, at 14:43, Martin Pieuchot wrote: > > > > On 13/05/21(Thu) 14:50, Vitaliy Makkoveev wrote: > >> On Thu, May 13, 2021 at 01:15:05PM +0200, Hrvoje Popovski wrote: > >>> On 13.5.2021. 1:25, Vitaliy Makkoveev wrote: > It s

reposync error

2021-05-17 Thread Hrvoje Popovski
Hi all, today after sysupgrade i' getting this error with reposync r620-1# su -m cvs -c "reposync -s src rsync://ftp.hostserver.de/cvs /home/cvs" reposync: rsync error: rsync: did not see server greeting rsync error: error starting client-server protocol (code 5) at main.c(1814) [Receiver=3.2.3]