Re: Do not spin on the NET_LOCK() in kqueue

2021-07-25 Thread Martin Pieuchot
On 21/07/21(Wed) 10:18, Martin Pieuchot wrote: > On 11/07/21(Sun) 14:45, Visa Hankala wrote: > > On Sat, Jul 10, 2021 at 05:26:57PM +0200, Martin Pieuchot wrote: > > > One of the reasons for the drop of performances in the kqueue-based > > > poll/select is the fact that kqueue filters are called up

OpenBSD Errata: July 25, 2021 (libc, mips64)

2021-07-25 Thread Sebastian Benoit
An errata patch for the libc library on the mips64 architecture has been released for OpenBSD 6.8 and OpenBSD 6.9. On mips64, the strchr/index/strrchr/rindex functions in libc handled signed characters incorrectly. Source code patches can be found on the respective errata pages: https://www.

Re: OpenBSD Errata: July 25, 2021 (relayd)

2021-07-25 Thread Gabriel
Sebastian Benoit writes: > An errata patch for the relayd application layer gateway daemon has > been released for OpenBSD 6.9. > > relayd(8), when using the the http protocol strip filter directive or http > protocol macro expansion, processes format strings. > > Binary updates for the amd64, i3

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Theo de Raadt
Scott Cheloha wrote: > Given this, I want to tell the reader, roughly: > > "hey! it's plausible there is a SIGALRM-based sleep() implementation >using still floating around out there in the wild. If you find one, >you'll want to avoid using it because there are unfixable

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Scott Cheloha
On Sun, Jul 25, 2021 at 05:21:19PM -0600, Theo de Raadt wrote: > Scott Cheloha wrote: > > > On Sun, Jul 25, 2021 at 01:35:19PM -0600, Theo de Raadt wrote: > > > This is a lot of fuss. > > > > > > How many bugs have you found relating to this issue? > > > > > > Let me guess: zero? > > > > Right

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Theo de Raadt
Scott Cheloha wrote: > On Sun, Jul 25, 2021 at 01:35:19PM -0600, Theo de Raadt wrote: > > This is a lot of fuss. > > > > How many bugs have you found relating to this issue? > > > > Let me guess: zero? > > Right, that's why I'm asking if we need to make a portability > recommendation at all. >

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Scott Cheloha
On Sun, Jul 25, 2021 at 01:35:19PM -0600, Theo de Raadt wrote: > This is a lot of fuss. > > How many bugs have you found relating to this issue? > > Let me guess: zero? Right, that's why I'm asking if we need to make a portability recommendation at all. We could also say something like:

Re: usertc: small consistency tweaks

2021-07-25 Thread Jeremie Courreges-Anglas
cc'ing cheloha@ since he probably cares about this. On Sun, Jul 25 2021, Mark Kettenis wrote: >> From: Jeremie Courreges-Anglas >> Date: Sun, 25 Jul 2021 04:31:20 +0200 >> >> On Sat, Jul 24 2021, Mark Kettenis wrote: >> >> From: Jeremie Courreges-Anglas >> >> Date: Sat, 24 Jul 2021 21:22:23

OpenBSD Errata: July 25, 2021 (relayd)

2021-07-25 Thread Sebastian Benoit
An errata patch for the relayd application layer gateway daemon has been released for OpenBSD 6.9. relayd(8), when using the the http protocol strip filter directive or http protocol macro expansion, processes format strings. Binary updates for the amd64, i386, and arm64 platform are available vi

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Jason McIntyre
On Sun, Jul 25, 2021 at 02:30:01PM -0500, Scott Cheloha wrote: > On Sun, Jul 25, 2021 at 08:15:34AM +0100, Jason McIntyre wrote: > > On Sat, Jul 24, 2021 at 10:39:49PM -0500, Scott Cheloha wrote: > > > Okay, the nanosleep.2 changes are committed, let's do sleep.3 next. > > > > hi. > > > > the cha

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Ashton Fagg
Stuart Henderson writes: > That FreeBSD commit prevents using their "hw.ahci.force" tunable on the > device, it's used for attaching as AHCI to certain known chips even if > they're set in legacy IDE mode. > > Does it work to just add the vid/pid to the ahci_devices[] array > without a specific a

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Theo de Raadt
This is a lot of fuss. How many bugs have you found relating to this issue? Let me guess: zero? Scott Cheloha wrote: > On Sun, Jul 25, 2021 at 08:15:34AM +0100, Jason McIntyre wrote: > > On Sat, Jul 24, 2021 at 10:39:49PM -0500, Scott Cheloha wrote: > > > Okay, the nanosleep.2 changes are

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Scott Cheloha
On Sun, Jul 25, 2021 at 08:15:34AM +0100, Jason McIntyre wrote: > On Sat, Jul 24, 2021 at 10:39:49PM -0500, Scott Cheloha wrote: > > Okay, the nanosleep.2 changes are committed, let's do sleep.3 next. > > hi. > > the changes read fine to me. only one comment: > > > [...] > > > > STANDARDS > >

Re: Pass "socket *" to sballoc/sbfree & co

2021-07-25 Thread Martin Pieuchot
On 24/07/21(Sat) 11:43, Martin Pieuchot wrote: > Diff below adds an extra argument, a pointer to the socket corresponding > to the buffer given to: sballoc(), sbfree(), sbcompress(), sbcheck() and > sbdroprecord(). > > This pointer will be used to assert for or grab a per-socket lock. > > There i

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Mark Kettenis
> Date: Sun, 25 Jul 2021 12:29:21 +0100 > From: Stuart Henderson > > On 2021/07/25 13:25, Mark Kettenis wrote: > > > Date: Sun, 25 Jul 2021 12:08:09 +0100 > > > From: Stuart Henderson > > > > > > On 2021/07/25 14:55, Jonathan Matthew wrote: > > > > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Asht

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Mark Kettenis
> Date: Sun, 25 Jul 2021 13:25:49 +0200 (CEST) > From: Mark Kettenis > > > Date: Sun, 25 Jul 2021 12:08:09 +0100 > > From: Stuart Henderson > > > > On 2021/07/25 14:55, Jonathan Matthew wrote: > > > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Ashton Fagg wrote: > > > > I have two devices here bas

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Stuart Henderson
On 2021/07/25 13:25, Mark Kettenis wrote: > > Date: Sun, 25 Jul 2021 12:08:09 +0100 > > From: Stuart Henderson > > > > On 2021/07/25 14:55, Jonathan Matthew wrote: > > > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Ashton Fagg wrote: > > > > I have two devices here based on the JMicron JMB585 chipse

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Mark Kettenis
> Date: Sun, 25 Jul 2021 12:08:09 +0100 > From: Stuart Henderson > > On 2021/07/25 14:55, Jonathan Matthew wrote: > > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Ashton Fagg wrote: > > > I have two devices here based on the JMicron JMB585 chipset. This diff > > > adds the required pcidev IDs and se

Re: ahci(4): Add support for JMicron JMB585 chipset

2021-07-25 Thread Stuart Henderson
On 2021/07/25 14:55, Jonathan Matthew wrote: > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Ashton Fagg wrote: > > I have two devices here based on the JMicron JMB585 chipset. This diff > > adds the required pcidev IDs and sets disables native command queuing in > > the driver. FreeBSD does something

Re: usertc: small consistency tweaks (was: Re: riscv64 usertc)

2021-07-25 Thread Mark Kettenis
> From: Jeremie Courreges-Anglas > Date: Sun, 25 Jul 2021 04:31:20 +0200 > > On Sat, Jul 24 2021, Mark Kettenis wrote: > >> From: Jeremie Courreges-Anglas > >> Date: Sat, 24 Jul 2021 21:22:23 +0200 > >> > >> hifive /usr/src/regress/sys/kern/gettimeofday$ doas -u build time > >> obj/gettimeofd

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-25 Thread Jason McIntyre
On Sat, Jul 24, 2021 at 10:39:49PM -0500, Scott Cheloha wrote: > Okay, the nanosleep.2 changes are committed, let's do sleep.3 next. > hi. the changes read fine to me. only one comment: > Here's a changelist by section. I have some questions in there at end > of sections where I'm unsure about