Re: Add versioned lib to system perl's @INC for non-packaged modules

2021-07-30 Thread Andrew Hewus Fresh
Below is the corrected patch for this, but it's not quite ready yet. See the email over on ports@ with some adjustments to perl.port.mk and other patches to fix some ports fallout that sthen@ was super helpful in tracking down. The main issue was that somehow I lost a quote in the patch and so it

Re: time.3: miscellaneous cleanup and rewrites

2021-07-30 Thread Todd C . Miller
On Fri, 30 Jul 2021 13:01:21 -0500, Scott Cheloha wrote: > NAME > > - get "the" time of day. I don't like having "the" in there. I'd suggest leaving this as it is or simply shortening to either "get time" or "get the time". > SYNOPSIS > > - Not a fan of the "tloc" variable name. Use "now" as

Re: time.3: miscellaneous cleanup and rewrites

2021-07-30 Thread Jason McIntyre
On Fri, Jul 30, 2021 at 01:01:21PM -0500, Scott Cheloha wrote: > Next up, time.3. > > As before, changes by section, with "I don't knows" at the end of the > change list in each section. > hi. comments inline: > NAME > > - get "the" time of day. > > SYNOPSIS > > - Not a fan of the "tloc"

time.3: miscellaneous cleanup and rewrites

2021-07-30 Thread Scott Cheloha
Next up, time.3. As before, changes by section, with "I don't knows" at the end of the change list in each section. NAME - get "the" time of day. SYNOPSIS - Not a fan of the "tloc" variable name. Use "now" as we do in other pages to reinforce the meaning of its contents. DESCRIPTION -

Re: [please test] amd64: schedule clock interrupts against system clock

2021-07-30 Thread Alexander Bluhm
On Mon, Jul 26, 2021 at 08:12:39AM -0500, Scott Cheloha wrote: > On Fri, Jun 25, 2021 at 06:09:27PM -0500, Scott Cheloha wrote: > 1 month bump. I really appreciate the tests I've gotten so far, thank > you. On my Xeon machine it works and all regress tests pass. But it fails on my old Opteron

Re: gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Theo de Raadt
Todd C. Miller wrote: > I really don't like "get or set the UTC time" in the NAME section. > It's not like we have a "get or set the local time" function. > I would prefer if you left the UTC information for the DESCRIPTION. I agree. Excessive obvious detail detracts from simple points.

Re: gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Todd C . Miller
On Fri, 30 Jul 2021 11:48:27 -0500, Scott Cheloha wrote: > Sure, changed to "get or set the time of day". > > FWIW, the clock_gettime(2) one-liner is "get or set the time". Thanks. > > Instead of saying that settimeofday ignores tz if not NULL why not > > just say that settimeofday ignores tz.

Re: gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Scott Cheloha
On Fri, Jul 30, 2021 at 10:01:40AM -0600, Todd C. Miller wrote: > I really don't like "get or set the UTC time" in the NAME section. > It's not like we have a "get or set the local time" function. > I would prefer if you left the UTC information for the DESCRIPTION. Sure, changed to "get or set

Re: Small nit on one of passwd(1)'s unveil(2)

2021-07-30 Thread Ricardo Mestre
Actually it does a stat(2) on it, forget about this :) On 16:46 Fri 30 Jul , Ricardo Mestre wrote: > Hi, > > _PATH_MASTERPASSWD_LOCK is opened, from libutil, with O_WRONLY|O_CREAT and > then > unlinked when not necessary anymore so it doesn't need read permissions. > > OK? > > Index:

Re: gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Todd C . Miller
I really don't like "get or set the UTC time" in the NAME section. It's not like we have a "get or set the local time" function. I would prefer if you left the UTC information for the DESCRIPTION. Instead of saying that settimeofday ignores tz if not NULL why not just say that settimeofday

Re: [CAN IGNORE] Proposal for new bc(1) and dc(1)

2021-07-30 Thread Gavin Howard
Whoops; I thought Theo would make the decision, and his last email made me think he might have. I am happy to help as much as I can to make the process easy for you. In the meantime, I think I will release 5.0.0 when it's ready. I'll take into account your feedback in a future release. Gavin

Small nit on one of passwd(1)'s unveil(2)

2021-07-30 Thread Ricardo Mestre
Hi, _PATH_MASTERPASSWD_LOCK is opened, from libutil, with O_WRONLY|O_CREAT and then unlinked when not necessary anymore so it doesn't need read permissions. OK? Index: local_passwd.c === RCS file:

Re: gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Jason McIntyre
On Fri, Jul 30, 2021 at 09:41:38AM -0500, Scott Cheloha wrote: > Hi, > > The Description section in this page has always bugged me. The author > chose to save space by merging the description of two different system > calls into a single paragraph. Then the rules and caveats for >

gettimeofday.2: miscellaneous cleanup and rewrites

2021-07-30 Thread Scott Cheloha
Hi, The Description section in this page has always bugged me. The author chose to save space by merging the description of two different system calls into a single paragraph. Then the rules and caveats for settimeofday() are off in a separate paragraph. Meh. I recently revised the

Re: clean iwx unused firmware dma allocation

2021-07-30 Thread Stefan Sperling
On Fri, Apr 02, 2021 at 06:26:11PM +0800, zxystd wrote: > It is not a functionality change. The firmware dma is not actually used and > it is due to ported from iwm, this patch remove this allocation. Thanks! I have committed a slightly tweaked version, renaming the final goto label only. I'm

bgpd add add-path receive support

2021-07-30 Thread Claudio Jeker
This diff implements the bit to support the receive side of RFC7911 - Advertisement of Multiple Paths in BGP. I did some basic tests and it works for me. People running route collectors should give this a try. The interaction of Add-Path and bgpctl probably needs some work. Also the MRT dumper

add /etc/dhcpleased.conf to changelist(5)

2021-07-30 Thread Bjorn Ketelaars
Watch /etc/dhcpleased.conf. OK? Index: changelist === RCS file: /cvs/src/etc/changelist,v retrieving revision 1.127 diff -u -p -r1.127 changelist --- changelist 13 Sep 2020 10:03:46 - 1.127 +++ changelist 30 Jul 2021

Re: [CAN IGNORE] Proposal for new bc(1) and dc(1)

2021-07-30 Thread Otto Moerbeek
On Thu, Jul 29, 2021 at 10:31:34PM -0600, Gavin Howard wrote: > Hello, > > At this point, because of the lack of reply, I am going to assume that > my proposal is rejected. While I am sad, I understand. > > Thank you for taking the time to consider my proposal. > > Gavin Howard > I just did