Re: [[patch]] /usr/src/regress/sys/ffs/ffs/Makefile

2021-11-26 Thread Theo de Raadt
That encourages people to setup unsafe doas.conf files. Why don't we just create user accounts as uid 0 to make this easier for everyone who wants to run regress? Edgar Pettijohn wrote: > Allow running as non-root via ${SUDO}. > > Thanks, > > > Edgar

[[patch]] /usr/src/regress/sys/ffs/ffs/Makefile

2021-11-26 Thread Edgar Pettijohn
Allow running as non-root via ${SUDO}. Thanks, Edgar Index: Makefile === RCS file: /cvs/src/regress/sys/ffs/ffs/Makefile,v retrieving revision 1.5 diff -u -p -u -r1.5 Makefile --- Makefile 16 Dec 2020 21:49:20 - 1.5 +++ Makefil

Re: Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jonathan Gray
On Fri, Nov 26, 2021 at 05:41:20PM +0100, Jan Stary wrote: > > > Stop building the kernel with -Wno-uninitialized on clang archs. > > > This hides real problems like the recently fixed uninitialised memory > > > use in pf and igc. > > > > > > [-Wsometimes-uninitialized] /sys/arch/arm/arm/cpu.c:352

Re: [External] : Re: make 'set skip on ...' dynamic

2021-11-26 Thread Alexandr Nedvedicky
Hello, On Fri, Nov 26, 2021 at 01:01:40PM +0100, Claudio Jeker wrote: > > One more thing to consider, I think the following test in pfi_set_flags(): > > > + if ((p->pfik_flags_new != p->pfik_flags) && > > + (p->pfik_flagrefs == 0)) > > +

Re: ksh: diff to add tab completion for '..'

2021-11-26 Thread Jeremy Evans
On Fri, Nov 26, 2021 at 5:57 AM Luís Henriques wrote: > On Sun, Nov 21, 2021 at 03:36:33PM +, Luís Henriques wrote: > > Hi! > > > > I always found it annoying that, in ksh, doing: > > > > $ ls .. > > > > followed by TAB doesn't allow me to list the options (i.e. show > files/dirs > > in '..

Re: ixl cksum offloading sparc64 panic

2021-11-26 Thread Theo de Raadt
> That is hard for me, to decide. My main motivation was, that It looks > a bit odd to me, that we first assemble a complete packet for network. > But, one step before sending it out, we have to parse it again, to get > some values. The packet has to be parsed because the values in the packet are

Re: ixl cksum offloading sparc64 panic

2021-11-26 Thread Theo de Raadt
This consumes a bunch extra bytes per mbuf on _all systems_, regardless of whether they have offload support or not. How many bytes? the addition of ph_eth_type adds 2 bytes misaligned before the int, so padding happens there. Everything misaligns oddly because of the struct pkthdr_pf containing

Re: Pass -U to pgrep and pkill in rc.subr(8)

2021-11-26 Thread Vincent Lee
Stuart Henderson writes: > Yes that will break a lot of existing scripts, also it is probably not needed > - rc.subr uses the process name *and arguments*, if you're > using default top options you'll only see the name, use top -C or ps to check > as there is probably more that you can match

pfkey tdb_unref error case

2021-11-26 Thread Alexander Bluhm
Hi, Using void* for temporary allocated TDB in pfkeyv2 does not make sense. It looks like this is from a time before we had TDB pools. Do not use the freeme pointer for TDB in pfkeyv2_send(). The pattern is tdb_alloc() and tdb_unref() in case of error. Replace tdb_free() in reserve_spi() with

Re: Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jan Stary
> > Stop building the kernel with -Wno-uninitialized on clang archs. > > This hides real problems like the recently fixed uninitialised memory > > use in pf and igc. > > > > [-Wsometimes-uninitialized] /sys/arch/arm/arm/cpu.c:352:6: warning: > > variable 'ci' is used uninitialized whenever 'if' c

Re: ipsec: refactor TDBF_DELETED

2021-11-26 Thread Hrvoje Popovski
On 25.11.2021. 17:13, Tobias Heider wrote: > On Thu, Nov 25, 2021 at 03:50:29PM +0100, Tobias Heider wrote: >> As discussed in the previous thread we can simplify the tdb cleanup >> code by removing the TDBF_DELETED flag and instead checking if the >> tdb was already unlinked. >> >> ok? >> > > Now

Re: ksh: diff to add tab completion for '..'

2021-11-26 Thread Luís Henriques
On Sun, Nov 21, 2021 at 03:36:33PM +, Luís Henriques wrote: > Hi! > > I always found it annoying that, in ksh, doing: > > $ ls .. > > followed by TAB doesn't allow me to list the options (i.e. show files/dirs > in '..'). I need to do add a trailing '/' to this 'ls' command in order > to h

sppp(4)/pppoe(4) - avoid endless loop in remote ip negotiation

2021-11-26 Thread Krzysztof Kanas
Hi. When remote side in sppp doesn't reply for to PPP IPCP IP-Address sppp will try to negotiate remote IP in endless loop. Instead use 10.64.64.1 + if_index as remote IP. While at it maybe it's worth to add that SPP is in RFC 1332 ? Krzysztof Kanas Index: share/man/man4/sppp.4 ===

Re: [External] : Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Alexandr Nedvedicky
Hello, On Fri, Nov 26, 2021 at 10:14:47PM +1100, Jonathan Gray wrote: > On Fri, Nov 26, 2021 at 12:04:21PM +0100, Alexandr Nedvedicky wrote: > > Hello, > > > > On Fri, Nov 26, 2021 at 04:32:59PM +1100, Jonathan Gray wrote: > > > Stop building the kernel with -Wno-uninitialized on clang archs. > >

Re: [External] : Re: make 'set skip on ...' dynamic

2021-11-26 Thread Claudio Jeker
On Thu, Nov 25, 2021 at 02:56:02PM +0100, Alexandr Nedvedicky wrote: > Hello, > > thank you for taking a look at my diff. > > > > > > } > > > > > > - if (kif->pfik_ifp != NULL || kif->pfik_group != NULL || kif == pfi_all) > > > + if (kif->pfik_ifp != NULL || kif->pfik_group != NULL ||kif ==

Re: [External] : Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jonathan Gray
On Fri, Nov 26, 2021 at 12:04:21PM +0100, Alexandr Nedvedicky wrote: > Hello, > > On Fri, Nov 26, 2021 at 04:32:59PM +1100, Jonathan Gray wrote: > > Stop building the kernel with -Wno-uninitialized on clang archs. > > This hides real problems like the recently fixed uninitialised memory > > use in

Re: [External] : Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Alexandr Nedvedicky
Hello, On Fri, Nov 26, 2021 at 04:32:59PM +1100, Jonathan Gray wrote: > Stop building the kernel with -Wno-uninitialized on clang archs. > This hides real problems like the recently fixed uninitialised memory > use in pf and igc. yes, please. I'd like to have the warning enabled. I'm just

Re: rpki-client: make maximum number of publication points to sync operator configurable

2021-11-26 Thread Theo de Raadt
e limits, but also these various self-defense mechanisms they are part of, and in most cases code will get rewritten, not just some number. Jeroen Massar wrote: > (chiming in from the sidelines) > (TLDR: Use a scary looking env variable instead.) > > > On 20211126, at 24:50, Theo d

update iwx(4) firmware to -67

2021-11-26 Thread Stefan Sperling
This patch updates iwx(4) to new firmware images (API version -67). Intel has published a related security advisory: https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00509.html Make sure to get a fresh kernel from -current sources and update to iwx-firmware-20211101 with

Re: Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Mark Kettenis
> Date: Fri, 26 Nov 2021 16:32:59 +1100 > From: Jonathan Gray > > Stop building the kernel with -Wno-uninitialized on clang archs. > This hides real problems like the recently fixed uninitialised memory > use in pf and igc. > > After visa's recent commit the remaining warnings are > > [-Wsometi