dev/videomode/vesagtf.c: -Werror,-Wunused-but-set-variable fix

2021-12-19 Thread SASANO Takayoshi
Hi, recently, using -Werror,-Wunused-but-set-variable option makes compile error. at least vesagtf.c needs fix but some (many?) other codes need do so. Index: vesagtf.c === RCS file: /cvs/src/sys/dev/videomode/vesagtf.c,v retrieving

Re: dev/videomode/vesagtf.c: -Werror,-Wunused-but-set-variable fix

2021-12-19 Thread Jonathan Gray
On Sun, Dec 19, 2021 at 08:56:41PM +0900, SASANO Takayoshi wrote: > Hi, > > recently, using -Werror,-Wunused-but-set-variable option makes compile error. > at least vesagtf.c needs fix but some (many?) other codes need do so. clang kernels are built with -Wno-unused-but-set-variable try running '

fix ldapd bug when removing last attribute

2021-12-19 Thread Claudio Jeker
In LDAP there is two ways to remove an attribute. One can remove an attribute by just naming the attribute but it is also possible to remove a specific attribute: value combo. In ldapd the latter is broken if the last attribute is removed because the result of ldap_del_values() is an invalid encod

Re: ipsec tdb walk

2021-12-19 Thread Vitaliy Makkoveev
On Sat, Dec 18, 2021 at 01:07:00AM +0100, Alexander Bluhm wrote: > Hi, > > There are occasions where the walker in tdb_walk() might sleep. > Case SADB_DUMP is such a case. And mvs@ has a diff that sleeps to > read the counters. So holding the tdb_sadb_mtx() when calling > walker() is not allowed

Re: fix ldapd bug when removing last attribute

2021-12-19 Thread Jonathan Matthew
On Sun, Dec 19, 2021 at 01:31:24PM +0100, Claudio Jeker wrote: > In LDAP there is two ways to remove an attribute. > One can remove an attribute by just naming the attribute but it is also > possible to remove a specific attribute: value combo. > > In ldapd the latter is broken if the last attribu