Re: [External] : Re: make 'set skip on ...' dynamic

2021-12-25 Thread Alexandr Nedvedicky
Hello, > > updated diff is attached. > > One comment below but this diff is OK claudio@ > > > thanks and > > regards > > sashan > > > > 8<---8<---8<--8< > > void > > pfi_xcommit(void) > > { > > - struct pfi_kif *p; > > + struct pf

Re: parallel ip forwarding

2021-12-25 Thread Vitaliy Makkoveev
On Fri, Dec 24, 2021 at 12:50:23PM +0100, Alexander Bluhm wrote: > On Fri, Dec 24, 2021 at 04:16:28PM +0900, YASUOKA Masahiko wrote: > > > - npppd l2pt ipsecflowinfo is not MP safe > > > > Does this mean the things we are discussing on the "Fix > > ipsp_spd_lookup() for transport mode" thread? I

Re: parallel ip forwarding

2021-12-25 Thread Alexander Bluhm
On Sat, Dec 25, 2021 at 09:24:07AM +0100, Hrvoje Popovski wrote: > On 24.12.2021. 0:55, Alexander Bluhm wrote: > > I think we can remove the ipsec_in_use workaround now. The IPsec > > path is protected with the kernel lock. > > > > There are some issues left: > > - npppd l2pt ipsecflowinfo is not

Re: rpki-client: check ipAddrBlock and autonomousSysNum for criticality

2021-12-25 Thread Ingo Schwarze
Hi Claudio, Claudio Jeker wrote on Sat, Dec 25, 2021 at 05:48:53PM +0100: > On Sat, Dec 25, 2021 at 11:36:50AM +0100, Theo Buehler wrote: >> These extensions MUST be marked critical by the sections of the spec >> mentioned in the cryptowarnx(). That's determined by the ASN1_BOOLEAN >> that is ext

Re: rpki-client: check ipAddrBlock and autonomousSysNum for criticality

2021-12-25 Thread Claudio Jeker
On Sat, Dec 25, 2021 at 11:36:50AM +0100, Theo Buehler wrote: > These extensions MUST be marked critical by the sections of the spec > mentioned in the cryptowarnx(). That's determined by the ASN1_BOOLEAN > that is extracted and ignored after the FIXME a few lines below each of > the two hunks. Rat

Re: sndiod: -F does not switch back to preferred device

2021-12-25 Thread Klemens Nanni
On Sat, Dec 25, 2021 at 04:45:11PM +0100, Alexandre Ratchov wrote: > On Sat, Dec 25, 2021 at 02:51:08PM +, Klemens Nanni wrote: > > > > either "devices that are" or "device that is", I'd say the latter. > > > > commited with "device that is". > > BTW, the example of the -F option descriptio

Re: sndiod: -F does not switch back to preferred device

2021-12-25 Thread Alexandre Ratchov
On Sat, Dec 25, 2021 at 02:51:08PM +, Klemens Nanni wrote: > > either "devices that are" or "device that is", I'd say the latter. > commited with "device that is". BTW, the example of the -F option description seems more appropriate for the new hot plugging section. OK? diff --git a/sndio

Re: sndiod: -F does not switch back to preferred device

2021-12-25 Thread Klemens Nanni
On Sat, Dec 25, 2021 at 03:46:48PM +0100, Alexandre Ratchov wrote: > On Sat, Dec 25, 2021 at 01:34:19PM +, Klemens Nanni wrote: > > > > This reads OK kn, but I suspect others will object to the hotplugd(8) > > reference. > > > > here's a new one, with attach/detach replaced by plug/unplug an

Re: sndiod: -F does not switch back to preferred device

2021-12-25 Thread Alexandre Ratchov
On Sat, Dec 25, 2021 at 01:34:19PM +, Klemens Nanni wrote: > > This reads OK kn, but I suspect others will object to the hotplugd(8) > reference. > here's a new one, with attach/detach replaced by plug/unplug and no ref to hotplug(8) OK? diff --git a/sndiod/sndiod.8 b/sndiod/sndiod.8 index

Re: sndiod: -F does not switch back to preferred device

2021-12-25 Thread Klemens Nanni
On Mon, Dec 20, 2021 at 10:11:25AM +0100, Alexandre Ratchov wrote: > On Fri, Dec 17, 2021 at 07:11:41PM +, Klemens Nanni wrote: > > > > So we've concluded that the hotplpugging framework needs work, fine. > > > > I'd still like to improve sndiod(8) regarding its own behaviour. > > > > How ab

Re: Revised version of kqueue-based poll(2)

2021-12-25 Thread Visa Hankala
On Tue, Nov 30, 2021 at 03:11:16PM +, Visa Hankala wrote: > Here is a revised version of kqueue-based poll(2). > > The two most important changes to the previous version are: > > * Properly handle pollfd arrays where more than one entries refer > to the same file descriptor. > > * Fix poll

rpki-client: check ipAddrBlock and autonomousSysNum for criticality

2021-12-25 Thread Theo Buehler
These extensions MUST be marked critical by the sections of the spec mentioned in the cryptowarnx(). That's determined by the ASN1_BOOLEAN that is extracted and ignored after the FIXME a few lines below each of the two hunks. Rather than getting the info from there, it's easier to use an API call t

Re: parallel ip forwarding

2021-12-25 Thread Hrvoje Popovski
On 24.12.2021. 0:55, Alexander Bluhm wrote: > I think we can remove the ipsec_in_use workaround now. The IPsec > path is protected with the kernel lock. > > There are some issues left: > - npppd l2pt ipsecflowinfo is not MP safe > - the acquire SA feature is not MP safe > - Hrvoje has seen a pani