Re: slaacd: wait for non-tentative link local address

2022-01-01 Thread Florian Obser
ping On 2021-12-27 16:20 +01, Florian Obser wrote: > Wait for the link-local address to become non-tentative. > Otherwise we just end up with an ugly "Can't assign requested address" > error from sendmsg(2). > > OK? > > diff --git frontend.c frontend.c > index b3be6c3fe98..3bbe3656dd3 100644 > ---

Re: dhcpleased(8): host name DHCP option

2022-01-01 Thread Florian Obser
ping On 2021-12-24 10:16 +01, Florian Obser wrote: > Make host name DHCP option configurable. > Diff from ha...@sdf.org, tweaks by me. > > RFC 2132 says a host name must have a lenght of at least 1, so we can > use strlen(h_name) == 0 to not send a host name option at all and h_name > == NULL to s

Re: slaacd(8): router lifetime zero vs. prefixes

2022-01-01 Thread Florian Obser
ping On 2021-12-27 17:01 +01, Florian Obser wrote: > Prefix life time is independent from router life time. > Form an IPv6 address even if the router announcing the prefix isn't a > default router. > Problem reported by mgraves AT brainfat.net on misc > > OK? > > diff --git engine.c engine.c > ind

Re: less: fix use after free bug

2022-01-01 Thread Tobias Stoeckmann
On Fri, Dec 31, 2021 at 10:29:28PM -0800, Philip Guenther wrote: > To bikeshed slightly I would be inclined to do the work progressively, > perhaps like the diff below...but your diff works too. I'm fine with your version as well. In fact I have used a comparable approach but opted out to the one