Re: rpki-client RFC "compliant" MFT parsing

2022-01-26 Thread Theo Buehler
On Wed, Jan 26, 2022 at 04:42:04PM +0100, Claudio Jeker wrote: > So the RFC is not very clear but in general the idea is that if multiple > MFTs are available the newest one (highest manifest number) should be > used. > > In our case there are two possible MFTs available the previously valid on >

head(1): refactor main loop

2022-01-26 Thread Scott Cheloha
The main loop in head(1) is obfuscated. In particular, the path through the loop to exit(3) is extremely clever. Clever in a bad way. This patch moves the open/read/write/close portions of the loop out into a separate function, head_file(). I think the result is easier to understand. We only

Re: FAT32 short filename inconsistencies

2022-01-26 Thread Edd Barrett
Hi, On Wed, Jan 26, 2022 at 05:41:30PM +0100, Tilo Stritzky wrote: > If neither -s nor -l are given, mount_msdos searches the root > directory of the file system to be mounted for any existing > Windows 95/98 long filenames. If no such entries are found, -s

Re: cwm: add group-last command [Was: Re: cwm: add last-group command]

2022-01-26 Thread Omar Polo
Marcus MERIGHI writes: > Hello, > > I just stumbled over this and thought it deserves a friendly ping. > > Marcus thanks for the interest in the diff :) here's the diff re-attached for convenience, I've been using it for almost two years now! Quoting my original email: > The attached patch

Re: FAT32 short filename inconsistencies

2022-01-26 Thread Tilo Stritzky
On 25/01/22 21:48 Edd Barrett wrote: > > > -lForce listing and generation of Windows 95/98 long filenames and > > separate creation/modification/access dates. And the next paragraph: If neither -s nor -l are given, mount_msdos searches the root directory

Re: syslogd(8): Add hostname parsing support

2022-01-26 Thread Theo de Raadt
> However, as things stand interpretation can be broken with the base > tools. I can't fix garbage input. Your proposal builds a mechanism which encourages making decisions based upon parsing garbage input. >From our diff: +.It Fl H +Use the hostname from the received message +.Pq if detected

rpki-client RFC "compliant" MFT parsing

2022-01-26 Thread Claudio Jeker
So the RFC is not very clear but in general the idea is that if multiple MFTs are available the newest one (highest manifest number) should be used. In our case there are two possible MFTs available the previously valid on and the now downloaded one. So adjust the parser code so that both files

Re: Allow rsync:// URI as rpki-client -f file

2022-01-26 Thread Theo Buehler
On Wed, Jan 26, 2022 at 03:18:54PM +0100, Claudio Jeker wrote: > rpki-client -f is a great tool to figure out what is going in the repo. > I noticed that supporting rsync:// URI (like the one from Authority info > access or Manifest) is easy and it makes it so much easier to follow > the

Allow rsync:// URI as rpki-client -f file

2022-01-26 Thread Claudio Jeker
rpki-client -f is a great tool to figure out what is going in the repo. I noticed that supporting rsync:// URI (like the one from Authority info access or Manifest) is easy and it makes it so much easier to follow the breadcrumbs up and down. While doing that I noticed that instead of using

Re: rpki-client repo layout change

2022-01-26 Thread Theo Buehler
On Wed, Jan 26, 2022 at 02:39:47PM +0100, Claudio wrote: > On Wed, Jan 26, 2022 at 12:36:31PM +0100, Sebastian Benoit wrote: > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.26 11:54:41 +0100: > > > On Wed, Jan 26, 2022 at 11:43:25AM +0100, Theo Buehler wrote: > > > > On Wed, Jan 26, 2022 at

Re: rpki-client repo layout change

2022-01-26 Thread Claudio
On Wed, Jan 26, 2022 at 12:36:31PM +0100, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.26 11:54:41 +0100: > > On Wed, Jan 26, 2022 at 11:43:25AM +0100, Theo Buehler wrote: > > > On Wed, Jan 26, 2022 at 10:06:37AM +0100, Claudio Jeker wrote: > > > > This diff removes

Re: rpki-client repo layout change

2022-01-26 Thread Theo Buehler
On Wed, Jan 26, 2022 at 12:36:31PM +0100, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.26 11:54:41 +0100: > > On Wed, Jan 26, 2022 at 11:43:25AM +0100, Theo Buehler wrote: > > > On Wed, Jan 26, 2022 at 10:06:37AM +0100, Claudio Jeker wrote: > > > > This diff removes

Re: rpki-client repo layout change

2022-01-26 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.01.26 11:54:41 +0100: > On Wed, Jan 26, 2022 at 11:43:25AM +0100, Theo Buehler wrote: > > On Wed, Jan 26, 2022 at 10:06:37AM +0100, Claudio Jeker wrote: > > > This diff removes the valid/ subdir in favor of a more direct directory > > > layout for

Re: rpki-client repo layout change

2022-01-26 Thread Claudio Jeker
On Wed, Jan 26, 2022 at 11:43:25AM +0100, Theo Buehler wrote: > On Wed, Jan 26, 2022 at 10:06:37AM +0100, Claudio Jeker wrote: > > This diff removes the valid/ subdir in favor of a more direct directory > > layout for all valid CA repository files. > > It moves rrdp and rsync to .rsync and .rrdp

Re: rpki-client repo layout change

2022-01-26 Thread Theo Buehler
On Wed, Jan 26, 2022 at 10:06:37AM +0100, Claudio Jeker wrote: > This diff removes the valid/ subdir in favor of a more direct directory > layout for all valid CA repository files. > It moves rrdp and rsync to .rsync and .rrdp but keeps ta/ because trust > anchors are special. > > The biggest

Re: hardware checksum ix and ixl

2022-01-26 Thread Claudio Jeker
On Wed, Jan 26, 2022 at 01:29:42AM +0100, Alexander Bluhm wrote: > Hi, > > There were some problems with ix(4) and ixl(4) hardware checksumming > for the output path on strict alignment architectures. > > I have merged jan@'s diffs and added some sanity checks and > workarounds. > > - If the

rpki-client repo layout change

2022-01-26 Thread Claudio Jeker
This diff removes the valid/ subdir in favor of a more direct directory layout for all valid CA repository files. It moves rrdp and rsync to .rsync and .rrdp but keeps ta/ because trust anchors are special. The biggest change is probably in the FTS code to cleanup the repo since the traversing