Re: initial iwx(4) 11ac patch for testing

On Wed, Mar 09, 2022 at 01:07:47PM +0100, Stefan Sperling wrote: > This patch adds initial 11ac support to the iwx(4) driver. > This means that 80MHz channels can be used. No other 11ac features > are enabled yet. > > This is not yet a patch which could be committed. Apart from debug > prints which

ssh: xstrdup(): use memcpy(3)

The strdup(3) implementation in libc uses memcpy(3), not strlcpy(3). There is no upside to using strlcpy(3) here if we know the length of str before we copy it to the destination buffer. ... unless we're worried the length of str will change? Which would be very paranoid. But if that's the case

Re: riscv64: ld.lld is too picky on ABI mismatch

On Mon, Oct 25 2021, Jeremie Courreges-Anglas wrote: > On Mon, Oct 25 2021, Patrick Wildt wrote: >> Am Mon, Oct 25, 2021 at 11:43:55AM +0200 schrieb Mark Kettenis: >>> > From: Jeremie Courreges-Anglas >>> > Date: Sun, 24 Oct 2021 17:30:46 +0100 >>> > >>> > clang(1) defaults to FP ABI but ld(1)

Re: ipsec acquire mutex refcount

On 9.3.2022. 19:14, Alexander Bluhm wrote: > Hi, > > Hrvoje has hit a crash with IPsec acquire while testing the parallel > ip forwarding diff. Analysis with sashan@ concludes that this part > is not MP safe. Mutex and refcount should fix the memory management. > > Hrvoje: Could you test this d

Re: atomic read write

On Tue, Mar 08, 2022 at 04:55:56PM +0100, Alexander Bluhm wrote: > Once we had the discussion where we need the READ_ONCE() macro. As > modern C compiler has much freedom how to access memory, I came to > the conclusion that it would be wise to use READ_ONCE() and > WRITE_ONCE() everywhere when we

ipsec acquire mutex refcount

Hi, Hrvoje has hit a crash with IPsec acquire while testing the parallel ip forwarding diff. Analysis with sashan@ concludes that this part is not MP safe. Mutex and refcount should fix the memory management. Hrvoje: Could you test this diff? ok? bluhm Index: net/pfkeyv2.c ==

Re: Add kernel stack trace saving for riscv64

On Wed, Mar 09, 2022 at 08:40:50AM +0100, Jeremie Courreges-Anglas wrote: > On Tue, Mar 08 2022, Visa Hankala wrote: > > This patch adds kernel stack trace saving for riscv64, for the benefit > > of dt(4) and witness(4). > > Nice! > > > The unwinder is slow because of the symbol > > lookup, but

Re: initial iwx(4) 11ac patch for testing

On Wed, Mar 09, 2022 at 01:07:47PM +0100, Stefan Sperling wrote: > This patch adds initial 11ac support to the iwx(4) driver. > This means that 80MHz channels can be used. No other 11ac features > are enabled yet. > > This is not yet a patch which could be committed. Apart from debug > prints whic

initial iwx(4) 11ac patch for testing

This patch adds initial 11ac support to the iwx(4) driver. This means that 80MHz channels can be used. No other 11ac features are enabled yet. This is not yet a patch which could be committed. Apart from debug prints which need to go, there is a known issue found by dv@ where this patch causes a f

Re: mg and trailing whitespaces

On Wed, Mar 02, 2022 at 09:47:31AM +0100, Omar Polo wrote: > Hello tech, > > mg(1) has this tendency to leave a lot of trailing whitespaces around in > auto-indent-mode and c-mode which I find annoying. Yes, there's > delete-trailing-space but it works only on the current line (and not the > whol

Re: ieee80211_stats userland vs. kernel

On Tue, Mar 08, 2022 at 02:38:39PM -0700, Theo de Raadt wrote: > Stefan Sperling wrote: > > In this case it is not ifconfig, but netstat -W iwm0. > > Which is a debugging tool, like netstat -s. > > We don't care when netstat breaks Alright, then this diff is indeed not necessary.