Re: possible memory leak in ipmi get_sdr

Any insights? On Mon, Jan 10, 2022 at 03:18:47PM +0100, Moritz Buhl wrote: > Hi tech@, > > The return value of add_child_sensors is returned in add_sdr_sensor, > which is called by get_sdr. get_sdr mallocs psdr and only frees it > if add_sdr_sensor returns 0. The assumption is that psdr is atta

Re: possible memory leak in ipmi get_sdr

On 2022/04/07 13:31, Moritz Buhl wrote: > Any insights? > On Mon, Jan 10, 2022 at 03:18:47PM +0100, Moritz Buhl wrote: > > Hi tech@, > > > > The return value of add_child_sensors is returned in add_sdr_sensor, > > which is called by get_sdr. get_sdr mallocs psdr and only frees it > > if add_sdr_

Re: pfsync(4) snapshot lists must have dedicated link element

On Wed, Apr 06, 2022 at 05:01:55PM +0200, Alexandr Nedvedicky wrote: > Hello, > > Hrvoje was testing pf(4) and pfsync(4) with parallel forwarding diff > which bluhm@ has shared sometime ago. > > Hrvoje found a bug in my very naive implementation of 'snapshots': > > 1573 void > 1574 pfsync_grab_s

pf_rollback_rules always returns 0

Hi, Since 2015 pf_rollback_rules always returns 0. Make it void. OK? mbuhl Index: sys/net/pf_ioctl.c === RCS file: /cvs/src/sys/net/pf_ioctl.c,v retrieving revision 1.376 diff -u -p -r1.376 pf_ioctl.c --- sys/net/pf_ioctl.c 4 Apr

Re: [External] : pf_rollback_rules always returns 0

Hello, On Thu, Apr 07, 2022 at 03:21:32PM +0200, Moritz Buhl wrote: > Hi, > > Since 2015 pf_rollback_rules always returns 0. Make it void. > > OK? looks good to me. OK sashan

Constify ifmedia descriptions

This constifies the ifmedia description tables, both in the kernel (yes, I did a test compile with option IFMEDIA_DEBUG) and one straggler in userland. ok? diff 3c78bc9451ce7ce927aaecc9f8e5113de7023a9c /usr/src blob - 0ef67c56edd8be741533ccba974c11f198887b32 file + sbin/ifconfig/ifconfig.c --- sb

Re: Fix incorrect checksum generation in sr_meta_init

Hey, i cannot comment on the correctness of the change, but i have it in my tree running for 5 days now without any problems. This is not an OK, just feedback. Greetings Leo On 27.03.22 01:20, Crystal Kolipe wrote: --- softraid.c.dist Sat Mar 26 19:40:51 2022 +++ softraid.c Sat Mar 26

Re: refcount btrace

On Wed, Mar 23, 2022 at 06:13:27PM +0100, Alexander Bluhm wrote: > In my opinion tracepoints give insight at minimal cost. It is worth > it to have it in GENERIC to make it easy to use. After release I want to revive the btrace of refcounts discussion. As mpi@ mentioned the idea of dt(4) is to h

rpki-client 7.7 has just been released

rpki-client 7.7 has just been released and will be available in the rpki-client directory of any OpenBSD mirror soon. rpki-client is a FREE, easy-to-use implementation of the Resource Public Key Infrastructure (RPKI) for Relying Parties (RP) to facilitate validation of a BGP announcement. The prog

lm, uguru, fins, wbenv: constify sensor tables

This constifies the sensor tables of the lm(4), uguru(4), fins(4), and wbenv(4) drivers, which all share the same basic design. ok? diff refs/heads/master refs/heads/const_sensors blob - a813447ec9521a2a11a8b1f5daa38b881da007c1 blob + 3a1b2bfdc2b1d92d62f3b156479ad0ff5b57e463 --- sys/dev/i2c/w83l7

const openpty et al.

const the termp and winp arguments for openpty and related. This matches the prototypes for openpty and forkpty in glibc and musl libc. diff --git openpty.3 openpty.3 index e0c82e00c53..080d92d8ced 100644 --- openpty.3 +++ openpty.3 @@ -47,15 +47,15 @@ .Ft int .Fn getptmfd "void" .Ft int -.Fn o

Re: refcount btrace

On Thu, Apr 07, 2022 at 07:55:11PM +0200, Alexander Bluhm wrote: > On Wed, Mar 23, 2022 at 06:13:27PM +0100, Alexander Bluhm wrote: > > In my opinion tracepoints give insight at minimal cost. It is worth > > it to have it in GENERIC to make it easy to use. > > After release I want to revive the b