login_fbtab glob

2022-04-14 Thread joshua stein
login_fbtab(3) supports wildcards but only for every file in a directory (/path/*). This makes it use glob(3) so it can also support more specific wildcards like /path/file* diff --git lib/libutil/login_fbtab.c lib/libutil/login_fbtab.c index 5eacf4f65ff..39621a0cde4 100644 ---

Re: dwctwo(4) fix panic

2022-04-14 Thread Mark Kettenis
> Date: Thu, 14 Apr 2022 20:16:13 +0200 > From: Marcus Glocker > > I did hit this panic when trying to stream audio through > uaudio(4) / dwctwo(4): > > panic: _dmamap_sync: ran off map! > Stopped at panic+0x160:cmp w21, #0x0 > TIDPIDUID PRFLAGS

dwctwo(4) fix panic

2022-04-14 Thread Marcus Glocker
I did hit this panic when trying to stream audio through uaudio(4) / dwctwo(4): panic: _dmamap_sync: ran off map! Stopped at panic+0x160:cmp w21, #0x0 TIDPIDUID PRFLAGS PFLAGS CPU COMMAND *421282 69103 0 0x2

Re: rate limit uvn_flush warning

2022-04-14 Thread Theo de Raadt
> If I understand correctly, the problem is that writing to memory > of an mmap(2)ed file has no error handling. If the file system is > full, userland cannot be informed. So someone invented this message > in the kernel. If you cannot return an error to the program, deciding to print a message

Re: rate limit uvn_flush warning

2022-04-14 Thread Alexander Bluhm
On Wed, Apr 13, 2022 at 02:22:00PM -0600, Theo de Raadt wrote: > I think we should fix the bug and/or DELETE the message entirely I don't see the bug. The message was added in the initial NetBSD uvm commit. http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/uvm/uvm_vnode.c?annotate=1.1 With a major

Re: kbd -l error message

2022-04-14 Thread Alexander Bluhm
On Thu, Apr 14, 2022 at 04:44:10PM +0200, Marc Espie wrote: > I'm not quite fond of the error reports, though... they could be more specific > - we keep track of the first error, so it should probably talk > about /dev/wskbd0 directly ? I wanted to show that more than one device is envolved. But

Re: kbd -l error message

2022-04-14 Thread Theo de Raadt
I don't see the need for the word "open "in the message. Alexander Bluhm wrote: > Hi, > > When kbd -l is executed as regular user, it fails silently. > > $ kbd -l > $ echo $? > 0 > > Error handling is a bit tricky. We want the first error if no > device is available. > > $ ./kbd -l > kbd:

Re: kbd -l error message

2022-04-14 Thread Marc Espie
On Thu, Apr 14, 2022 at 04:28:37PM +0200, Alexander Bluhm wrote: > Hi, > > When kbd -l is executed as regular user, it fails silently. > > $ kbd -l > $ echo $? > 0 > > Error handling is a bit tricky. We want the first error if no > device is available. > > $ ./kbd -l > kbd: open

kbd -l error message

2022-04-14 Thread Alexander Bluhm
Hi, When kbd -l is executed as regular user, it fails silently. $ kbd -l $ echo $? 0 Error handling is a bit tricky. We want the first error if no device is available. $ ./kbd -l kbd: open /dev/wskbd[0-9]: Permission denied $ echo $? 1 ok? bluhm Index: sbin/kbd/kbd_wscons.c