vmm: load vmcs before reading vcpu registers

2022-05-08 Thread Dave Voutila
tech@, Continuing my vmm/vmd bug hunt, the following diff adapts vcpu_readregs_vmx to optionally load the vmcs on the current cpu. This has gone unnoticed as the ioctl isn't used in typical vmd usage and the usage of vcpu_readregs_vmx in the run ioctl is after the vmcs is already loaded on the

Re: [External] : net lock priority

2022-05-08 Thread Alexandr Nedvedicky
Hello, On Sun, May 08, 2022 at 10:13:20PM +0200, Alexander Bluhm wrote: > On Sun, May 08, 2022 at 09:19:23PM +0200, Alexander Bluhm wrote: > > I will run my tests with the diff below. > > With the third chunk reboot hangs during reordering libraries in > vmmaplk. So this needs more thought.

Re: [patch] CPU frequency scheduler change proposal

2022-05-08 Thread Mark Kettenis
> Date: Sun, 20 Mar 2022 18:13:16 +0100 > From: Solene Rapenne > > I'm proposing a very simple change to the automatic policy of the CPU > frequency scheduler. > > Currently, every 100ms the scheduler is doing this: > > - when the CPU load exceeds the threshold, CPU frequency is set to the >

Re: [External] : net lock priority

2022-05-08 Thread Alexander Bluhm
On Sun, May 08, 2022 at 09:19:23PM +0200, Alexander Bluhm wrote: > I will run my tests with the diff below. With the third chunk reboot hangs during reordering libraries in vmmaplk. So this needs more thought. > Index: kern/kern_rwlock.c >

Re: [External] : Re: pf.conf(5) clarify ICMP sloppy state handling

2022-05-08 Thread Alexander Bluhm
On Sun, May 08, 2022 at 09:58:47PM +0200, Alexandr Nedvedicky wrote: > Hello, > > On Sun, May 08, 2022 at 08:06:57PM +0200, Alexander Bluhm wrote: > > On Sun, May 08, 2022 at 06:37:57PM +0200, Alexandr Nedvedicky wrote: > > > this tiny update to pf.conf(5) has been prompted here [1] on > > > pf

Re: rpki-client: add support for draft-ietf-sidrops-rpki-rsc in filemode

2022-05-08 Thread Job Snijders
Dear Theo, fellow developers, Many thanks for the first review pass, much appreciated. > This is a good first step. I have a few initial comments inline. Once you fix > those, review of the rest will be easier. > > The main thing is: please remove all the copy-pasted functions that had no >

Re: [External] : Re: pf.conf(5) clarify ICMP sloppy state handling

2022-05-08 Thread Alexandr Nedvedicky
Hello, On Sun, May 08, 2022 at 08:06:57PM +0200, Alexander Bluhm wrote: > On Sun, May 08, 2022 at 06:37:57PM +0200, Alexandr Nedvedicky wrote: > > this tiny update to pf.conf(5) has been prompted here [1] on > > pf mailing list. By default only ICMP queries are allowed > > to create state in

Re: [External] : net lock priority

2022-05-08 Thread Alexander Bluhm
On Sun, May 08, 2022 at 07:55:44PM +0200, Alexandr Nedvedicky wrote: > my question is why do we reset RWLOCK_WAIT and RWLOCK_WRWANT flags? This is a very good question. > I think those flags should be reset the last reader gone. Perhaps > the else branch for reader requires this: >

Re: rpki-client: add support for draft-ietf-sidrops-rpki-rsc in filemode

2022-05-08 Thread Theo Buehler
On Sun, May 08, 2022 at 04:18:13PM +, Job Snijders wrote: > Dear all, > > This changeset adds support for decoding and verifying the cryptographic > validity of RPKI Signed Checklists (RSC) files. The draft [1] is in > Working Group Last Call, the wire image is considered stable. > > A

Re: pf.conf(5) clarify ICMP sloppy state handling

2022-05-08 Thread Alexander Bluhm
On Sun, May 08, 2022 at 06:37:57PM +0200, Alexandr Nedvedicky wrote: > this tiny update to pf.conf(5) has been prompted here [1] on > pf mailing list. By default only ICMP queries are allowed > to create state in pf(4). The sloppy option relaxes that > so also ICMP replies can create a state. I

Re: [External] : net lock priority

2022-05-08 Thread Alexandr Nedvedicky
Hello, On Sun, May 08, 2022 at 07:31:46PM +0200, Alexandr Nedvedicky wrote: > Hello, > > On Fri, May 06, 2022 at 09:50:30PM +0200, Alexander Bluhm wrote: > > Hi, > > > > When creating network load by forwarding packets, SSH gets unusable > > and ping time gets above 10 seconds. > > > > Problem

Re: [External] : net lock priority

2022-05-08 Thread Alexandr Nedvedicky
Hello, On Fri, May 06, 2022 at 09:50:30PM +0200, Alexander Bluhm wrote: > Hi, > > When creating network load by forwarding packets, SSH gets unusable > and ping time gets above 10 seconds. > > Problem is that while multiple forwarding threads are running with > shared net lock, the exclusive

pf.conf(5) clarify ICMP sloppy state handling

2022-05-08 Thread Alexandr Nedvedicky
Hello, this tiny update to pf.conf(5) has been prompted here [1] on pf mailing list. By default only ICMP queries are allowed to create state in pf(4). The sloppy option relaxes that so also ICMP replies can create a state. I think this should be also mentioned in pf.conf(5) OK to my suggestion

rpki-client: add support for draft-ietf-sidrops-rpki-rsc in filemode

2022-05-08 Thread Job Snijders
Dear all, This changeset adds support for decoding and verifying the cryptographic validity of RPKI Signed Checklists (RSC) files. The draft [1] is in Working Group Last Call, the wire image is considered stable. A RSC is a Cryptographic Message Syntax (CMS) profile for a general purpose

move memory allocation in pfr_add_tables() outside of NET_LOCK()/PF_LOCK()

2022-05-08 Thread Alexandr Nedvedicky
Hello, diff below reshuffles pfr_create_ktable() so all memory allocations happens outside of NET_LOCK()/PF_LOCK(). pf(4) currently allocates for new table with PR_WAITOK flag, when function is invoked on behalf of ioctl (PFR_FLAG_USERIOCTL flag is set). PR_WAITOK for memory allocation is OK if

Re: athn(4) USB question: Where is Tx interrupt handler?

2022-05-08 Thread Stefan Sperling
On Sun, May 08, 2022 at 12:29:57AM -0400, Farhan Khan wrote: > On May 6, 2022 4:37:48 AM EDT, Stefan Sperling wrote: > >On Thu, May 05, 2022 at 01:19:08PM -0400, Farhan Khan wrote: > >> Hi all, > >> > >> Summary Question: > >> > >> Broadly, I am trying to understand where a interrupt callback