Re: netstart(8): don't lie

2022-06-25 Thread Theo de Raadt
Nice improvement. "clearing out existing configuration" is so hairy, it isn't on our roadmap at all. Stuart Henderson wrote: > any comments? does it need a "does not clear things" caveat? ok? > > Index: netstart.8 > === > RCS file

bwfm: fix ifconfig media display on rpi2 usb wifi dongle

2022-06-25 Thread Stefan Sperling
There is an off-by-one in bwfm_update_node(). This function reads the tx_rate field from station information returned by firmware. According to a comment in the Linux driver, this field is valid for sta_info command versions >= 3. linux/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil_types.

Re: Fix lock order reversal in nfs_inactive()

2022-06-25 Thread Jeremie Courreges-Anglas
On Sun, Jun 19 2022, Visa Hankala wrote: > On Sun, Jun 19, 2022 at 11:05:38AM +0200, Jeremie Courreges-Anglas wrote: >> On Fri, Jun 17 2022, Jeremie Courreges-Anglas wrote: >> > On Thu, Jun 16 2022, Visa Hankala wrote: >> >> nfs_inactive() has a lock order reversal. When it removes the silly >>

bgpd, more IPv6 scope_id insanity

2022-06-25 Thread Claudio Jeker
Since 128bit address space is not enough add the extra 32bit scope_id to struct kroute6 so that we can track that as well. With this using link local addresses as nexthops should work again. Also the madness is a little bit less bad since we just copy the scope_id in and out no matter what. -- :w

Remove VOP_POLL()

2022-06-25 Thread Visa Hankala
Remove unused VOP_POLL(). The patch cuts cttypoll()'s dependency on VOP_POLL(). cttypoll() has been called through spec_poll() and is unused. The function cannot be removed yet as the build expects the symbol. (Next, remove d_poll from struct cdevsw.) OK? Index: share/man/man9/VOP_LOOKUP.9

Re: rewrite amd64 cache printing

2022-06-25 Thread Mike Larkin
On Fri, Jun 24, 2022 at 07:19:47PM +1000, Jonathan Gray wrote: > Rewrite amd64 printing of cache details. > Previously we looked at cpuid 0x8005 for L1/TLB details > which Intel documents as reserved. > And cpuid 0x8006 for L2 details. > > Intel also encode cache details in cpuid 4. > AMD h

Re: more unused parts of dig

2022-06-25 Thread Bob Beck
I keep reading these as "unused parts of dlg" and wondering why he's not remoing them himself.. ok beck@ On Sat, Jun 25, 2022 at 08:48:48PM +1000, Jonathan Gray wrote: > Index: lib/dns/gen.c > === > RCS file: /cvs/src/usr.bin/dig/li

dig(1): SVCB and HTTPS RR types

2022-06-25 Thread Florian Obser
See https://datatracker.ietf.org/doc/draft-ietf-dnsop-svcb-https/ $ ./obj/dig @8.8.8.8 +norec _dns.resolver.arpa svcb ; <<>> dig 9.10.8-P1 <<>> @8.8.8.8 +norec _dns.resolver.arpa svcb ; (1 server found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 212

Fix deadlock with FFS quotas

2022-06-25 Thread Visa Hankala
The kernel can deadlock if it tries to allocate blocks for a quota data file that is stored in the same filesystem that has the quotas enabled. This happens because of recursion within the quota subsystem: sleep_finish(8000225d16c0,1) at sleep_finish+0xfe tsleep(807f0880,9,81f8

more unused parts of dig

2022-06-25 Thread Jonathan Gray
Index: lib/dns/gen.c === RCS file: /cvs/src/usr.bin/dig/lib/dns/gen.c,v retrieving revision 1.15 diff -u -p -r1.15 gen.c --- lib/dns/gen.c 14 Sep 2020 08:40:43 - 1.15 +++ lib/dns/gen.c 25 Jun 2022 10:43:28 - @@

dig(1): remove unused DNS_RDATASETATTR defines

2022-06-25 Thread Florian Obser
OK? diff --git lib/dns/include/dns/rdataset.h lib/dns/include/dns/rdataset.h index a2e86b62055..e2c453adc81 100644 --- lib/dns/include/dns/rdataset.h +++ lib/dns/include/dns/rdataset.h @@ -67,46 +67,6 @@ typedef struct dns_rdatasetmethods { void(*clone)(dns_rdataset_t *

dig(1): remove order and order_args

2022-06-25 Thread Florian Obser
We do not order RRsets and we are not interested in partial RRsets. OK? diff --git lib/dns/include/dns/message.h lib/dns/include/dns/message.h index a70720eee39..7f547411bf0 100644 --- lib/dns/include/dns/message.h +++ lib/dns/include/dns/message.h @@ -226,9 +226,6 @@ struct dns_message {