Re: acpitz(4): perform passive cooling only when perfpolicy is AUTO

2022-06-27 Thread Stuart Henderson
On 2022/06/27 17:12, Bryan Steele wrote: > > Shouldn't this also take into consideration hw.power as well? If it > doesn't make sense for perfpolicy=high then it probably doesn't for > perfpolicy=auto when on AC power? Why so? perfpolicy=high says to me, "I want it fast, I don't care about fan no

Re: ip6 hbhchcheck next protocol

2022-06-27 Thread Alexandr Nedvedicky
Hello, On Tue, Jun 28, 2022 at 02:39:24AM +0200, Alexander Bluhm wrote: > Hi, > > The ip6_hbhchcheck() function never reads the nxtp parameter, it > only sets its value. It is more obvious if we return the next > protocol and return IPPROTO_DONE to signal error. All IP protocol > functions do t

Re: stop using mquery(2) inside realloc(3)

2022-06-27 Thread Theo de Raadt
This diff to stop using mquery has been in snaps for a few weeks, and I finally noticed some fallout. But it is amusing fallout: If you have a snap with the diff installed, you cannot build an install media in a shortcut way, since malloc.c in the real tree uses mquery, but the installed libc does

com at acpi: minor nit

2022-06-27 Thread Anton Lindqvist
Hi, A com_acpi_softc pointer is used as the interrupt callback cookie which is later on interpreted as a com_softc pointer. This is not a problem in practice as a com_softc structure is the first member of the com_acpi_softc structure. Using the actual types consistently yields a better symmetry i

bcmdmac: minor nit

2022-06-27 Thread Anton Lindqvist
Hi, No need to pass a copy of the bcmdmac_channel structure to predicate routines. Comments? OK? diff --git sys/dev/fdt/bcm2835_dmac.c sys/dev/fdt/bcm2835_dmac.c index 145810dd7af..e9b31af568c 100644 --- sys/dev/fdt/bcm2835_dmac.c +++ sys/dev/fdt/bcm2835_dmac.c @@ -97,18 +97,18 @@ struct cfdriver

Re: acpitz(4): perform passive cooling only when perfpolicy is AUTO

2022-06-27 Thread Sebastien Marie
On Mon, Jun 27, 2022 at 11:47:58PM +0200, Stefan Hagen wrote: > Bryan Steele wrote (2022-06-27 23:12 CEST): > > On Mon, Jun 27, 2022 at 11:01:31PM +0200, Stefan Hagen wrote: > > > acpitz(4) implements passive cooling, which starts throttling the CPU to > > > keep it under the temperature reported

ip6 hbhchcheck next protocol

2022-06-27 Thread Alexander Bluhm
Hi, The ip6_hbhchcheck() function never reads the nxtp parameter, it only sets its value. It is more obvious if we return the next protocol and return IPPROTO_DONE to signal error. All IP protocol functions do that. ok? bluhm Index: netinet6/ip6_input.c ===

Re: pipex(4): do pppoe output through netisr

2022-06-27 Thread Alexander Bluhm
On Mon, Jun 27, 2022 at 03:58:52PM +0300, Vitaliy Makkoveev wrote: > We can't predict netlock state when pipex(4) related (*if_qstart)() > handlers called. This means we can't use netlock within pppac_qstart() > and pppx_if_qstart() handlers. But actually we can't avoid netlock only > when we call

amd64 serial console changes

2022-06-27 Thread Mark Kettenis
The Ryzen Embedded V1000 processors have an arm64-style Synposys DesignWare UART instead if a PC-compatible NS16x50 UART. To make this UART work as a serial console, we need to pass some more information from the bootloader to the kernel. This diff adds the logic to handle that information to the

Re: acpitz(4): perform passive cooling only when perfpolicy is AUTO

2022-06-27 Thread Bryan Steele
On Mon, Jun 27, 2022 at 11:01:31PM +0200, Stefan Hagen wrote: > Hi, > > acpitz(4) implements passive cooling, which starts throttling the CPU to > keep it under the temperature reported by the _PSV trip point. > > https://uefi.org/specs/ACPI/6.4/11_Thermal_Management/thermal-control.html > > Th

Re: kernel lock in arp

2022-06-27 Thread Alexander Bluhm
On Mon, Jun 27, 2022 at 07:23:20PM +0200, Martin Pieuchot wrote: > On 27/06/22(Mon) 19:11, Alexander Bluhm wrote: > > On Mon, Jun 27, 2022 at 11:49:23AM +0200, Alexander Bluhm wrote: > > > On Sat, May 21, 2022 at 10:50:28PM +0300, Vitaliy Makkoveev wrote: > > > > This diff looks good, except the re

Re: kernel lock in arp

2022-06-27 Thread Martin Pieuchot
On 27/06/22(Mon) 19:11, Alexander Bluhm wrote: > On Mon, Jun 27, 2022 at 11:49:23AM +0200, Alexander Bluhm wrote: > > On Sat, May 21, 2022 at 10:50:28PM +0300, Vitaliy Makkoveev wrote: > > > This diff looks good, except the re-check after kernel lock. It???s > > > supposed `rt??? could became incon

Re: kernel lock in arp

2022-06-27 Thread Alexander Bluhm
On Mon, Jun 27, 2022 at 11:49:23AM +0200, Alexander Bluhm wrote: > On Sat, May 21, 2022 at 10:50:28PM +0300, Vitaliy Makkoveev wrote: > > This diff looks good, except the re-check after kernel lock. It???s > > supposed `rt??? could became inconsistent, right? But what stops to > > make it inconsist

CoW & neighbor pages

2022-06-27 Thread Martin Pieuchot
When faulting a page after COW neighborhood pages are likely to already be entered. So speed up the fault by doing a narrow fault (do not try to map in adjacent pages). This is stolen from NetBSD. ok? Index: uvm/uvm_fault.c === RC

Re: xhci@acpi

2022-06-27 Thread Jonathan Gray
On Mon, Jun 27, 2022 at 05:54:03PM +0200, Mark Kettenis wrote: > So ACPI uses separate HIDs/CIDs for xhci(4) with and without debug > support. PNP0D15 is the one without. Seen on the Lenovo x13s. > > ok? > Might as well add PNP0D25 to ehci_hids[] also. ok jsg@ for both > > Index: xhci_acpi.

xhci@acpi

2022-06-27 Thread Mark Kettenis
So ACPI uses separate HIDs/CIDs for xhci(4) with and without debug support. PNP0D15 is the one without. Seen on the Lenovo x13s. ok? Index: xhci_acpi.c === RCS file: /cvs/src/sys/dev/acpi/xhci_acpi.c,v retrieving revision 1.6 diff

Remove d_poll from struct cdevsw

2022-06-27 Thread Visa Hankala
Remove the now-unused d_poll field from struct cdevsw. This diff adjusts the various conf.{c,h} bits. To avoid making this patch too unwieldy, I leave the removal of the device poll functions for another patch. (Compile-)tested on amd64, arm64, armv7, i386, loongson, macppc, octeon, powerpc64, ri

Re: Remove switch(4) leftovers

2022-06-27 Thread Vitaliy Makkoveev
On Mon, Jun 27, 2022 at 01:44:55PM +, Visa Hankala wrote: > Remove some switch(4) leftovers. > > OK? > ok mvs > Index: etc/etc.hppa/MAKEDEV.md > === > RCS file: src/etc/etc.hppa/MAKEDEV.md,v > retrieving revision 1.68 > diff -u

Re: proctree lock diff

2022-06-27 Thread Jeremie Courreges-Anglas
On Fri, Nov 29 2019, Martin Pieuchot wrote: > For archive, here's the diff on top of -current. Here's a refreshed diff with the bare minimum changes needed to prevent a WITNESS kernel from crashing when running /usr/src/regress/sys. Index: kern/exec_elf.c ===

Re: struct refcnt for routes

2022-06-27 Thread Vitaliy Makkoveev
On Mon, Jun 27, 2022 at 03:21:56PM +0200, Alexander Bluhm wrote: > Hi, > > Use ref count API for routes. > > ok? > Some time ago, I posted the diff which removes the logic around negative `refcnt' within rtfree(). This diff was stopped by mpi@, he said we could underflow rt->rt_refcnt and this

Re: Remove switch(4) leftovers

2022-06-27 Thread Claudio Jeker
On Mon, Jun 27, 2022 at 01:44:55PM +, Visa Hankala wrote: > Remove some switch(4) leftovers. > > OK? OK claudio > Index: etc/etc.hppa/MAKEDEV.md > === > RCS file: src/etc/etc.hppa/MAKEDEV.md,v > retrieving revision 1.68 > diff

Remove switch(4) leftovers

2022-06-27 Thread Visa Hankala
Remove some switch(4) leftovers. OK? Index: etc/etc.hppa/MAKEDEV.md === RCS file: src/etc/etc.hppa/MAKEDEV.md,v retrieving revision 1.68 diff -u -p -r1.68 MAKEDEV.md --- etc/etc.hppa/MAKEDEV.md 11 Nov 2021 09:47:33 - 1.6

Fix the swapper

2022-06-27 Thread Martin Pieuchot
Diff below contain 3 parts that can be committed independently. The 3 of them are necessary to allow the pagedaemon to make progress in OOM situation and to satisfy all the allocations waiting for pages in specific ranges. * uvm/uvm_pager.c part reserves a second segment for the page daemon. Th

struct refcnt for routes

2022-06-27 Thread Alexander Bluhm
Hi, Use ref count API for routes. ok? bluhm Index: net/route.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/route.c,v retrieving revision 1.410 diff -u -p -r1.410 route.c --- net/route.c 5 May 2022 13:57:40 - 1.410

Re: snmpd(8): Add rudimentary AgentX support

2022-06-27 Thread Theo de Raadt
Florian Obser wrote: > On 2022-06-27 13:32 +02, Martijn van Duren > wrote: > > For the group-id I went with 92, which was used by _rtadvd. It's one up > > from _snmpd and has been used previously by _rtadvd, which should make > > it the perfect candidate. According to florian rtadvd never store

pipex(4): do pppoe output through netisr

2022-06-27 Thread Vitaliy Makkoveev
We can't predict netlock state when pipex(4) related (*if_qstart)() handlers called. This means we can't use netlock within pppac_qstart() and pppx_if_qstart() handlers. But actually we can't avoid netlock only when we call (*if_output)() in pipex(4) PPPOE output path. Introduce `pipexoutq' mbuf(9

Re: arp getuptime

2022-06-27 Thread Vitaliy Makkoveev
On Mon, Jun 27, 2022 at 01:58:11PM +0200, Alexander Bluhm wrote: > Hi, > > Instead of calling getuptime() all the time in ARP code, I would > like to do it only once per function. This should give us a more > consistent time value. > > ok? > ok mvs@ > bluhm > > Index: netinet/if_ether.c > ==

Re: arp getuptime

2022-06-27 Thread Claudio Jeker
On Mon, Jun 27, 2022 at 01:58:11PM +0200, Alexander Bluhm wrote: > Hi, > > Instead of calling getuptime() all the time in ARP code, I would > like to do it only once per function. This should give us a more > consistent time value. > > ok? I would love to see the arp code use rttimer instead of

Re: snmpd(8): Add rudimentary AgentX support

2022-06-27 Thread Florian Obser
On 2022-06-27 13:32 +02, Martijn van Duren wrote: > For the group-id I went with 92, which was used by _rtadvd. It's one up > from _snmpd and has been used previously by _rtadvd, which should make > it the perfect candidate. According to florian rtadvd never stored > anything on disk and chances

arp getuptime

2022-06-27 Thread Alexander Bluhm
Hi, Instead of calling getuptime() all the time in ARP code, I would like to do it only once per function. This should give us a more consistent time value. ok? bluhm Index: netinet/if_ether.c === RCS file: /data/mirror/openbsd/cv

snmpd(8): Add rudimentary AgentX support

2022-06-27 Thread Martijn van Duren
Hello tech@, This diff implements most of the AgentX master side. noticeable omissions/intendend omissions are: - Notify: according to the RFC doesn't need guarantee being delivered to it's final destination, just that it has been validated. This allows us to delay this feature to a later mome

Re: refcount btrace

2022-06-27 Thread Alexander Bluhm
On Fri, Apr 22, 2022 at 12:07:44AM +0200, Alexander Bluhm wrote: > I still think it is worth to have refcount debugging in generic > kernel dt(4). Having tools is easier than first adding printf to > hunt a bug. I see no downside. I have talked with mpi@. We both think it is useful to have refc

Re: snmpd(8): Application.c properly initialize oidbuf for appl_region

2022-06-27 Thread Theo Buehler
On Mon, Jun 27, 2022 at 12:11:42PM +0200, Martijn van Duren wrote: > When registering a region in appl_region (through appl_register) we > fill oidbuf with strlcat, but we don't start from a clean state and > might have garbage prepended. > > This oidbuf is only used on error-conditions, so it's u

snmpd(8): Application.c properly initialize oidbuf for appl_region

2022-06-27 Thread Martijn van Duren
When registering a region in appl_region (through appl_register) we fill oidbuf with strlcat, but we don't start from a clean state and might have garbage prepended. This oidbuf is only used on error-conditions, so it's unlikely to trigger with the current code. Diff below properly initializes it.

Re: kernel lock in arp

2022-06-27 Thread Alexander Bluhm
On Sat, May 21, 2022 at 10:50:28PM +0300, Vitaliy Makkoveev wrote: > This diff looks good, except the re-check after kernel lock. It???s > supposed `rt??? could became inconsistent, right? But what stops to > make it inconsistent after first unlocked RTF_LLINFO flag check? > > I think this re-chec

Re: kernel lock in arp

2022-06-27 Thread Hrvoje Popovski
On 18.5.2022. 17:31, Alexander Bluhm wrote: > Hi, > > For parallel IP forwarding I had put kernel lock around arpresolve() > as a quick workaround for crashes. Moving the kernel lock inside > the function makes the hot path lock free. I see slight prerformace > increase in my test and no lock co

Re: Check `flags' on target session, not multicast session

2022-06-27 Thread Vitaliy Makkoveev
On Mon, Jun 27, 2022 at 01:29:26AM +0300, Vitaliy Makkoveev wrote: > We should check PIPEX_SFLAGS_IP{,6}_FORWARD bits on the session which we > will output packet, not on the dummy multicast session. > > npppd(8) clears these flags before release IP address assigned to > session. So this IP addres