Re: Patch for 71.html

2022-07-14 Thread Theo Buehler
> Removes two extraneous ` (backtick) characters. > Applies quoting around URLs used as the values of href attributes. > (the / (slash) character needs to be quoted in attributes) Committed, thanks. I don't think the / needs to be quoted, but I took that part anyway for consistency with the rest o

Patch for 71.html

2022-07-14 Thread Andras Farkas
This patch does two things to fix https://www.openbsd.org/71.html Removes two extraneous ` (backtick) characters. Applies quoting around URLs used as the values of href attributes. (the / (slash) character needs to be quoted in attributes) SHA256 (71htmldiff) = 36290198de8c1232e750eeadc8b0b632370

Re: Is rdomain correct for rtable in man ifconfig?

2022-07-14 Thread Masato Asou
I agree with your explanation that the confusion stems from the fact that TUNNEL uses tunneldomain as well as MPLS. Thank you for your explanation. -- ASOU Masato From: Sebastian Benoit Date: Thu, 14 Jul 2022 10:10:52 +0200 > The manpage is correct here. > > Routing tables (rtable) and routing

interface media current data

2022-07-14 Thread Alexander Bluhm
Hi, Instead of reading the unprotected pointer ifm_cur, drivers use API to access current media and data. New function ifmedia_current() provides read access with mutex locking. If anyone has some of these old network drivers, please test setting media type with ifconfig. ok? bluhm Index: arc

Re: xhci(4)

2022-07-14 Thread Theo de Raadt
Fine. Though I think this approach will bite us in a different way one day... Mark Kettenis wrote: > While working on suspend/resume for another arm64 board, I ran into an > issue with xhci(4). We detach USB devices early on in the suspend > process. At this point we mark the USB bus as "dyi

xhci(4)

2022-07-14 Thread Mark Kettenis
While working on suspend/resume for another arm64 board, I ran into an issue with xhci(4). We detach USB devices early on in the suspend process. At this point we mark the USB bus as "dying" to make sure devices don't re-attach. We look at this "dying" flag in the interrupt handler and bail out

Please unsubscribe gt...@earthlink.net

2022-07-14 Thread Gary Tinn
There isn't an unsubscribe link on email notice, can you please unsubscribe gt...@earthlink.net. Thanks Gary Tinn

Re: Introduce fine grained pipex(4) locking

2022-07-14 Thread Alexander Bluhm
On Wed, Jul 13, 2022 at 12:49:53PM +0300, Vitaliy Makkoveev wrote: > Use per-session `pxs_mtx' mutex(9) to protect session context. Except > MPPE encryption, PPPOE sessions are mostly immutable, so no lock > required for that case. > > Global pipex(4) data is already protected by `pipex_list_mtx',

Re: dhcpleased(8): close unneeded bpf FDs

2022-07-14 Thread Dave Voutila
Florian Obser writes: > On 2022-07-12 14:35 +02, Florian Obser wrote: >> When the autoconf flag flaps around we might end up with multiple bpf >> FDs in flight. Things then get confusing. The kernel tells us we can >> read from the bpf FD but the data is actually "on the other FD", so >> read(

Re: unp_solock_peer() and READ_ONCE()

2022-07-14 Thread Vitaliy Makkoveev
On Thu, Jul 14, 2022 at 04:33:27PM +0200, Jeremie Courreges-Anglas wrote: > On Thu, Jul 14 2022, Vitaliy Makkoveev wrote: > > [...] > > > Also may be the problem lays in other layer, but triggered here... > > What is the syzkaller report that lead to this discussion? > This one: https://syzk

Re: unp_solock_peer() and READ_ONCE()

2022-07-14 Thread Jeremie Courreges-Anglas
On Thu, Jul 14 2022, Vitaliy Makkoveev wrote: [...] > Also may be the problem lays in other layer, but triggered here... What is the syzkaller report that lead to this discussion? -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: unp_solock_peer() and READ_ONCE()

2022-07-14 Thread Vitaliy Makkoveev
On Thu, Jul 14, 2022 at 02:44:16PM +0200, Alexander Bluhm wrote: > On Thu, Jul 14, 2022 at 06:16:14AM +0300, Vitaliy Makkoveev wrote: > > > On 14 Jul 2022, at 05:51, Visa Hankala wrote: > > > > > > On Thu, Jul 14, 2022 at 04:39:33AM +0300, Vitaliy Makkoveev wrote: > > >> It looks like sometimes t

Re: interface media ifm_cur

2022-07-14 Thread Vitaliy Makkoveev
On Thu, Jul 14, 2022 at 01:46:14PM +0200, Alexander Bluhm wrote: > Hi, > > Protect all writers to ifm_cur with a mutex. ifmedia_match() does > not return any pointers without lock anymore. > > ok? I like to use fmedia_get() instead fmedia_match_get(). With this change ok mvs@. > > bluhm > >

Re: unp_solock_peer() and READ_ONCE()

2022-07-14 Thread Alexander Bluhm
On Thu, Jul 14, 2022 at 06:16:14AM +0300, Vitaliy Makkoveev wrote: > > On 14 Jul 2022, at 05:51, Visa Hankala wrote: > > > > On Thu, Jul 14, 2022 at 04:39:33AM +0300, Vitaliy Makkoveev wrote: > >> It looks like sometimes the `unp_conn' doesn't reloaded in > >> the "unp->unp_conn != unp2" check, a

interface media ifm_cur

2022-07-14 Thread Alexander Bluhm
Hi, Protect all writers to ifm_cur with a mutex. ifmedia_match() does not return any pointers without lock anymore. ok? bluhm Index: dev/ic/if_wi.c === RCS file: /data/mirror/openbsd/cvs/src/sys/dev/ic/if_wi.c,v retrieving revisio

Re: bgpd more IPv6 scope_id love

2022-07-14 Thread Theo Buehler
On Thu, Jul 14, 2022 at 12:23:26PM +0200, Claudio Jeker wrote: > Noticed while syncing code. I missed some scope_id assignments and checks > in a few places. > > - VPN6 missed all of it > - in kr_redistribute6() the copy is not really needed since link local > address can not be redistributed (I

bgpd more IPv6 scope_id love

2022-07-14 Thread Claudio Jeker
Noticed while syncing code. I missed some scope_id assignments and checks in a few places. - VPN6 missed all of it - in kr_redistribute6() the copy is not really needed since link local address can not be redistributed (I still added it though) - kroute6_compare() do actually compare the scope_i

ifconfig, wireguard output less verbose, unless -A or

2022-07-14 Thread Mikolaj Kucharski
Hi, Per other thread, Theo expressed dissatisfaction with long ifconfig(8) for wg(4) interface. Stuart Henderson pointed me at direction, which below diff makes it work. I guess to questions are: - Does the behaviour of ifconfig(8) make sense? - Does the code which makes above, make sense? This

Re: ifconfig description for wireguard peers

2022-07-14 Thread Stuart Henderson
On 2022/07/14 10:57, Claudio Jeker wrote: > On Thu, Jul 14, 2022 at 10:51:42AM +0200, Stefan Sperling wrote: > > On Wed, Jul 13, 2022 at 05:13:49PM +, Mikolaj Kucharski wrote: > > > On Wed, Jul 13, 2022 at 05:43:59PM +0100, Stuart Henderson wrote: > > > > > > > > > > Not sure how to handle lon

Re: ifconfig description for wireguard peers

2022-07-14 Thread Stefan Sperling
On Thu, Jul 14, 2022 at 10:57:51AM +0200, Claudio Jeker wrote: > On Thu, Jul 14, 2022 at 10:51:42AM +0200, Stefan Sperling wrote: > > Perhaps also consider moving counters to netstat -s instead of ifconfig. > > I don't think netstat -s is a good place for per peer stats (neither is > ifconfig thou

Re: ifconfig description for wireguard peers

2022-07-14 Thread Claudio Jeker
On Thu, Jul 14, 2022 at 10:51:42AM +0200, Stefan Sperling wrote: > On Wed, Jul 13, 2022 at 05:13:49PM +, Mikolaj Kucharski wrote: > > On Wed, Jul 13, 2022 at 05:43:59PM +0100, Stuart Henderson wrote: > > > > > > > > Not sure how to handle long output in different way. If you don't > > > > spec

Re: ifconfig description for wireguard peers

2022-07-14 Thread Stefan Sperling
On Wed, Jul 13, 2022 at 05:13:49PM +, Mikolaj Kucharski wrote: > On Wed, Jul 13, 2022 at 05:43:59PM +0100, Stuart Henderson wrote: > > > > > > Not sure how to handle long output in different way. If you don't > > > specify wgdesc to the ifconfig, the diff doesn't change anything and > > > ifco

Re: cwm: remove menu-ssh

2022-07-14 Thread Mikolaj Kucharski
I find the feature very useful. It's one of the most used menus in cwm, next to exec. Does that feature really need to go? -- Regards, Mikolaj

Re: Is rdomain correct for rtable in man ifconfig?

2022-07-14 Thread Sebastian Benoit
The manpage is correct here. Routing tables (rtable) and routing domains (rdomain) are intermingled in that a rdomain has at least one rtable (with the same ID). But it can have multiple rtables, see rtable(4). There are 2 settings that can be configured: * the tunnel interfaces' rdomain, keywor

Re: dhcpleased(8): close unneeded bpf FDs

2022-07-14 Thread Paul de Weerd
On Thu, Jul 14, 2022 at 08:20:41AM +0200, Florian Obser wrote: | On 2022-07-12 14:35 +02, Florian Obser wrote: | > When the autoconf flag flaps around we might end up with multiple bpf | > FDs in flight. Things then get confusing. The kernel tells us we can | > read from the bpf FD but the data is

Re: Is rdomain correct for rtable in man ifconfig?

2022-07-14 Thread Masato Asou
Sorry, It's my mistake. I got following error: $ doas ifconfig gif0 tunneldomain 1 doas (a...@asou-curr.soum.co.jp) password: ifconfig: SIOCSLIFPHYRTABLE: Invalid argument $ Thank you. -- ASOU Masato From: YASUOKA Masahiko Date: Thu, 14 Jul 2022 15:41:54 +0900 (JST) > Hello, > > On Thu, 14

rpki-client 7.9 released

2022-07-14 Thread Sebastian Benoit
rpki-client 7.9 has just been released and will be available in the rpki-client directory of any OpenBSD mirror soon. rpki-client is a FREE, easy-to-use implementation of the Resource Public Key Infrastructure (RPKI) for Relying Parties (RP) to facilitate validation of BGP announcements. The progr