bgpd aspath_extract overflow check

2022-07-19 Thread Claudio Jeker
aspath_extract() should do at least a minimal overflow check and not access memory after the segment. Can't use fatalx here because bgpctl also uses this function. Instead return 0, that is an invalid ASN. No code will check the return value but that is fine since all callers ensure that pos does n

bgpd name struct kroute_full vars kf

2022-07-19 Thread Claudio Jeker
Use kf for all struct kroute_full variables in bgpd. This makes the code more consistent. -- :wq Claudio Index: kroute.c === RCS file: /cvs/src/usr.sbin/bgpd/kroute.c,v retrieving revision 1.273 diff -u -p -r1.273 kroute.c --- krout

Re: bgpd name struct kroute_full vars kf

2022-07-19 Thread Theo Buehler
On Tue, Jul 19, 2022 at 12:08:40PM +0200, Claudio Jeker wrote: > Use kf for all struct kroute_full variables in bgpd. This makes the code > more consistent. ok

Re: bgpd aspath_extract overflow check

2022-07-19 Thread Theo Buehler
On Tue, Jul 19, 2022 at 11:43:25AM +0200, Claudio Jeker wrote: > aspath_extract() should do at least a minimal overflow check and not > access memory after the segment. Can't use fatalx here because bgpctl > also uses this function. Instead return 0, that is an invalid ASN. > No code will check the

Re: bgpd aspath_extract overflow check

2022-07-19 Thread Claudio Jeker
On Tue, Jul 19, 2022 at 12:31:47PM +0200, Theo Buehler wrote: > On Tue, Jul 19, 2022 at 11:43:25AM +0200, Claudio Jeker wrote: > > aspath_extract() should do at least a minimal overflow check and not > > access memory after the segment. Can't use fatalx here because bgpctl > > also uses this functi

pf: pool for pf_anchor

2022-07-19 Thread Moritz Buhl
Dear tech@, I am investigating a syzkaller reproducer found in the "no output from test machine (7)" crashes: https://syzkaller.appspot.com/bug?id=d93e92fde3857c69df2cf46b4244d9814c4318a7 https://syzkaller.appspot.com/text?tag=ReproC&x=116ee2e008 The code calls DIOCXBEGIN, with different anch

Re: pf: pool for pf_anchor

2022-07-19 Thread Alexander Bluhm
On Tue, Jul 19, 2022 at 07:18:54PM +0200, Moritz Buhl wrote: > A solution would be to move the allocation of the pf_anchor struct > into a pool. One final question would be regarding the size of the > hiwat or hardlimit. Any suggestions? 10 seems way to low. We want to limit resource abuse. Bu

Re: [v3] amd64: simplify TSC sync testing

2022-07-19 Thread Masato Asou
Sorry, my latest reply. I tested your patch on my Proxmox Virtual Environment on Ryzen7 box. It works fine for me. OpenBSD 7.1-current (GENERIC.MP) #1: Wed Jul 20 14:15:23 JST 2022 a...@pve-obsd.my.domain:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 17162952704 (16367MB) avail mem =