ps(1): add -d (descendancy) option to display parent/child process relationships

2022-08-31 Thread Job Snijders
Dear all, Some ps(1) implementations have an '-d' ('descendancy') option. Through ASCII art parent/child process relationships are grouped and displayed. Here is an example: $ ps ad -O ppid,user PID PPID USER TT STATTIME COMMAND 18180 12529 job pb I+p

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Philip Guenther
On Tue, Aug 30, 2022 at 11:18 AM Moritz Buhl wrote: > the following diff only contains recvmmsg which should be the more useful > syscall of the two. > Comments inline. > --- sys/kern/syscalls.master1 Aug 2022 14:56:59 - 1.229 > +++ sys/kern/syscalls.master30 Aug 2022

Re: vnconfig: don't print device on failure

2022-08-31 Thread Theo de Raadt
Sure. Klemens Nanni wrote: > Noticed by mistake (wanted `-l'): > > # vnconfig l > vnd0 > vnconfig: VNDIOCSET: No such file or directory > > Same happens if you try to load a bogus file: > > # vnconfig ./empty > vnd0 > vnconfig: VNDIOCSET:

vnconfig: don't print device on failure

2022-08-31 Thread Klemens Nanni
Noticed by mistake (wanted `-l'): # vnconfig l vnd0 vnconfig: VNDIOCSET: No such file or directory Same happens if you try to load a bogus file: # vnconfig ./empty vnd0 vnconfig: VNDIOCSET: Input/output error In both cases, the info on

Re: installboot: macppc: fix passing explicit stage files

2022-08-31 Thread Klemens Nanni
On Wed, Aug 31, 2022 at 07:37:33PM +, Klemens Nanni wrote: > On Sun, Aug 28, 2022 at 10:22:23AM +, Klemens Nanni wrote: > > Every platform ought to set `stages', `stage1' and optionally `stage2' > > in md_init(), otherwise passing explicit files results won't work as > > `stages' is

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Jeremie Courreges-Anglas
On Tue, Aug 30 2022, Moritz Buhl wrote: > Hi tech@, > > the following diff only contains recvmmsg which should be the more useful > syscall of the two. > > I implemented some minor feedback regarding the man page and attaching > an error from recvit to the socket in case some messages were >

Re: man sh(1), fix explanation for `shift`

2022-08-31 Thread Jason McIntyre
On Wed, Aug 31, 2022 at 06:58:16PM +0200, Luka Krmpoti?? wrote: > In sh(1) manpage, this sentence explaining how shift builtin works: > > Parameters ???#??? to ???(#???n)+1??? and downwards are unset and ???#??? > > is updated to > the new number of positional parameters. > can be made clearer by

move PRU_CONNECT2 request to (*pru_connect2)()

2022-08-31 Thread Vitaliy Makkoveev
Index: sys/kern/uipc_usrreq.c === RCS file: /cvs/src/sys/kern/uipc_usrreq.c,v retrieving revision 1.181 diff -u -p -r1.181 uipc_usrreq.c --- sys/kern/uipc_usrreq.c 31 Aug 2022 21:23:02 - 1.181 +++ sys/kern/uipc_usrreq.c

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Moritz Buhl
I created a pull request on their github: https://github.com/NLnetLabs/nsd/pull/231 On Tue, Aug 30, 2022 at 04:33:10PM -0600, Todd C. Miller wrote: > On Wed, 31 Aug 2022 00:19:20 +0200, Moritz Buhl wrote: > > > On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > > > And nsd in base.

Re: installboot: sparc64: log copy of /ofwboot

2022-08-31 Thread Mark Kettenis
> Date: Wed, 31 Aug 2022 19:31:47 + > From: Klemens Nanni > > Another step towards more consistent behaviour across platforms. > > This leaves only hppa and landisk **not** logging such copies, > but I can't test on those. > > OK? ok kettenis@ > Index: sparc64_installboot.c >

Re: move PRU_SENDOOB request to (*pru_sendoob)()

2022-08-31 Thread Alexander Bluhm
On Mon, Aug 29, 2022 at 12:38:06PM +0300, Vitaliy Makkoveev wrote: > PRU_SENDOOB request always consumes passed `top' and `control' mbufs. We > don't want to have dummy m_freem(9) handlers for all protocols, so we > release passed mbufs in the pru_sendoob() EOPNOTSUPP error path. > > Also we had

Re: installboot: macppc: fix passing explicit stage files

2022-08-31 Thread Klemens Nanni
On Sun, Aug 28, 2022 at 10:22:23AM +, Klemens Nanni wrote: > Every platform ought to set `stages', `stage1' and optionally `stage2' > in md_init(), otherwise passing explicit files results won't work as > `stages' is zero-initialised and no default path is set: > > # installboot -v sd0

installboot: sparc64: log copy of /ofwboot

2022-08-31 Thread Klemens Nanni
Another step towards more consistent behaviour across platforms. This leaves only hppa and landisk **not** logging such copies, but I can't test on those. OK? Index: sparc64_installboot.c === RCS file:

libelf: disable ident strings

2022-08-31 Thread Miod Vallat
The general policy in OpenBSD is to not embed ident(1) strings in libraries. However, libelf is currently compiled with ident strings, and thus /usr/lib/libelf* are the only files in /usr/lib sporting ident strings. The following diff disables them. Index: _elftc.h

installer: macppc: denote possible answers to HFS or MBR question

2022-08-31 Thread Klemens Nanni
This question fails to adhere to our standard way of showing how to actually answer a question. OK? Spotted while looking at how macppc preps disks so I can do the same in the installboot regress tests. Index: ramdisk/install.md

man sh(1), fix explanation for `shift`

2022-08-31 Thread Luka Krmpotić
In sh(1) manpage, this sentence explaining how shift builtin works: > Parameters ‘#’ to ‘(#−n)+1’ and downwards are unset and ‘#’ is updated to the new number of positional parameters. can be made clearer by removing "and downwards" diff --git bin/ksh/sh.1 bin/ksh/sh.1 index

Re: Properly unveil(2) the unix socket file in vmctl(8)

2022-08-31 Thread Ricardo Mestre
Nevermind about the getpw change, I ran start/stop and show in between and didn't see that issue since I was running the old bin without my change. Here's the new diff to just sort those promises to the canonical order. And yes for now the unveil(2) change is just for correctness, it doesn't

Re: Properly unveil(2) the unix socket file in vmctl(8)

2022-08-31 Thread Dave Voutila
Ricardo Mestre writes: > After discussing with martijn@ if we should keep using unveil(2) (or not), in > his latest diff of further privsep'ing snmpd(8), and also after he also spoke > with deraadt@, it turns out that unix's promise in pledge(2) is not enforcing > the unix socket's file

Re: bgpd kill hash statistic imsg

2022-08-31 Thread Theo Buehler
On Wed, Aug 31, 2022 at 05:07:23PM +0200, Claudio Jeker wrote: > IMSG_CTL_SHOW_RIB_HASH is no longer used, GC it. > Also kill some global hash sizes which are not used anymore. ok tb

bgpd kill hash statistic imsg

2022-08-31 Thread Claudio Jeker
IMSG_CTL_SHOW_RIB_HASH is no longer used, GC it. Also kill some global hash sizes which are not used anymore. -- :wq Claudio Index: bgpd.h === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.h,v retrieving revision 1.451 diff -u -p -r1.451

Re: bgpctl remove hash stats

2022-08-31 Thread Theo Buehler
On Wed, Aug 31, 2022 at 04:39:35PM +0200, Claudio Jeker wrote: > bgpctl show rib mem no longer shows any hash statistics so remove that > code from bgpctl as a first step. Also since show rib mem is a single > message adjust the code to be done after the message is received. > > OK? ok

bgpctl remove hash stats

2022-08-31 Thread Claudio Jeker
bgpctl show rib mem no longer shows any hash statistics so remove that code from bgpctl as a first step. Also since show rib mem is a single message adjust the code to be done after the message is received. OK? -- :wq Claudio Index: bgpctl.c

Properly unveil(2) the unix socket file in vmctl(8)

2022-08-31 Thread Ricardo Mestre
After discussing with martijn@ if we should keep using unveil(2) (or not), in his latest diff of further privsep'ing snmpd(8), and also after he also spoke with deraadt@, it turns out that unix's promise in pledge(2) is not enforcing the unix socket's file permissions as it should. e.g. Unveiling

Re: bgpd change attr cache to use RB tree

2022-08-31 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.31 13:56:18 +0200: > Like all other hash tables use an RB tree instead. > Again the calculation of the hash can be skipped because the compare > function is probably fast enough. that sentence does parse, but i am semantically challenged by it.

Re: bgpd change attr cache to use RB tree

2022-08-31 Thread Theo Buehler
On Wed, Aug 31, 2022 at 01:56:18PM +0200, Claudio Jeker wrote: > Like all other hash tables use an RB tree instead. > Again the calculation of the hash can be skipped because the compare > function is probably fast enough. Reads fine ok tb

bgpd change attr cache to use RB tree

2022-08-31 Thread Claudio Jeker
Like all other hash tables use an RB tree instead. Again the calculation of the hash can be skipped because the compare function is probably fast enough. -- :wq Claudio ? ktrace.out ? obj Index: rde.c === RCS file:

Re: Rename global ifnet TAILQ

2022-08-31 Thread Klemens Nanni
On Wed, Aug 31, 2022 at 12:02:20PM +0200, Claudio Jeker wrote: > On Wed, Aug 31, 2022 at 08:37:06AM +, Klemens Nanni wrote: > > On Fri, Aug 26, 2022 at 06:14:44PM +, Klemens Nanni wrote: > > > Naming the list like the struct itself makes for awful grepping. > > > Distinguish the list name;

Re: Rename global ifnet TAILQ

2022-08-31 Thread Claudio Jeker
On Wed, Aug 31, 2022 at 08:37:06AM +, Klemens Nanni wrote: > On Fri, Aug 26, 2022 at 06:14:44PM +, Klemens Nanni wrote: > > Naming the list like the struct itself makes for awful grepping. > > Distinguish the list name; no functional change. > > > > Builds/runs fine on and64 and sparc64.

Re: snmpd(8): Better determining searchrange end

2022-08-31 Thread Theo Buehler
On Tue, Aug 30, 2022 at 04:31:20PM +0200, Martijn van Duren wrote: > Doing overlapping regions is hard... > > At application.c:1341 we currently assign region->ar_oid to oid. > However, with overlapping regions this can cause a recursion, because > region might be the parent of the previous

Re: Rename global ifnet TAILQ

2022-08-31 Thread Klemens Nanni
On Fri, Aug 26, 2022 at 06:14:44PM +, Klemens Nanni wrote: > Naming the list like the struct itself makes for awful grepping. > Distinguish the list name; no functional change. > > Builds/runs fine on and64 and sparc64. > Ping. deraadt pointed out how base programs used to use this