Re: help pfsync by extending pf_state_key lifetimes on pf_states

2022-12-05 Thread Alexandr Nedvedicky
Hello, On Mon, Dec 05, 2022 at 11:46:07AM +1000, David Gwynne wrote: > > yes, you're right. the diff below includes the simple fix to that. > > this demonstrates how subtle the reference counting around the trees > is though. maybe it would be more obvious to take another refcnt > before giving t

Re: help pfsync by extending pf_state_key lifetimes on pf_states

2022-12-05 Thread David Gwynne
On Mon, Dec 05, 2022 at 11:26:21AM +0100, Alexandr Nedvedicky wrote: > Hello, > On Mon, Dec 05, 2022 at 11:46:07AM +1000, David Gwynne wrote: > > > > yes, you're right. the diff below includes the simple fix to that. > > > > this demonstrates how subtle the reference counting around the trees > >

Re: lladdr support for netstart/hostname.if

2022-12-05 Thread Theo de Raadt
It is time. ok deraadt There is a man page change we've discussed which can also go in, after that I expect jmc will get involved and change it a little. Andrew and I have had another discussion about how the installer might provide a way in the installer to create these files instead (no new qu

Re: help pfsync by extending pf_state_key lifetimes on pf_states

2022-12-05 Thread Alexandr Nedvedicky
Hello, > > pf_test_rule uses the skw and sks pointers after pf_state_insert sets > them via pf_create_state. i would happily change pf_test rule so it > reads the pf_state_key pointers out of pf_state rather than carry them > around on the stack like that, but i figured the diff was big enough as

Re: riscv64: drop unused WEAK_REFERENCE macro

2022-12-05 Thread Mike Larkin
On Sat, Dec 03, 2022 at 12:16:43AM +0100, Jeremie Courreges-Anglas wrote: > > WEAK_REFERENCE seems to come from FreeBSD, it's not used in our tree. > (WEAK_ALIAS is defined a few lines above). > > ok? > ok mlarkin if you didnt get to it already > > Index: sys/arch/riscv64/include/asm.h >

Re: riscv64: use evcount_percpu(9) for clock interrupts

2022-12-05 Thread Mike Larkin
On Sat, Dec 03, 2022 at 01:15:09AM +0100, Jeremie Courreges-Anglas wrote: > > ok? > > Probably needs cheloha@'s ok but this looks ok to me. -ml > Index: clock.c > === > RCS file: /cvs/src/sys/arch/riscv64/riscv64/clock.c,v > retr

Re: riscv64: print SBI vendor/version

2022-12-05 Thread Mike Larkin
On Sat, Dec 03, 2022 at 11:48:16PM +0100, Jeremie Courreges-Anglas wrote: > > With the diff below we get more details about the SBI version running on > the machine. My Unmatched machine has OpenBSD version 0.9 but upstream > has released 1.1 since, it implements v0.2 of the SBI spec but 0.3 and

Re: riscv64: drop unused WEAK_REFERENCE macro

2022-12-05 Thread Philip Guenther
On Fri, Dec 2, 2022 at 3:17 PM Jeremie Courreges-Anglas wrote: > > WEAK_REFERENCE seems to come from FreeBSD, it's not used in our tree. > (WEAK_ALIAS is defined a few lines above). > > ok? > ok guenther@