Re: format strings in libexpat

2023-02-20 Thread Joerg Sonnenberger
On Sat, Feb 18, 2023 at 08:22:56AM +, Miod Vallat wrote: > libexpat assumes the compiler might not know of the C99 format > specifiers for ptrdiff_t and size_t, and tries to guess alternative > format strings. The problem is the printf runtime. There is no good way to detect the support

Re: rpki-client: disallow trailing garbage in signed objects

2023-02-20 Thread Job Snijders
On Tue, Feb 21, 2023 at 03:07:00AM +0100, Theo Buehler wrote: > By design of d2i, it's the caller's responsibility to check a DER object > has been fully consumed. We read files from the disk, check hashes, > parse and validate the DER we encounter, but we do not make sure that > nothing follows

rpki-client: disallow trailing garbage in signed objects

2023-02-20 Thread Theo Buehler
By design of d2i, it's the caller's responsibility to check a DER object has been fully consumed. We read files from the disk, check hashes, parse and validate the DER we encounter, but we do not make sure that nothing follows the DER blob we parsed. As Job noticed, it is possible to append data

Nuke remnants of /dev/io

2023-02-20 Thread Crystal Kolipe
The iskmemdev function checks for minor number 14 in addition to 0 and 1 on the following archs: amd64, arm64, i386, and riscv64 Device 2, 14 was traditionally /dev/io, which we don't support and so opening it will always return ENXIO from mmopen anyway. We only use iskmemdev in one place in

Enable Apollo Lake audio

2023-02-20 Thread Brian Callahan
Hello tech -- I recently found a ~5 year old laptop sitting in storage. It is an Apollo Lake machine. I think I put it in storage because it did not have working audio. I tried a -current kernel from today and found that it still did not have audio. The audio device does not attach. There is a

Re: format strings in libexpat

2023-02-20 Thread Miod Vallat
> Does this actually change something on any of our architectures? This gets rid of warnings such as: /usr/src/lib/libexpat/lib/xmlparse.c: In function 'accountingReportDiff': /usr/src/lib/libexpat/lib/xmlparse.c:7704: warning: format '%6d' expects type 'int', but argument 3 has type 'ptrdiff_t'

Re: format strings in libexpat

2023-02-20 Thread Alexander Bluhm
On Sat, Feb 18, 2023 at 08:22:56AM +, Miod Vallat wrote: > libexpat assumes the compiler might not know of the C99 format > specifiers for ptrdiff_t and size_t, and tries to guess alternative > format strings. > > The following diff relieves it of this misery (but can't be sent > up??tream,

Re: aucat -> sndiod in intro(3) manual page

2023-02-20 Thread Jason McIntyre
On Mon, Feb 20, 2023 at 02:36:10PM +0100, David Demelier wrote: > Hi, > > Just fix sndiod reference rather than aucat to sio_open in intro(3). > fixed, thanks. jmc > Index: share/man/man3/intro.3 > === > RCS file:

aucat -> sndiod in intro(3) manual page

2023-02-20 Thread David Demelier
Hi, Just fix sndiod reference rather than aucat to sio_open in intro(3). Index: share/man/man3/intro.3 === RCS file: /cvs/src/share/man/man3/intro.3,v retrieving revision 1.96 diff -u -r1.96 intro.3 --- share/man/man3/intro.3