Re: MALLOC_STATS: dump internal state and leak info via utrace(2)

2023-04-08 Thread Otto Moerbeek
On Sun, Apr 09, 2023 at 07:53:31AM +0200, Sebastien Marie wrote: > On Fri, Apr 07, 2023 at 09:52:52AM +0200, Otto Moerbeek wrote: > > > Hi, > > > > > > This is work in progress. I have to think if the flags to kdump I'm > > > introducing should be two or a single one. > > > > > > Currently, mall

Re: MALLOC_STATS: dump internal state and leak info via utrace(2)

2023-04-08 Thread Sebastien Marie
On Fri, Apr 07, 2023 at 09:52:52AM +0200, Otto Moerbeek wrote: > > Hi, > > > > This is work in progress. I have to think if the flags to kdump I'm > > introducing should be two or a single one. > > > > Currently, malloc.c can be compiled with MALLOC_STATS defined. If run > > with option D it dump

mvsw phy-mode support

2023-04-08 Thread Jonathan Matthew
On the Turris Omnia, the host can't transmit over the interface linked to the switch unless mvsw applies phy-mode settings to the port on its side, specifically the rgmii delay settings. ok? Index: mvsw.c === RCS file: /cvs/src/sys/

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-08 Thread Klemens Nanni
On Sat, Apr 08, 2023 at 10:09:11AM -0500, joshua stein wrote: > The sensor nodes (TMP0, TMP1, etc.) are hard-coded into the DSDT, so > the EC failing to read the actual sensor should still allow it to be > found. Understood, thanks. > Yes, here is a new version without that chunk. Works for me

Re: OF_getpropstr()

2023-04-08 Thread Todd C . Miller
On Sat, 08 Apr 2023 08:48:31 -0600, "Theo de Raadt" wrote: > Mark Kettenis wrote: > > > > +{ > > > + int len; > > > + > > > + len = OF_getprop(handle, prop, buf, buflen); > > > + if (buflen > 0) > > > + buf[min(len, buflen - 1)] = '\0'; > > > + > > > + return (len); > > > > I've mailed d

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-08 Thread joshua stein
On Fri, 07 Apr 2023 at 19:00:43 +, Klemens Nanni wrote: > > + sc->sc_ntempsens = 0; > > + for (i = 0; i < THINKPAD_NSENSORS - THINKPAD_SENSOR_TMP0; i++) { > > + if (thinkpad_get_temp(sc, i, &tmp) != 0) > > + break; > > doesn't this mean, that legit sensors which

Re: OF_getpropstr()

2023-04-08 Thread Theo de Raadt
Mark Kettenis wrote: > > +{ > > + int len; > > + > > + len = OF_getprop(handle, prop, buf, buflen); > > + if (buflen > 0) > > + buf[min(len, buflen - 1)] = '\0'; > > + > > + return (len); > I've mailed dlg seperately, but will raise it here also. If buflen is 0, then why call

Re: OF_getpropstr()

2023-04-08 Thread Mark Kettenis
> Date: Sat, 8 Apr 2023 13:29:25 +1000 > From: David Gwynne > > turns out OF_getprop is like memcpy, but sometimes you want something > like strlcpy. this is what OF_getpropstr aims to provide. > > i know openfirm.h is used on other archs that don't use fdt as their > backend, but i figure we ca