Re: libc: string: bcopy: get rid of unneeded goto

2017-08-24 Thread Ali H. Fardan
just noticed, memmove.c does that too: https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/lib/libc/string/memmove.c?rev=1.2=text/plain

libc: string: bcopy: get rid of unneeded goto

2017-08-24 Thread Ali H. Fardan
Index: bcopy.c === RCS file: /cvs/src/lib/libc/string/bcopy.c,v retrieving revision 1.7 diff -u -p -r1.7 bcopy.c --- bcopy.c 31 Aug 2015 02:53:57 - 1.7 +++ bcopy.c 24 Aug 2017 19:16:30 - @@ -53,7 +53,7 @@

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-05 Thread Ali H. Fardan
On 2016-09-05 11:03, Tom Cosgrove wrote: Ali H. Fardan <r...@firemail.cc> 5-Sep-16 08:47 >>> On 2016-09-05 10:44, David Gwynne wrote: >> On 5 Sep 2016, at 17:39, Ali H. Fardan <r...@firemail.cc> wrote: >> >> and why is he telling me this? I just said if

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-05 Thread Ali H. Fardan
On 2016-09-05 11:04, Otto Moerbeek wrote: On Mon, Sep 05, 2016 at 10:47:06AM +0300, Ali H. Fardan wrote: On 2016-09-05 10:44, David Gwynne wrote: > > On 5 Sep 2016, at 17:39, Ali H. Fardan <r...@firemail.cc> wrote: > > > > and why is he telling me this? I just

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-05 Thread Ali H. Fardan
On 2016-09-05 10:44, David Gwynne wrote: On 5 Sep 2016, at 17:39, Ali H. Fardan <r...@firemail.cc> wrote: and why is he telling me this? I just said if the destination is a pointer to char, how would a function automagically allocate a size for it? its not a pointer to a char, its a p

Fwd: Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-05 Thread Ali H. Fardan
i" <m...@iinet.net.au> To: "Ali H. Fardan" <r...@firemail.cc>, Otto Moerbeek <o...@drijf.net> Cc: David Gwynne <da...@gwynne.id.au>, tech <tech@openbsd.org>, owner-t...@openbsd.org FWIW the reply seemed like a proper statement to me. The manual pag

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-05 Thread Ali H. Fardan
On 2016-09-05 08:52, Otto Moerbeek wrote: On Mon, Sep 05, 2016 at 08:05:40AM +0300, Ali H. Fardan wrote: On 2016-09-05 08:01, David Gwynne wrote: > > On 5 Sep 2016, at 12:13, Ali H. Fardan <r...@firemail.cc> wrote: > > > > You can't specify a buffer size

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-04 Thread Ali H. Fardan
On 2016-09-05 08:01, David Gwynne wrote: On 5 Sep 2016, at 12:13, Ali H. Fardan <r...@firemail.cc> wrote: You can't specify a buffer size in asprintf() therefore, it is not secure, you can see that snprintf() does write to the `i` bytes to the buffer asprintf allocates the memory it

Re: mount(8): strlen + malloc + snprintf == asprintf

2016-09-04 Thread Ali H. Fardan
You can't specify a buffer size in asprintf() therefore, it is not secure, you can see that snprintf() does write to the `i` bytes to the buffer Raiz Original Message Subject: mount(8): strlen + malloc + snprintf == asprintf Date: 2016-09-04 19:47 From: Michal Mazurek

does true.c need command line arguments?

2016-07-04 Thread Ali H. Fardan
I'm just wondering if true.c does really need int argc and char *argv[] rather than void (src/usr.bin/true/true.c), if not: Index: true.c === RCS file: /cvs/src/usr.bin/true/true.c,v retrieving revision 1.1 diff -r1.1 true.c 6c6 <