constify ether_sprintf and a few globals

2022-12-14 Thread David Hill
Hello - This constify's ether_sprintf and some globals and adjusts the users accordingly. Feel free to commit if OK. Index: dev/ic/if_wi_hostap.c === RCS file: /cvs/src/sys/dev/ic/if_wi_hostap.c,v retrieving revision 1.52 diff -u -p

Re: splassert on boot

2022-11-23 Thread David Hill
On 11/23/22 15:18, Vitaliy Makkoveev wrote: On Wed, Nov 23, 2022 at 02:59:05PM -0500, David Hill wrote: Hello - I am seeing splasserts on boot (before kern.splassert=2 can be set) with -current. spdmem0 at iic0 addr 0x50: 8GB DDR3 SDRAM PC3-12800 SO-DIMM isa0 at pcib0 isadma0 at isa0

splassert on boot

2022-11-23 Thread David Hill
Hello - I am seeing splasserts on boot (before kern.splassert=2 can be set) with -current. spdmem0 at iic0 addr 0x50: 8GB DDR3 SDRAM PC3-12800 SO-DIMM isa0 at pcib0 isadma0 at isa0 vga0 at isa0 port 0x3b0/48 iomem 0xa/131072 wsdisplay at vga0 not configured pcppi0 at isa0 port 0x61 s

Re: possible fix for Xorg 21.1.1 crashes

2021-11-17 Thread David Hill
On 11/16/21 18:21, Matthieu Herrb wrote: On Tue, Nov 16, 2021 at 11:26:40PM +0100, Matthieu Herrb wrote: Hi, I think I found the bug that causes crashes in X for some people. If X started crashing since you upgraded to the last snapshots, can you try the patch below ? get /usr/xenocara from

postgresql 12 - could not open shared memory segment

2020-12-03 Thread David Hill
Hello - I am using postgresql 12 on OpenBSD 6.8. After a while of running, postgresql starts throwing out errors: 2020-12-03 08:18:35.052 CST [60288] ERROR: could not open shared memory segment "/PostgreSQL.1780529043": No such file or directory 2020-12-03 08:18:35.052 CST [40083] ERROR:

Re: monotonic clock going backwards?

2019-06-06 Thread David Hill
On 6/6/19 8:49 AM, Mark Kettenis wrote: From: David Hill Date: Thu, 6 Jun 2019 08:22:06 -0400 On 6/6/19 6:56 AM, Scott Cheloha wrote: On Wed, Jun 05, 2019 at 08:33:56PM -0400, David Hill wrote: Hello - I noticed some negative roundtrip times when running traceroute, which uses the

Re: monotonic clock going backwards?

2019-06-06 Thread David Hill
On 6/6/19 6:56 AM, Scott Cheloha wrote: On Wed, Jun 05, 2019 at 08:33:56PM -0400, David Hill wrote: Hello - I noticed some negative roundtrip times when running traceroute, which uses the monotonic clock to calculate the RTT. If I run the following code, it eventually bombs.?? It bombs

monotonic clock going backwards?

2019-06-05 Thread David Hill
Hello - I noticed some negative roundtrip times when running traceroute, which uses the monotonic clock to calculate the RTT. If I run the following code, it eventually bombs.  It bombs quick if I launch Firefox. timespeccmp failed tp1 s:103780 n:63101042 tp2 s:103779 n:761117849 #

Re: iked: fix retransmission bug after simultaneous rekeying

2019-04-22 Thread David Hill
On Thu, Apr 11, 2019 at 04:32:28PM +0200, Tobias Heider wrote: > Hi, > > this patch fixes a bug that appears after simultaneous > rekeying of the ikesa. Currently the initiator does not set it's > IKED_REQ_INFORMATIONAL flag when sending the delete request and thus rejects > the response to the DE

diff - set ipv6 tclass

2018-10-30 Thread David Hill
Hello - ftp, ntpd, and telnet set IPTOS_LOWDELAY/IPTOS_THROUGHPUT for IPv4 sockets. Should we do it for IPv6 as well? I used IPTOS_DCSP_AF21/IPTOS_DSCP_CS1 to match the values ssh uses by default. Thoughts? Index: usr.bin/ftp/ftp.c ==

diff: split ctloutput into getopt/setopt

2018-10-18 Thread David Hill
Hello - This diff splits the ctloutput functions into getopt/setopt, which could offer more fine-grained locking. It also removes some indentation and imo is easier to read. Thoughts? Index: net/rtsock.c === RCS file: /cvs/src/sys/

re(4) watchdog timeouts - possible fix

2018-08-31 Thread David Hill
Hello - If I start a certain app that sends a large amount of data to many hosts, I get: re0: watchdog timeout re0: watchdog timeout The diff below is what em(4) does and I am no longer able to cause watchdog timeouts on my re(4). Does this seem correct or more of a hack? Index: dev/ic/re.c ==

more netinet bcopy -> mem{cpy|move}

2018-04-09 Thread David Hill
Hello - Two bcopy->memmove conversions where src and dst are in the same memory space. Perhaps not overlapping, but just being safe. Convert the bcopy's in tcp_respond to memcpy since the destination is a new mbuf header. OK? Index: netinet/ip_ah.c =

Re: ufs free()

2018-03-31 Thread David Hill
On Sat, Mar 31, 2018 at 11:15:35PM +0200, Christian Weisgerber wrote: > David Hill: > > > This diff adds sizes to free(), which completes ufs/ffs. > > It's broken at least for softdep+UFS2. This chunk blows up: > > > --- ufs/ffs/ffs_softdep.c 10 Feb 2018 05:24

arch/amd64 free

2018-03-31 Thread David Hill
Hello - This diff is more involved. In est_acpi_pss_changed, a new table is allocated but n isn't updated, which keep tracks of the number allocated. Set it. In est_init, fake_table was being allocated with 3. Change that to allocate exactly what is need by setting n earlier. Regarding the i

mfs free

2018-03-31 Thread David Hill
Add the free size. (allocated in mfs_vfsops.c) mfsp = malloc(sizeof *mfsp, M_MFSNODE, M_WAITOK | M_ZERO); devvp->v_data = mfsp; OK? Index: ufs/mfs/mfs_vnops.c === RCS file: /cvs/src/sys/ufs/mfs/mfs_vnops.c,v retrievi

netinet memcpy/free

2018-03-31 Thread David Hill
Hello - memcpy can be used on freshly allocated memory. Fill in the free size for it. OK? Index: netinet/tcp_subr.c === RCS file: /cvs/src/sys/netinet/tcp_subr.c,v retrieving revision 1.169 diff -u -p -r1.169 tcp_subr.c --- netinet

ufs free()

2018-03-28 Thread David Hill
Hello - This diff adds sizes to free(), which completes ufs/ffs. OK? Index: ufs/ffs/ffs_inode.c === RCS file: /cvs/src/sys/ufs/ffs/ffs_inode.c,v retrieving revision 1.76 diff -u -p -r1.76 ffs_inode.c --- ufs/ffs/ffs_inode.c 27 Feb 2

Re: use hashfree on pcb hash tables

2018-03-28 Thread David Hill
round #2. keep track of size (num of elements) in the inpcbtable struct. passes regress tests. OK? Index: netinet/in_pcb.c === RCS file: /cvs/src/sys/netinet/in_pcb.c,v retrieving revision 1.228 diff -u -p -r1.228 in_pcb.c --- netin

Re: use hashfree on pcb hash tables

2018-03-27 Thread David Hill
Ignore for now. A lovely regress/ test exposes a problem in my diff. :) On Tue, Mar 27, 2018 at 01:11:19PM -0400, David Hill wrote: > Hello - > > The hash tables are allocated with hashinit, so free them with hashfree. > This gives the bonus of calling free() with a size as well. >

use hashfree on pcb hash tables

2018-03-27 Thread David Hill
Hello - The hash tables are allocated with hashinit, so free them with hashfree. This gives the bonus of calling free() with a size as well. OK? Index: in_pcb.c === RCS file: /cvs/src/sys/netinet/in_pcb.c,v retrieving revision 1.228

netinet bcopy -> memcpy/memmove

2018-03-27 Thread David Hill
Hello - A few bcopy conversions to memcpy where the memory does not overlap, otherwise memmove. OK? Index: netinet/ip_ah.c === RCS file: /cvs/src/sys/netinet/ip_ah.c,v retrieving revision 1.138 diff -u -p -r1.138 ip_ah.c --- netine

netinet6 - bcopy -> memcpy

2018-03-13 Thread David Hill
Hello - A few bcopy to memcpy conversions where the memory does not overlap. OK? Index: netinet6/icmp6.c === RCS file: /cvs/src/sys/netinet6/icmp6.c,v retrieving revision 1.221 diff -u -p -r1.221 icmp6.c --- netinet6/icmp6.c14 D

Re: tcp timeout milliseconds

2018-02-06 Thread David Hill
OK dhill@ On Tue, Feb 06, 2018 at 05:10:17PM +0100, Alexander Bluhm wrote: > Hi, > > Historically TCP timeouts were implemented with pr_slowtimo and > pr_fasttimo. That is the reason why we have two timeout mechanisms > with complicated ticks calculation. > > I would like to move to millisecond

Re: pf statekey inp assertion failed

2017-06-20 Thread David Hill
On Wed, Jun 21, 2017 at 01:21:50AM +0200, Alexander Bluhm wrote: > Hi, > > I saw a crash on an OpenBSD 6.1 based system when a kassert in > pf_state_key_unref() was triggert. > > kernel diagnostic assertion "(sk->inp == NULL) || (sk->inp->inp_pf_sk == > NULL)" > failed: file "../../../../../ne

ip_esp/ip_mroute bcopy->mem*

2017-04-06 Thread David Hill
Hello - Convert bcopy to memcpy where the memory does not overlap, otherwise, use memmove. While here, change some previous conversions to a simple assignment. OK? Index: ip_esp.c === RCS file: /cvs/src/sys/netinet/ip_esp.c,v retri

ip6_input.c and mld6.c bcopy -> memcpy

2017-04-05 Thread David Hill
Hello - The following diff removes bcopy from ip6_input.c and mld6.c by using memcpy as the memory does not overlap. OK? Index: ip6_input.c === RCS file: /cvs/src/sys/netinet6/ip6_input.c,v retrieving revision 1.181 diff -u -p -r1.1

ipcomp bcopy -> mem*

2017-03-24 Thread David Hill
Hello - This diff converts the existing three bcopy's to memcpy or memmove. The memcpy's are on freshly malloc'd memory so no overlap. OK? Index: netinet/ip_ipcomp.c === RCS file: /cvs/src/sys/netinet/ip_ipcomp.c,v retrieving revis

Re: ip_ipip.c / gif(4) percpu counters

2017-03-09 Thread David Hill
On Thu, Mar 09, 2017 at 03:49:21PM +0100, Jeremie Courreges-Anglas wrote: > Martin Pieuchot writes: > > > On 08/03/17(Wed) 12:03, Jeremie Courreges-Anglas wrote: > >> [...] > >> So here's a refreshed diff that initializes the counters directly from > >> ip_init(). I remove the ipip_init() wrapp

Re: Enable TCP ECN by default (for inbound)

2017-03-04 Thread David Hill
On Fri, Oct 07, 2016 at 11:05:28PM -0400, David Hill wrote: > Hello - > > Many operating systems out there are starting to enable TCP ECN by > default, most inbound-only. Linux, FreeBSD, Apple MacOS and iOS. > > This diff mimicks the FreeBSD diff found at > http://marc.in

Re: pr_output variable arguments

2017-03-03 Thread David Hill
Much easier to read as well. OK On Fri, Mar 03, 2017 at 03:49:08PM +0100, Alexander Bluhm wrote: > Hi, > > I prefer compiler checks over variable argument lists. > So lets convert the pr_output functions. > > ok? > > bluhm > > Index: net/pfkey.c > =

ntp_update_second - removed unused var

2017-03-02 Thread David Hill
Hello - time_t *sec is unused in ntp_update_second. OK? Index: kern/kern_tc.c === RCS file: /cvs/src/sys/kern/kern_tc.c,v retrieving revision 1.30 diff -u -p -r1.30 kern_tc.c --- kern/kern_tc.c 9 Feb 2017 20:15:28 - 1.

Re: C99 initializers for domains

2017-03-01 Thread David Hill
OK On Wed, Mar 01, 2017 at 01:40:58PM +0100, Martin Pieuchot wrote: > I converted the declarations when I audited the existing 'dom_init' > functions. > > ok? > > Index: kern/uipc_proto.c > === > RCS file: /cvs/src/sys/kern/uipc_pro

Re: make sosetopt responsible for m_free

2017-02-21 Thread David Hill
On Mon, Feb 06, 2017 at 01:16:45PM +0100, Martin Pieuchot wrote: > On 03/02/17(Fri) 11:02, David Hill wrote: > > On Fri, Feb 03, 2017 at 09:50:40AM +0100, Martin Pieuchot wrote: > > > On 02/02/17(Thu) 12:12, David Hill wrote: > > > > On Thu, Feb 02, 2017 at 09:34:07A

Re: c99 initialize struct protosw

2017-02-21 Thread David Hill
Here is an updated diff without explicitly setting 0/NULL. Index: kern/uipc_proto.c === RCS file: /cvs/src/sys/kern/uipc_proto.c,v retrieving revision 1.11 diff -u -p -r1.11 uipc_proto.c --- kern/uipc_proto.c 5 Feb 2017 07:57:08 -00

ip6_ctloutput - check invalid level first

2017-02-20 Thread David Hill
Hello - The *ctloutput functions all check for an invalid level first, except ip6_ctloutput. This diff makes ip6_ctloutput do the same. As a bonus, we save on indentation. No functional change. Index: netinet6/ip6_output.c === RC

Re: c99 initialize struct protosw

2017-02-18 Thread David Hill
On Sat, Feb 18, 2017 at 09:22:44PM -0500, David Hill wrote: > Hello - > > This moves the 'struct protosw' declarations to use C99 initializers. > Requested by mpi@ > Apologies for not explaining the reason for the diff. It would allow us to easily grep for a member,

c99 initialize struct protosw

2017-02-18 Thread David Hill
Hello - This moves the 'struct protosw' declarations to use C99 initializers. Requested by mpi@ Index: kern/uipc_proto.c === RCS file: /cvs/src/sys/kern/uipc_proto.c,v retrieving revision 1.11 diff -u -p -r1.11 uipc_proto.c --- kern/

Re: ipcomp ipv6 output

2017-02-17 Thread David Hill
OK. On Fri, Feb 17, 2017 at 03:09:25PM +0100, Alexander Bluhm wrote: > Hi, > > When using ipcomp(4) with IPv6 transport mode I get this error: > > ping6: sendmsg: Protocol family not supported > > The break in the switch statement is missing since rev 1.1 from 2001. > So I am the first one test

Re: ipsec output failure counter

2017-02-07 Thread David Hill
OK once the XXX from ip_esp.c is removed too. On Tue, Feb 07, 2017 at 06:15:03PM +0100, Alexander Bluhm wrote: > Hi, > > As mentioned before, IPsec packets could be dropped unaccounted if > output after crypto failed. Add a counter for that case. > > ok? > > bluhm > > Index: sys/netinet/ip_

Re: make sosetopt responsible for m_free

2017-02-03 Thread David Hill
On Fri, Feb 03, 2017 at 09:50:40AM +0100, Martin Pieuchot wrote: > On 02/02/17(Thu) 12:12, David Hill wrote: > > On Thu, Feb 02, 2017 at 09:34:07AM +0100, Martin Pieuchot wrote: > > > On 01/02/17(Wed) 19:27, David Hill wrote: > > > > Hello - > > > > &g

Re: make sosetopt responsible for m_free

2017-02-02 Thread David Hill
On Thu, Feb 02, 2017 at 09:34:07AM +0100, Martin Pieuchot wrote: > On 01/02/17(Wed) 19:27, David Hill wrote: > > Hello - > > > > This diff makes sosetopt responsible for m_free which is much simpler. > > Requested by bluhm@ > > I'd suggest to move the m_fr

make sosetopt responsible for m_free

2017-02-01 Thread David Hill
Hello - This diff makes sosetopt responsible for m_free which is much simpler. Requested by bluhm@ Index: kern/uipc_socket.c === RCS file: /cvs/src/sys/kern/uipc_socket.c,v retrieving revision 1.176 diff -u -p -r1.176 uipc_socket.c

Re: Help with the NET_LOCK()

2017-01-31 Thread David Hill
On Tue, Jan 31, 2017 at 09:11:37PM +0100, Alexander Bluhm wrote: > On Tue, Jan 31, 2017 at 12:14:35PM -0500, David Hill wrote: > > with mpi@'s suggestion to pass a struct mbuf * > > We call mbuf variables m and mbuf pointer mp. So you should rename > *mp to m. > >

Re: Help with the NET_LOCK()

2017-01-31 Thread David Hill
On Tue, Jan 31, 2017 at 10:43:26AM +0100, Martin Pieuchot wrote: > On 27/01/17(Fri) 14:33, David Hill wrote: > > [...] > > Forgot a file... Try this: > > Is it now possible to pass a 'struct mbuf *' instead of a 'struct mbuf **' > to the pr_ctlout

uvm: free sizes diff

2017-01-30 Thread David Hill
Hello - The following diff adds free sizes to free() calls in uvm/. Only one remaining in uvm/. Index: uvm/uvm_amap.c === RCS file: /cvs/src/sys/uvm/uvm_amap.c,v retrieving revision 1.78 diff -u -p -r1.78 uvm_amap.c --- uvm/uvm_amap

Re: Help with the NET_LOCK()

2017-01-27 Thread David Hill
On Fri, Jan 27, 2017 at 08:09:36PM +0100, Hrvoje Popovski wrote: > On 27.1.2017. 19:14, David Hill wrote: > >> splassert: yield: want 0 have 1 > >> Starting stack trace... > >> yield() at yield+0xac > >> pool_get() at pool_get+0x1ca > >> m_get() a

Re: Help with the NET_LOCK()

2017-01-27 Thread David Hill
On Wed, Jan 25, 2017 at 11:14:57AM -0500, David Hill wrote: > On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > > I just enabled the NET_LOCK() again and I'm looking for test reports. > > Please go build a kernel from sources or wait for the next snapshot, &

ip6_output: copypktopts - drop canwait

2017-01-26 Thread David Hill
Hi - copypktopts is only called by ip6_setpktopts with M_NOWAIT. Drop canwait to make this simpler and more readable. Index: ip6_output.c === RCS file: /cvs/src/sys/netinet6/ip6_output.c,v retrieving revision 1.221 diff -u -p -r1.22

Re: Help with the NET_LOCK()

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 11:11:03AM -0500, David Hill wrote: > On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > > I just enabled the NET_LOCK() again and I'm looking for test reports. > > Please go build a kernel from sources or wait for the next snapshot, &

Re: Help with the NET_LOCK()

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the

Re: Help with the NET_LOCK()

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the

Re: Help with the NET_LOCK() - socreate

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 07:04:19PM +0100, Alexander Bluhm wrote: > On Wed, Jan 25, 2017 at 11:02:22AM -0500, David Hill wrote: > > splassert: yield: want 0 have 1 > > Starting stack trace... > > yield() at yield+0xac > > pool_get() at pool_get+0x1ca > > socreate(

Re: Help with the NET_LOCK()

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the

Re: Help with the NET_LOCK()

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the

Re: Help with the NET_LOCK() - socreate

2017-01-25 Thread David Hill
On Wed, Jan 25, 2017 at 04:32:25PM +1000, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the

Re: bluhm's splsoftassert

2016-10-18 Thread David Hill
On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: > On 20 September 2016 at 15:55, Alexander Bluhm > wrote: > > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > >> With bluhm's r1.160 uipc_socket.c. > > > > With splsoftne

patch: netstat -P - mention allowkmem

2016-10-11 Thread David Hill
Hello - netstat -P now requires kern.allowkmem to be set. Index: netstat.1 === RCS file: /cvs/src/usr.bin/netstat/netstat.1,v retrieving revision 1.79 diff -u -p -r1.79 netstat.1 --- netstat.1 1 Sep 2016 14:20:13 - 1.79 +

Enable TCP ECN by default (for inbound)

2016-10-07 Thread David Hill
Hello - Many operating systems out there are starting to enable TCP ECN by default, most inbound-only. Linux, FreeBSD, Apple MacOS and iOS. This diff mimicks the FreeBSD diff found at http://marc.info/?l=freebsd-commits-all&m=146369644516347&w=2 It modifies the net.inet.tcp.ecn from an off and

Re: Help me testing the netlock

2016-10-06 Thread David Hill
Hi Martin - As soon as machine boots and first packet hits the VPN, it hits the assertion: rw_status(&netlock) == RW_WRITE (hand-typed) TID PID UID PRFLAGS PFLAGS CPU COMMAND *78967 78967 0 0x14000 0x200 1 crypto __assert at0x25 ip_output() at 0x843 ipsp_proces

Re: my final netinet6 bcopy->memcpy

2016-09-30 Thread David Hill
Ping. On Mon, Sep 19, 2016 at 09:22:50PM -0400, David Hill wrote: > Hello - > > Here are the final bcopy->memcpy conversions in netinet6 that I am > comfortable with. There is also one (bcmp()) to (memcmp() != 0) > conversion since the memory is not overlapping. >

Re: splassert: sorwakeup: want 5 have 4

2016-09-26 Thread David Hill
On Mon, Sep 26, 2016 at 01:55:01PM +0100, Stuart Henderson wrote: > Seen about a dozen times on a box doing ospfd + ospf6d (for internal > routes), bgpd (for default route) + isakmpd, shortly after startup > after updating: > > splassert: sorwakeup: want 5 have 4

Re: bluhm's splsoftassert

2016-09-21 Thread David Hill
On Wed, Sep 21, 2016 at 12:32:50PM -0400, David Hill wrote: > Hit another. > > splassert: sorwakeup: want 5 have 0 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > route_input() at route_input+0x284 > ifioctl() at i

Re: bluhm's splsoftassert

2016-09-21 Thread David Hill
Hit another. splassert: sorwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 route_input() at route_input+0x284 ifioctl() at ifioctl+0x765 sys_ioctl() at sys_ioctl+0x196 syscall() at syscall+0x27b --- syscall (number 54) --- end o

remove splsoftnet from *_clone_destroy

2016-09-20 Thread David Hill
Hello - I believe this is correct. After mikeb@ committed destroying cloneable interfaces under splsoftnet, these aren't needed anymore. Index: if_mpe.c === RCS file: /cvs/src/sys/net/if_mpe.c,v retrieving revision 1.54 diff -u -p -

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 05:04:02PM +0200, Mike Belopuhov wrote: > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > More... > > > > > > splassert: sorwakeup: want

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > More... > > splassert: sorwakeup: want 5 have 0 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > route_input() at route_input+0x284 > pflog_clone_create

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
More... splassert: sorwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 route_input() at route_input+0x284 pflog_clone_create() at pflog_clone_create+0xa4 if_clone_create() at if_clone_create+0x7f ifioctl() at ifioctl+0x35a sys_io

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
Another splassert: sowwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sowwakeup() at sowwakeup+0x27 uipc_usrreq() at uipc_usrreq+0xfd sys_shutdown() at sys_shutdown+0x67 syscall() at syscall+0x27b --- syscall (number 134) --- end of kernel end trace frame: 0

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 03:16:50PM +0200, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > > With bluhm's r1.160 uipc_socket.c. > > Here are the first ones that were detected. > > Thanks for the fast report. > > So fifo works

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
And another. splassert: sorwakeup: want 5 have 4 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 pfkey_sendup() at pfkey_sendup+0x99 pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x226 pfkeyv2_expire() at pfkeyv2_expire+0x18d tdb_soft_timeout() at tdb

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
Another... splassert: sorwakeup: want 5 have 4 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 pfkey_sendup() at pfkey_sendup+0x99 pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x226 pfkeyv2_expire() at pfkeyv2_expire+0x18d tdb_timeout() at tdb_timeou

bluhm's splsoftassert

2016-09-20 Thread David Hill
Hello - With bluhm's r1.160 uipc_socket.c. Here are the first ones that were detected. splassert: sowwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sowwakeup() at sowwakeup+0x27 unp_connect2() at unp_connect2+0x62 fifo_open() at fifo_open+0x244 VOP_OPEN()

netinet/ ansify

2016-09-19 Thread David Hill
Hello - Ansify netinet/ Index: ip_ecn.c === RCS file: /cvs/src/sys/netinet/ip_ecn.c,v retrieving revision 1.7 diff -u -p -r1.7 ip_ecn.c --- ip_ecn.c19 Dec 2014 17:14:40 - 1.7 +++ ip_ecn.c20 Sep 2016 01:54:47 - @@

my final netinet6 bcopy->memcpy

2016-09-19 Thread David Hill
Hello - Here are the final bcopy->memcpy conversions in netinet6 that I am comfortable with. There is also one (bcmp()) to (memcmp() != 0) conversion since the memory is not overlapping. This, with the last netinet6 diff, has dropped the number of bcopy() calls from 62 to 29 in netinet6/ Index:

netinet/tcp_input.c syn_cache_get diff

2016-09-18 Thread David Hill
Hello - Make sure we keep TF_NOPUSH set if TCP_NOPUSH was set. FreeBSD has the same: https://github.com/freebsd/freebsd/blob/c9af4f2541fd437e0805365fbeec46d69e033310/sys/netinet/tcp_syncache.c#L860 Index: netinet/tcp_input.c === RC

crypto/ bcopy->memcpy

2016-09-16 Thread David Hill
Hello - Here are a few bcopy to memcpy conversions for crypto/ Index: crypto/crypto.c === RCS file: /cvs/src/sys/crypto/crypto.c,v retrieving revision 1.77 diff -u -p -r1.77 crypto.c --- crypto/crypto.c 15 Sep 2016 02:00:17 -

netinet bcopy->memcpy

2016-09-15 Thread David Hill
Hello - Here is another diff to switch some bcopy's to memcpy's. Most bcopy's are on freshly alloc'd memory. for netinet/ Index: ip_ah.c === RCS file: /cvs/src/sys/netinet/ip_ah.c,v retrieving revision 1.122 diff -u -p -r1.122 ip_ah

netinet6 bcopy->memcpy

2016-09-07 Thread David Hill
Hello - Here is a diff to switch some bcopy's to memcpy's. Most bcopy's are on freshly alloc'd memory. Index: ip6_output.c === RCS file: /cvs/src/sys/netinet6/ip6_output.c,v retrieving revision 1.213 diff -u -p -r1.213 ip6_output.c

Re: netinet6 free() diff

2016-08-19 Thread David Hill
Hello - Regenerated diff against -current. Index: netinet6/frag6.c === RCS file: /cvs/src/sys/netinet6/frag6.c,v retrieving revision 1.67 diff -u -p -r1.67 frag6.c --- netinet6/frag6.c7 Mar 2016 18:44:00 - 1.67 +++ net

netinet6 free() diff

2016-07-30 Thread David Hill
Hello - Here is a diff to add free sizes to netinet6/ Index: netinet6/frag6.c === RCS file: /cvs/src/sys/netinet6/frag6.c,v retrieving revision 1.67 diff -u -p -r1.67 frag6.c --- netinet6/frag6.c7 Mar 2016 18:44:00 - 1.

Re: nfs_vnops: nfs_lookitup - uninitialized var

2016-06-13 Thread David Hill
Any thoughts on this? On Mon, Jun 06, 2016 at 01:36:05PM -0400, David Hill wrote: > Hello - > > Clang reports a possible user of an uninitalized variable in > nfs_vnops.c line 2605. > > attrflag is uninitialized when calling nfsm_postop_attr(), which is a > macro that

nfs_vnops: nfs_lookitup - uninitialized var

2016-06-06 Thread David Hill
Hello - Clang reports a possible user of an uninitalized variable in nfs_vnops.c line 2605. attrflag is uninitialized when calling nfsm_postop_attr(), which is a macro that only sets attrflag if (info.nmi_mrep != NULL). I am not sure if that is possible, but maybe a KASSERT(info.nmi_mrep != NULL

pcmcia unused function diff

2016-06-02 Thread David Hill
Hello - Remove unused functions. Index: dev/pcmcia/pcmcia.c === RCS file: /cvs/src/sys/dev/pcmcia/pcmcia.c,v retrieving revision 1.46 diff -u -p -r1.46 pcmcia.c --- dev/pcmcia/pcmcia.c 8 Oct 2012 21:47:50 - 1.46 +++ dev/pc

Re: xhci(4) vs BIOS

2016-05-31 Thread David Hill
On Tue, May 31, 2016 at 06:43:16PM +0200, Martin Pieuchot wrote: > I finally got my hands on a DELL Optiplex 3020. The BIOS on this > machines uses the xHCI controller to handle the keyboard and mouse. > > Turns out that I badly copy/pasted the ehci(4) code to take over the > HC from the BIOS. W

Re: kernel panic - rtable_match

2016-05-27 Thread David Hill
Great! I appreciate the commit hint. Thanks On Fri, May 27, 2016 at 10:46:32PM +0100, Stuart Henderson wrote: > On 2016/05/27 17:29, David Hill wrote: > > Hello - > > > > Running openbsd current via cvs from today.. > > > > My machine keeps panic'ing wi

kernel panic - rtable_match

2016-05-27 Thread David Hill
Hello - Running openbsd current via cvs from today.. My machine keeps panic'ing with a uvm_fault in rtable_match. It locks my whole machine up, so I am unable to type anything. Perhaps someone can provide me some debugging printf's? uvm_fault(0x81945e00, 0x1, 0, 1) -> e kernel: page fau

Re: [diff] xhci intel port route freeze

2016-02-06 Thread David Hill
Ugh, not enough testing. Breaks again on resume. Ignore this diff. Too excited about being able to charge my phone with my laptop :) - David

[diff] xhci intel port route freeze

2016-02-06 Thread David Hill
Hello - Looking at the FreeBSD code, their xhci_pci_port_route function is called on activation and not on attach. OpenBSD calles it in xhci_pci_attach and xhci_pci_activate. If I remove it from attach, all my usb devices attach and no longer lock the machine. ugen1 at uhub4 port 2 "Apple Inc. i

[diff] IFQ has its own protection

2016-01-13 Thread David Hill
Hello - IFQ has its own protection, so no need for splnet/splx. if_gif.c - use for (;;) to match the other drivers. Index: net/if_gif.c === RCS file: /cvs/src/sys/net/if_gif.c,v retrieving revision 1.83 diff -u -p -r1.83 if_gif.c -

uvm_io: uiomovei -> uiomove

2015-12-31 Thread David Hill
Hello sz is type vsize_t, and vsize_t and vaddr_t are unsigned long on every arch, so I believe this can safely be converted. vaddr_t baseva, endva, pageoffset, kva; vsize_t chunksz, togo, sz; - David Index: uvm/uvm_io.c ==

Re: initial 11n support for iwn (n, not m)

2015-12-18 Thread David Hill
On Fri, Dec 18, 2015 at 08:52:07PM +, Stuart Henderson wrote: > On 2015/12/17 19:43, Frank Groeneveld wrote: > > iwn0: fatal firmware error > > So this firmware crash... > > > firmware error log: > > error type = "UNKNOWN" (0x14E2) > > program counter = 0x00018100 > > source li

Re: initial 11n support for iwn (n, not m)

2015-12-16 Thread David Hill
Debugging cranked. Interesting final notification... I do not see a #define for type 20. I wonder if that is the culprit. ... rxon chan 11 flags 44008035 cck f ofdm 15 setting TX power adding BSS node setting link quality for node 0 setting initial differential gains sending request for statis

Re: initial 11n support for iwn (n, not m)

2015-12-16 Thread David Hill
On Wed, Dec 16, 2015 at 05:15:27PM +0100, Stefan Sperling wrote: > On Wed, Dec 16, 2015 at 10:14:49AM -0500, David Hill wrote: > > Hi Stefan - > > > > Thanks for the 11n work! > > > > Unfortunately, your diff breaks iwn on my machine. > > > >

Re: initial 11n support for iwn (n, not m)

2015-12-16 Thread David Hill
Hi Stefan - Thanks for the 11n work! Unfortunately, your diff breaks iwn on my machine. iwn0 at pci2 dev 0 function 0 "Intel Centrino Ultimate-N 6300" rev 0x35: msi, MIMO 3T3R, MoW, It spews over and over: iwn0: fatal firmware error firmware error log: error type = "SYSASSERT" (0x0

netinet6 - bcopy -> memcpy

2015-12-02 Thread David Hill
Hello - Here are a few bcopy -> memcpy conversions for buffers that do not overlap. Index: sys/netinet6/ip6_forward.c === RCS file: /cvs/src/sys/netinet6/ip6_forward.c,v retrieving revision 1.86 diff -u -p -r1.86 ip6_forward.c --- sy

Re: use m_defrag in fxp

2015-12-01 Thread David Hill
On Tue, Dec 01, 2015 at 07:30:44PM +0100, Claudio Jeker wrote: > Use m_defrag in fxp to make it nicer and simpler. > > works for me with > fxp0 at pci6 dev 6 function 0 "Intel 8255x" rev 0x08, i82559: apic 6 int 21, > address 00:d0:b7:4c:36:c4 > inphy0 at fxp0 phy 1: i82555 10/100 PHY, rev. 4 >

Re: netstat -P - no namelist

2015-11-23 Thread David Hill
On Fri, Nov 20, 2015 at 12:07:36PM -0500, David Hill wrote: > Hello - > > I used to use netstat -P to view PCB information. Running -current, I > get 'no namelist' now. Any ideas? > > 0xff0397c4da50 tcp 0 0 127.0.0.1.33845127.0.0.1.18333 &g

netstat -P - no namelist

2015-11-20 Thread David Hill
Hello - I used to use netstat -P to view PCB information. Running -current, I get 'no namelist' now. Any ideas? 0xff0397c4da50 tcp 0 0 127.0.0.1.33845127.0.0.1.18333 ESTABLISHED # netstat -P 0xff0397c4da50 netstat: no namelist Thanks, David

tcpbench pledge

2015-11-10 Thread David Hill
Hello - pledge starts after getopt because of setrtable. rpath needed incase -k (kvm_openfile) proc needed for drop_gid (setresgid) I believe I've hit every code path. More eyes are welcome. Index: tcpbench.c === RCS file: /cvs/

  1   2   >