The imsg_init(3) man page currently doesn't make it clear whether
this library can be used for remote communication.
The current text reads:
The imsg functions provide a simple mechanism for communication
between processes using sockets. Each transmitted message is
guaranteed to be pr
o add some documentation but it stalled.
Here's a patch that adds the function synopsis and a brief description
of how watermarks work separately for read and write. Mostly copied from
the function declaration comments in event.h.
ok?
Geoff Hill
New patch included.
On Sat, Sep 22, 2018 at 07:09:44AM +0100, Jason McIntyre wrote:
> does the "ok" request mean you have commit access? (sorry, find it hard
> to keep track)
Nope, no commit access, just a user sending up a documentation fix.
> regarding the markup: there is no need to quote you
Looking at the ed25519 code, these defines are unused. They appear to be unused
upstream as well (in djt's supercop ed25519/ref implementation), so maybe this
should be suggested there instead of deviating. Up to you.
Index: usr.bin/signify/fe25519.c
==
Fix possible reads past the end of the buffer.
Found by random fuzz testing (zzuf). Without the fix the fuzzer crashes
in several seconds; with the patch, the fuzzer runs clean for hours.
Index: midiplay.c
===
RCS file: /cvs/src/usr.
> Any reason to not replace the somewhat arbitary earlier test
> for this?
I chose to keep the condition simpler and the existing constraints intact for
minimal impact, but I would agree it's better to consolidate with the existing
check.
Your diff looks good to me, +1.
Ran a grep to find unneccessary NULL checks before free(3) and found
some in dhclient(8) and makefs(8).
Geoff Hill
Index: sbin/dhclient/dhclient.c
===
RCS file: /cvs/src/sbin/dhclient/dhclient.c,v
retrieving revision 1.659
diff -u
