fix: cy(4) debug format strings

2017-02-01 Thread Jan Klemkow
Hi, the kernel does not compile with option CY_DEBUG because of several format string mistakes. This diff fixes them. It compiles on i386 and amd64 without any errors. bye, Jan Index: cy.c === RCS file: /cvs/openbsd/src/sys/dev/ic

Re: snmpd improvements

2016-12-21 Thread Jan Klemkow
On Wed, Dec 21, 2016 at 10:40:48AM +0100, Franco Fichtner wrote: > Hi, > > Switching from net-snmp to OpenBSD's snmpd raised two > issues and I'd like to know if they make sense to address: > > A pid file is missing. Would a patch for this be accepted? As far as I know, the OpenBSD project avoi

Diff: Fix wrong bzero call in snmpd

2016-09-02 Thread Jan Klemkow
Hi, When a new IP address shows up on an interface, the function if_newaddr() save this IP address and its mask and boardcast address into a data structure. If the corresponding IP mask or broad cast address is not set, their data fields in this structure are bzero()-ed. But, the code wipes the

Re: Fix NULL dereference in snmpd/snmpctl

2016-05-22 Thread Jan Klemkow
tthew wrote: > On Mon, May 09, 2016 at 09:37:08PM +0200, Jan Klemkow wrote: > > Hello, > > > > The function ber_free_elements() sets the variable ber to NULL in most > > error cases and calls ber_free_elements(ber). This causes a NULL > > dereference in ber_free_

Re: diff: httpd: add client side certificate checks + test

2016-05-17 Thread Jan Klemkow
ping. Tested with current source status. On Tue, May 10, 2016 at 06:59:36PM +0200, Jan Klemkow wrote: > Hi, > > This diff adds client side certificate checks to httpd. Most parts are > straight forward. But, to transfer the whole certificate authority > store to the server proc

diff: httpd: add client side certificate checks + test

2016-05-10 Thread Jan Klemkow
Hi, This diff adds client side certificate checks to httpd. Most parts are straight forward. But, to transfer the whole certificate authority store to the server process through the imsg infrastructure I had to change this in an chunked transfer. The Documentation of this feature is included in

Fix NULL dereference in snmpd/snmpctl

2016-05-09 Thread Jan Klemkow
Hello, The function ber_free_elements() sets the variable ber to NULL in most error cases and calls ber_free_elements(ber). This causes a NULL dereference in ber_free_elements. This patch fix that problem. bye, Jan Index: ber.c ==

Re: diff: httpd: add client side certificate checks

2016-01-22 Thread Jan Klemkow
ping On Fri, Jan 15, 2016 at 12:54:55PM +0100, Jan Klemkow wrote: > Hi, > > this diff adds client side certificate checks to httpd. Most parts > are straight forward. But, to transfer the whole certificate > authority store to the server process through the imsg infrastruc

diff: httpd: add client side certificate checks

2016-01-15 Thread Jan Klemkow
Hi, this diff adds client side certificate checks to httpd. Most parts are straight forward. But, to transfer the whole certificate authority store to the server process through the imsg infrastructure I had to change this in an chunked transfer. Documentation of this feature in httpd.conf.5 is

tls_init.3 add small info

2015-11-05 Thread Jan Klemkow
Hi, I'm playing around with client-side certificates[1] and saw that the manpage of tls_init.3 recommend to uses the functions: tls_config_set_ca_{file,path,mem} only in client context. But to check client-side certificates its also useful in server context. bye, Jan [1]: https://github.com/you

libtls: add tls_accept_fds()

2015-03-29 Thread Jan Klemkow
Hi, this diff adds tls_accept_fds(3) to libtls. It allows to accept server side tls connections based on separate file descriptors for read and write, like tls_connect_fds(3) for client side connections. I tried to keep this diff similar to tls_connect_fds. If anything is wrong just tell me. I

Re: new: libowfat

2014-11-05 Thread Jan Klemkow
On Sun, Nov 02, 2014 at 09:40:20AM +, Stuart Henderson wrote: > On 2014/11/01 21:22, Jan Klemkow wrote: > > Hi, > > > > this is a new port of Fefe's reimplementation of libdjb. This library > > is a reimplementation of libdjb. It contains several wrappers

Re: ressl: two way fds extention

2014-11-01 Thread Jan Klemkow
On Fri, Oct 31, 2014 at 09:18:26PM -0700, Doug Hogan wrote: > On Sat, Nov 01, 2014 at 03:07:24AM +0100, Jan Klemkow wrote: > > Index: tls_client.c > > === > > RCS file: /cvs/src/lib/libtls/tls_client.c,v > &

Re: ressl: two way fds extention

2014-10-31 Thread Jan Klemkow
Hi Joel, On Sat, Nov 01, 2014 at 03:28:04AM +1100, Joel Sing wrote: > How about this API - instead of having a (now) tls_set_fds() function and then > calling tls_connect_socket(), you call tls_connect_fds() directly if you need > that functionality? Yes, your approach fits perfectly my needs and

make: debug output to stderr

2014-10-31 Thread Jan Klemkow
Hi, this diff turns debug output of make to stderr. This is the first step to unbreak a make -d A run under ports. I tested this diff with a full kernel and userland build under amd64 architecture. Bye, Jan Index: arch.c === RCS f

ftp: use constant instead of value

2014-10-30 Thread Jan Klemkow
Hi, This diff just swaps -2 with the actual constant to increase readability of the ftp source code. bye, Jan Index: fetch.c === RCS file: /cvs/src/usr.bin/ftp/fetch.c,v retrieving revision 1.132 diff -u -p -r1.132 fetch.c --- fetch

ressl: two way fds extention

2014-10-29 Thread Jan Klemkow
Hello, This diff enables libressl to use two file descriptors for read and write. This is feature is necessary for communication over two pipes like in the UCSPI protocol [1]. resslc[3] is a general ssl-client. +---+ ++ ++ | tcpserver | --> | resslc | --> | clien

Re: rm reference to obsolete functions

2014-01-30 Thread Jan Klemkow
On Thu, Jan 30, 2014 at 09:21:52AM +0001, Jason McIntyre wrote: > On Wed, Jan 29, 2014 at 08:44:05PM +0100, Jan Klemkow wrote: > > Hi, > > > > I've made a little diff to clean up some manpages with references to the > > obsoleted functions usleep(1),

Fix: Seg. fault in make(1) by wrong fmt string arguments

2014-01-29 Thread Jan Klemkow
Hi, I found two segmentation faults in make(1). Here is a diff that should fix these bugs. bye, Jan Index: var.c === RCS file: /cvs/src/usr.bin/make/var.c,v retrieving revision 1.96 diff -u -p -r1.96 var.c --- var.c 6 Jan 201

rm reference to obsolete functions

2014-01-29 Thread Jan Klemkow
Hi, I've made a little diff to clean up some manpages with references to the obsoleted functions usleep(1), alarm(3). bye, Jan Index: bin/sleep/sleep.1 === RCS file: /cvs/src/bin/sleep/sleep.1,v retrieving revision 1.19 diff -u -p -

Re: linebuffering diff for tr(1)

2013-11-20 Thread Jan Klemkow
On Tue, Nov 19, 2013 at 09:34:22PM +, Stuart Henderson wrote: > On 2013/11/19 14:10, Theo de Raadt wrote: > > In general, new non-standard options are bad. I know and this is my own opinion to, in general. > > Basically, if we add this someone will use it in a script. Then it will > > become

linebuffering diff for tr(1)

2013-11-19 Thread Jan Klemkow
Hi, here is a diff that adds optional linebuffering to tr(1) with command line switch -u like in sed(1). I need this to remove '\r' characters from a continues input steam which lines have to be there immediately. Please write me if something is wrong with this diff or the change itself. I will

Re: Diff: for hashing of carp password

2013-07-02 Thread Jan Klemkow
efer the hashing version. bye, Jan On Tue, Jul 02, 2013 at 01:04:49PM +0200, Alexander Bluhm wrote: > On Tue, Jul 02, 2013 at 12:27:54PM +0200, Jan Klemkow wrote: > > Hi, > > > > This diff implements the hashing of the carp password before using it > > insid

Diff: for hashing of carp password

2013-07-02 Thread Jan Klemkow
Hi, This diff implements the hashing of the carp password before using it inside of the Kernel. It fix the problem that passwords like "12345678901234567890" and "12345678901234567890XXX" are equal for carp. But It breaks the compatibility with older Versions. Maybe you need to increase the prot

correct includes in man(9) pages

2013-06-04 Thread Jan Klemkow
Hi, This diff converts all obsolete '.Fd' tags into '.In' tags of manpages of category nine. I hope this diff is ok and that there are no 3rd party dependencies in kernel ;-) If something is wrong with it, just wrote me and I will fix it. I need this change for a private manpage scripting proje

Re: ftp mput recursiv upload diff for testing

2012-07-30 Thread Jan Klemkow
Hopefully the final version. Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 30 Jul 2012 07:58:16 - @

Re: ftp mput recursiv upload diff for testing

2012-07-28 Thread Jan Klemkow
I fixed a few things from the mails bevor... Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 28 Jul 2012

Re: ftp mput recursiv upload diff for testing

2012-07-23 Thread Jan Klemkow
Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v retrieving revision 1.70 diff -u -p -r1.70 cmds.c --- cmds.c 5 May 2009 19:35:30 - 1.70 +++ cmds.c 23 Jul 2012 18:49:30 - @@ -231,15 +231,32 @@ mput(int

Re: ftp mput recursiv upload diff for testing

2012-07-15 Thread Jan Klemkow
Now it is, much more like mput(). I just add some error messages for the local and remote chdir/cd funktions. I So that the user has a chance to detect an error. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v ret

Re: ftp mput recursiv upload diff for testing

2012-07-12 Thread Jan Klemkow
I fixed the most things. It took me a while to figure out what that code does, so I think the comments are usefull for everybody who tries to read it. The file type information comes from this special remglob2() function. There is no equivalent thing in the context of mput(). So I check the loca

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
On Mon, Jul 09, 2012 at 02:00:11PM +0200, Jan Klemkow wrote: > Hello, > > this is the same diff, but the mapage part it adaptet, for the current > version of ftp.1 in cvs. > > bye, > Jan > > On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: > > O

Re: ftp mput recursiv upload diff for testing

2012-07-09 Thread Jan Klemkow
Hello, this is the same diff, but the mapage part it adaptet, for the current version of ftp.1 in cvs. bye, Jan On Thu, Jan 26, 2012 at 09:44:45PM +0100, Jan Klemkow wrote: > On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: > > Hello, > > > > this is my diff

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
sounds reasonable. On Mon, Mar 12, 2012 at 02:18:42PM +0100, Mark Kettenis wrote: > > Date: Mon, 12 Mar 2012 13:45:58 +0100 > > From: Jan Klemkow > > > > The return of EINVAL on fp NULL comes from me. I think its even an > > invalid argument like the other poin

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. The rest should be fine now. Thank you. On Thu, Mar 08, 2012 at 02:15:28AM +, Federico Schwindt wrote: > On Wed, Mar 7, 2012 at 7:42 AM, Jan Klemkow wrote: > > Hi

Re: NEW: libc getdelim(3) and getline(3)

2012-02-28 Thread Jan Klemkow
r fflush 3 , +.Xr malloc 3 , +.Xr read 2 , +.Xr stat 2 , +or +.Xr realloc 3 . +.Sh SEE ALSO +.Xr ferror 3 , +.Xr fgets 3 , +.Xr fgetln 3 , +.Xr fopen 3 +.Sh STANDARDS +The +.Fn getdelim +and +.Fn getline +functions conform to +.St -p1003.1-2008 . Index: lib/libc/stdio/getdelim.c ======= RCS file: lib

Re: Unbound in base

2012-02-17 Thread Jan Klemkow
opinion the replacement of bind with unbound and nsd is more important than the support for this kind of setups :-) On Fri, Feb 17, 2012 at 12:01:46PM +0100, Henning Brauer wrote: > * Jan Klemkow [2012-02-17 10:45]: > > There is an other problem with replacing bind with unbound and ns

Re: Unbound in base

2012-02-17 Thread Jan Klemkow
bind in ports if we do the replacement. So that the admins out there could easily use OpenBSD as a DNS-Server with such extra features. -- Jan Klemkow

Re: PATCH: failed spl lock release in pmap

2012-02-03 Thread Jan Klemkow
What is about this patch? thanks, Jan On Fri, Dec 02, 2011 at 06:31:47PM +0100, Jan Klemkow wrote: > Hello, > > I've found an other spl lock lease failure. > It's in an architecture which i couldn't test. > But, I think the diff should work. >

Re: NEW: libc getdelim(3) and getline(3)

2012-02-03 Thread Jan Klemkow
Sh STANDARDS +The +.Fn getdelim +and +.Fn getline +functions conform to +.St -p1003.1-2008 . Index: getdelim.c ======= RCS file: getdelim.c diff -N getdelim.c --- /dev/null 1 Jan 1970 00:00:00 - +++ getdelim.c 3 Feb 2012 15:4

NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Jan Klemkow
pen 3 +.Sh STANDARDS +The +.Fn getdelim +and +.Fn getline +functions conform to +.St -p1003.1-2008 . Index: getdelim.c =========== RCS file: getdelim.c diff -N getdelim.c --- /dev/null 1 Jan 1970 00:00:00 - +++ getdelim.c 25 Jan 201

Re: ftp mput recursiv upload diff for testing

2012-01-26 Thread Jan Klemkow
On Thu, Jan 12, 2012 at 09:40:19PM +0100, Jan Klemkow wrote: > Hello, > > this is my diff for recursive upload for ftp(1). > It modifies the mput command for doing this. > Please test it and tell me everything that is > wrong with it. > > bye, > Jan > I test thi

FIX: filedescriptor leak in vi

2012-01-20 Thread Jan Klemkow
Hello, this diff fixes a filedescriptor leak in vi. I compiled the code but I could not test the code path. bye, Jan Index: recover.c === RCS file: /mount/cvsdev/cvs/openbsd/src/usr.bin/vi/common/recover.c,v retrieving revision 1.1

FIX: filedescriptor leak in authpf.c

2012-01-18 Thread Jan Klemkow
Hello, this diff fix a filedescriptor leak in authpf.c. The function allowed_luser() is call one time directly from main() but I think it should be consistent. I just compiled the sources but could not test the code path. bye, Jan Index: authpf.c

memory leak in OpenSSH

2012-01-17 Thread Jan Klemkow
Hello, this diff fixes a memory leak in OpenSSH. I have compiled it, but could not test the code path. This function is always called with an already initialized buffer. bye, Jan Index: authfile.c === RCS file: /mount/cvsdev/cvs/o

memory leak in OpenSSH

2012-01-16 Thread Jan Klemkow
Hello, this is a diff which patch a memory leak in OpenSSH. I have just compiled it without warnings. I am unable to run this exactly this code path. bye, Jan Index: ssh-pkcs11-client.c === RCS file: /mount/cvsdev/cvs/openbsd/src/u

ftp mput recursiv upload diff for testing

2012-01-12 Thread Jan Klemkow
Hello, this is my diff for recursive upload for ftp(1). It modifies the mput command for doing this. Please test it and tell me everything that is wrong with it. bye, Jan Index: cmds.c === RCS file: /cvs/src/usr.bin/ftp/cmds.c,v re

PATCH: failed spl lock release in trm

2011-12-02 Thread Jan Klemkow
Hello, This is the last spl lock leak which i've found with static code analysis. This is not in GENERIC. For testing I compiled it into my kernel and run the kernel without any error. bye, Jan Index: trm.c === RCS file: /mount/cvs

PATCH: failed spl lock release in if_wi_usb

2011-12-02 Thread Jan Klemkow
Hello, I've found an other failed spl release lock. The diff should fix it. I compiled it and run the new kernel without an error. I'm unable to do more tests on this. bye, Jan Index: if_wi_usb.c === RCS file: /mount/cvsdev/cvs/ope

PATCH: failed spl lock release in pmap

2011-12-02 Thread Jan Klemkow
Hello, I've found an other spl lock lease failure. It's in an architecture which i couldn't test. But, I think the diff should work. bye, Jan Index: pmap.c === RCS file: /mount/cvsdev/cvs/openbsd/src/sys/arch/solbourne/solbourne/pm

Re: PATCH: failed spl lock release in fxp

2011-12-02 Thread Jan Klemkow
Oh, sorry. Hope this fix is better. Quoting Marco Pfatschbacher : On Fri, Dec 02, 2011 at 12:02:19PM +0100, Jan Klemkow wrote: Hello, i have found an other failed error handling with interrupt locking. Here is a diff which should patch this. i don't think this compiles. your label i

PATCH: failed spl lock release in fxp

2011-12-02 Thread Jan Klemkow
Hello, i have found an other failed error handling with interrupt locking. Here is a diff which should patch this. bye, Jan Index: fxp.c === RCS file: /mount/cvsdev/cvs/openbsd/src/sys/dev/ic/fxp.c,v retrieving revision 1.108 diff

PATCH: failed spl lock release in pgt

2011-12-01 Thread Jan Klemkow
Hello, i have found some incorrect error handling in the pgt driver. Here is a diff which should patch this. bye, Jan Klemkow Index: pgt.c === RCS file: /mount/cvsdev/cvs/openbsd/src/sys/dev/ic/pgt.c,v retrieving revision 1.67

<    1   2   3